Re: [libvirt] [PATCH 24/28] Rename util.{c,h} to virutil.{c,h}
On Mon, Dec 17, 2012 at 10:22:11PM +0100, Michal Privoznik wrote:
On 17.12.2012 15:57, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> diff --git a/src/lxc/lxc_controller.c
b/src/lxc/lxc_controller.c
> index 6b6ec82..a8e99f2 100644
> --- a/src/lxc/lxc_controller.c
> +++ b/src/lxc/lxc_controller.c
> @@ -54,7 +54,7 @@
>
> #include "virterror_internal.h"
> #include "virlog.h"
> -#include "util.h"
> +#include "virutil.h"
>
> #include "lxc_conf.h"
> #include "lxc_container.h"
> @@ -64,7 +64,7 @@
> #include "virnetdev.h"
> #include "virnetdevveth.h"
> #include "viralloc.h"
> -#include "util.h"
> +#include "virutil.h"
> #include "virfile.h"
> #include "virpidfile.h"
> #include "vircommand.h"
Why do we have this include twice? One is sufficient ....
No idea, I did a global search-replace so didn't notice these
kind of issues myself.
BTW, if replying to large patches like this, please trim the
text you quote, to only leave context for either the file,
or method you are referring to. It took me a while to find
your one line comment !
Regards,
Danel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|