Re: [libvirt PATCH 266/351] meson: tools: install libvirt-guests sysconf file

On Thu, Jul 16, 2020 at 11:58:22 +0200, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > tools/Makefile.am | 13 ++----------- > tools/meson.build | 8 ++++++++ > 2 files changed, 10 insertions(+), 11 deletions(-) [...] > diff --git a/tools/meson.build b/tools/meson.build > index 446831557e1..b95ced3728b 100644 > --- a/tools/meson.build > +++ b/tools/meson.build > @@ -261,3 +261,11 @@ configure_file( > install: true, > install_dir: libexecdir, > ) > + > +if init_script == 'systemd' > + install_data( > + 'libvirt-guests.sysconf', > + install_dir: sysconfdir / 'sysconfig', > + rename: 'libvirt-guests', > + ) > +endif Arguably it's data at this point as it doesn't need to be modified, but shouldn't we use the config_file directive for any config file?