[PATCHv2 0/2] virsh: Add option '--no-pkttyagent'
This patchset should address all of your comments. Where "you" means
Peter Krempa, I hope that the "--in-reply-to" does its job as I would
expect it would do. Just to be sure, this is in reply to thread [1],
namely to the message with ID <aBnHTttMLaNd3E3U(a)angien.pipo.sk>.
Some minor nits I came across while implementing this, and you are
totally free to a) ignore them, b) fix them yourself, or c) ask me
to fix them in a separate patch:
- You actually do use assertions, namely in vsh.c. This is where I got
the idea from that using them in virsh.c, too, would be OK.
(Well, I guess option c) from above isn't something I'd want to do
for that nit...)
- In docs/manpages/virsh.rst, you use plain paragraphs for the
documentation of options --connect and --debug and bulleted items
for all other options.
Thanks for your support and for maintaining libvirt in general!
[1]:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/Y5...
Jens Schmidt (2):
virsh: Add option '--no-pkttyagent'
NEWS: Mention new option '--no-pkttyagent'
NEWS.rst | 4 ++++
docs/manpages/virsh.rst | 8 ++++++++
tools/virsh.c | 13 ++++++++++++-
tools/vsh.h | 1 +
4 files changed, 25 insertions(+), 1 deletion(-)
--
2.39.5