Re: [libvirt] [PATCH v4 03/10] qemu: caps: Introduce a capability for egl-headless
On Wed, Jul 18, 2018 at 03:08:39PM +0200, Pavel Hrdina wrote:
On Wed, Jul 18, 2018 at 02:57:30PM +0200, Erik Skultety wrote:
> On Wed, Jul 18, 2018 at 02:31:39PM +0200, Erik Skultety wrote:
> > Since QEMU 2.10, it's possible to use a new type of display -
> > egl-headless which uses drm nodes to provide OpenGL support. This patch
> > adds a capability for that. However, since QEMU doesn't provide a QMP
> > command to probe it, we have to base the capability on specific QEMU
> > version.
> >
> > Signed-off-by: Erik Skultety <eskultet(a)redhat.com>
> > Acked-by: Michal Privoznik <mprivozn(a)redhat.com>
> > Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
> > Signed-off-by: Erik Skultety <eskultet(a)redhat.com>
>
> Sigh, consider this extra SoB removed, that's probably just some interactive
> rebase bit I forgot about.
This happens if you use "-s" parameter, however, if you put your SoB
always on the last line of the commit message "-s" will not add second
one.
Yeah, I should start adding the RBs above the SoB to prevent that, I'm not
going to drop my auto-sign in the config, because I would just keep forgetting
to sign it.
Erik