Re: [libvirt] [PATCH v2] blockjob: use stable disk string in job event

On 06/17/2014 01:58 AM, Peter Krempa wrote: > On 06/16/14 23:58, Eric Blake wrote: >> When the block job event was first added, it was for block pull, >> where the active layer of the disk remains the same name. It was >> also in a day where we only cared about local files, and so we >> always had a canonical absolute file name. But two things have >> changed since then: we now have network disks, where determining >> a single absolute string does not really make sense; and we have >> two-phase jobs (copy and active commit) where the name of the >> active layer changes between the first event (ready, on the old >> name) and second (complete, on the pivoted name). >>

> > The two possible values stored here should also be mentioned here or a > note to read the text below. I would have skipped the blob below if I'd > find something that looks relevant here. Okay, I'll try again in v3.