Re: [PATCH] qemu: fix memory leak on some paths

From: lu zhipeng <luzhipeng(a)cestc.cn&gt; virTypedParamsAddString may return -1 but alloc params, so free it. Signed-off-by: lu zhipeng <luzhipeng(a)cestc.cn&gt; --- src/qemu/qemu_driver.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 94b70872d4..c4501cd705 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4473,11 +4473,13 @@ qemuDomainPinVcpuLive(virDomainObj *vm, goto cleanup; event = virDomainEventTunableNewFromObj(vm, eventParams, eventNparams);

- + eventNparams = 0;

ret = 0; cleanup: virObjectEventStateQueue(driver->domainEventState, event);

+ if (eventNparams) + virTypedParamsFree(eventParams, eventNparams); return ret; }