Re: [libvirt PATCH 49/80] qemu: Do not set job owner in qemuMigrationJobSetPhase
On Thu, May 12, 2022 at 13:26:01 +0200, Peter Krempa wrote:
On Tue, May 10, 2022 at 17:21:10 +0200, Jiri Denemark wrote:
> Both qemuMigrationJobSetPhase and qemuMigrationJobStartPhase were doing
> the same thing, which made little sense. Let's follow the difference
> between qemuDomainObjSetJobPhase and qemuDomainObjStartJobPhase and
> change job owner only in qemuMigrationJobStartPhase.
Okay so at this point qemuMigrationJobSetPhase will be used only when
advancing the Phase after already using qemuMigrationJobStartPhase in
the same function.
Mostly, qemuMigrationJobSetPhase may also be used in callbacks which do
not want to take over the job ownership, but need to change the phase.
Jirka