Re: [libvirt] [PATCH 2/8] snapshot: Fix virDomainUndefineFlags docs regarding snapshots
On Fri, Jul 05, 2019 at 23:37:29 -0500, Eric Blake wrote:
The docs talked about an active snapshot when they meant an active
domain; they also claimed the flag was a no-op for hypervisors with no
snapshot metadata even though the flag is rejected as unrecognized for
hypervisors with no snapshot support at all.
Reported-by: Peter Krempa <pkrempa(a)redhat.com>
Signed-off-by: Eric Blake <eblake(a)redhat.com>
---
src/libvirt-domain.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
I'd probably go for the trivial addition of the flag to all of the
undefine APIs since that does not require clients from encoding the
knowledge whether the given hypervisor supports snapshots at all.
This works too though as we'd reject the flag at this point anyways.
ACK
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)