Re: [libvirt] [PATCH v3] glibcompat: Reimplement g_strdup_printf() and g_strdup_vprintf()
On Fri, Oct 18, 2019 at 02:40:41PM +0200, Michal Privoznik wrote:
These functions don't really abort() on OOM. The fix was merged
upstream, but not in the minimal version we require. Provide our
own implementation which can be removed once we bump the minimal
version.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
Diff to v3:
- fixed infinite recursion
src/internal.h | 1 +
src/libvirt_private.syms | 5 ++++
src/util/Makefile.inc.am | 2 ++
src/util/glibcompat.c | 51 ++++++++++++++++++++++++++++++++++++++++
src/util/glibcompat.h | 31 ++++++++++++++++++++++++
5 files changed, 90 insertions(+)
create mode 100644 src/util/glibcompat.c
create mode 100644 src/util/glibcompat.h
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|