Re: [Libvir] PATCH 1/5: Use pkg-config for libxml

Currently if you have a configured working directory and you touch some file that would cause autoconf to re-run configure it'll crash & burn with an error like $ make cd . && /bin/sh /home/berrange/src/xen/libvirt/missing --run aclocal-1.9 -I m4 cd . && /bin/sh /home/berrange/src/xen/libvirt/missing --run automake-1.9 --gnu cd . && /bin/sh /home/berrange/src/xen/libvirt/missing --run autoconf configure.in:268: error: possibly undefined macro: PKG_CONFIG_ENABLED If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. This is due to this bit of configure where we reference an env variable which doesn't exist: if test "z$with_libxml" = "zno" ; then AC_MSG_CHECKING(for libxml2 libraries >= $LIBXML_MIN_VERSION) AC_MSG_ERROR(libxml2 >= $LIBXML_MIN_VERSION is required for $XMLSEC_PACKAGE) elif test "z$with_libxml" = "z" -a "z$PKG_CONFIG_ENABLED" = "zyes" ; then PKG_CHECK_MODULES(LIBXML, libxml-2.0 >= $LIBXML_MIN_VERSION, [LIBXML_FOUND=yes], [LIBXML_FOUND=no]) fi The whole test for libxml is overly complex and can be reduced to a single call to PKG_CHECK_MODULES. There is no need to have special configure script --with_libxml args to override the location, since pkg-config already gives you two ways todo that - either use PKG_CONFIG_PATH to point to your alternative install, or use LIBXML_CFLAGS and LIBXML_LIBS env vars to set the explicitly flags. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|