Re: [libvirt] [PATCH] Let make fail when XHTML validation fails

> > diff --git a/docs/Makefile.am b/docs/Makefile.am > > index eaac627..4df5154 100644 > > --- a/docs/Makefile.am > > +++ b/docs/Makefile.am > > @@ -108,7 +108,7 @@ ChangeLog.html.in: ChangeLog.xml ChangeLog.xsl > > @(if [ -x $(XMLLINT) -a -x $(XMLCATALOG) ] ; then \ > > if $(XMLCATALOG) /etc/xml/catalog "-//W3C//DTD XHTML 1.0 Strict//EN" > /dev/null ; then \ > > echo "Validating $@" ; \ > > - $(XMLLINT) --nonet --format --valid $< > $@ || : ; \ > > + $(XMLLINT) --nonet --format --valid $< > $@ || (rm $@ && exit 1) ; \ > > else echo "missing XHTML1 DTD" ; fi ; fi ); > > Hum, maybe that's a bit excessive, while it make sense to see the > error in a development environment, I find this a bit hard at > installation time. It shouldn't cause any troubles at installation time. If either xmllint, xmlcatalog or XHTML DTDs are not found, the validation is just skipped without any error. If all of those are found, there is no reason why it would fail as all html.in files which are in git are valid XHTML 1.0. Or did I miss anything?