Re: [libvirt] [libvirt-php] bug in libvirt_domain_change_vcpus()
On 09/10/2013 10:09 AM, Daniel P. Berrange wrote:
On Mon, Sep 09, 2013 at 06:51:54PM +0200, Michal Novotny wrote:
> Hi Olivier,
> this is not really a bug as it's intended. The
> libvirt_domain_change_vcpus() is not the same as (yet unimplemented)
> virDomainSetVcpus() API so it's not bug. I realize that naming could be
> a little confusing so if you like, feel free to rename
> libvirt_domain_change_vcpus() to libvirt_domain_xml_change_vcpus() as
> this API should be used to change number of vCPUS in the domain XML
> itself and implement libvirt_domain_set_vcpus() calling real
> virDomainSetVcpus() API function.
That function is also buggy in that it will silently turn a transient
guest into a persistent guest, which is almost certainly not what a
caller would expect
Daniel
Thanks for information Daniel. You are correct. I did change the
implementation to use virDomainSetVcpusFlags() API function instead.
It's already committed to git [1].
Michal
[1]
http://libvirt.org/git/?p=libvirt-php.git;a=commit;h=cff010a36e382ee26c10...
--
Michal Novotny <minovotn(a)redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings | php-virt-control.org