On 05/03/2011 10:32 PM, Laine Stump wrote:
On 05/03/2011 06:14 PM, Eric Blake wrote:
> clang didn't like the last increment to nargs. But why even
> track nargs ourselves, when virCommand does it for us?
>
> * src/storage/storage_backend_iscsi.c
> (virStorageBackendISCSIConnection): Switch to virCommand to avoid
> a dead-store warning on nargs.
> ---
> src/storage/storage_backend_iscsi.c | 36
> ++++++++--------------------------
> 1 files changed, 9 insertions(+), 27 deletions(-)
ACK. It really is nice how much cruft is removed when switching to
virCommand!
Thanks; pushed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org