Re: [libvirt] [PATCHv3 2/2] VMware: Initial VMware Fusion support
2013/9/24 Doug Goldstein <cardoe(a)cardoe.com>:
Add support for VMware Fusion in the existing VMware driver.
Connect
via the URI vmwarefusion:///session
---
change from v2:
* Re-add missing hunk that got rebased away in vmwareParseVersionStr()
change from v1:
* ifdef PATH for Apple machines only
---
docs/drvvmware.html.in | 15 +++++++++++----
src/vmware/vmware_conf.c | 11 ++++++++++-
src/vmware/vmware_conf.h | 1 +
src/vmware/vmware_driver.c | 5 +++++
4 files changed, 27 insertions(+), 5 deletions(-)
diff --git a/src/vmware/vmware_conf.c b/src/vmware/vmware_conf.c
index c11c92d..027e245 100644
--- a/src/vmware/vmware_conf.c
+++ b/src/vmware/vmware_conf.c
diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c
index 01d65ed..4db2ad2 100644
--- a/src/vmware/vmware_driver.c
+++ b/src/vmware/vmware_driver.c
@@ -103,6 +107,7 @@ vmwareConnectOpen(virConnectPtr conn,
} else {
if (conn->uri->scheme == NULL ||
(STRNEQ(conn->uri->scheme, "vmwareplayer") &&
+ STRNEQ(conn->uri->scheme, "vmwarefusion") &&
STRNEQ(conn->uri->scheme, "vmwarews")))
In other places the three types are in player/ws/fusion order. Maybe
reorder this check to get the same order here too.
return VIR_DRV_OPEN_DECLINED;
Two if statements further down is an error message for the URI path
check that suggests
"try vmwareplayer:///session or vmwarews:///session"
You should append vmwarefusion:///session to that message.
ACK.
--
Matthias Bolte
http://photron.blogspot.com