Re: [PATCH] docs: Add man page for libvirt-guests

On Fri, Jan 07, 2022 at 02:38:15PM -0700, Jim Fehlig wrote: > +++ b/docs/manpages/meson.build > @@ -39,6 +39,7 @@ docs_man_files = [ > { 'name': 'virtvboxd', 'section': '8', 'install': conf.has('WITH_VBOX') }, > { 'name': 'virtvzd', 'section': '8', 'install': conf.has('WITH_VZ') }, > { 'name': 'virtxend', 'section': '8', 'install': conf.has('WITH_LIBXL') }, > + { 'name': 'libvirt-guests', 'section': '8', 'install': true }, I would have expected 'install': conf.has('WITH_LIBVIRTD')

here but I see that we actually install the script and its unit file unconditionally. I think that might be a bug, but it also looks like the script supports starting/stopping *remote* guests when the host power cycles? That'd be an interesting setup :)

You should make sure to tweak libvirt.spec.in so that the manual page gets included in RPM packages.