Re: [libvirt] [PATCH] storage: allow metadata preallocation when creating qcow2 images
On 11/08/12 23:10, Eric Blake wrote:
On 11/08/2012 09:28 AM, Daniel P. Berrange wrote:
>
> I've thought about doing it this way before, but I always felt it was
> a bit of a gross hack. It would be nice to keep the 'allocation' element
> as purely describing the data sector allocation. I was recently wondering
> if we should just add a flag to the virStorageVolCreate like
>
> VIR_STORAGE_VOL_PREALLOC_METADATA
I agree that adding a new flag is cleaner; thankfully,
virStorageVolCreateXML has a flags argument ready to use.
I found an older thread [1] dealing with this and it seems it doesn't
belong in the XML as a separate element either. I'll post another
version with the flag.
[1] https://www.redhat.com/archives/libvir-list/2012-May/msg00847.html