Re: [Libvir] PATCH: Allow updating of timer & file handle event watches
On Wed, Sep 19, 2007 at 03:04:12AM +0100, Daniel P. Berrange wrote:
On Tue, Sep 18, 2007 at 03:49:02AM -0400, Daniel Veillard wrote:
> From a stylistic POV I notice the function comment description is in the
> header files, not in the C file like others parts of libvirt, as long as
> one doesn't forget to update them when updating the code, that's fine.
Not sure why I put them in the header files originally - I guess since its
internal API its not in the docs, so its easy to browse the docs directly
in the header file without being cluttered by the code. If you think they're
better off in the C file for consistency, I'll move it
As long as we don't try to automatically extract the docs for the internals
(which may be needed at some point as the internals are growing) I don't
think there is a need for a change really,
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/