Re: [Libvir] [PATCH] fix compilation with USE_XEN == 0
On Thu, Jan 31, 2008 at 04:14:09PM +0100, Jim Meyering wrote:
Guido Guenther <agx(a)sigxcpu.org> wrote:
> statstest.c needs to check if USE_XEN > 0, otherwise compilation breaks
> on --without-xen builds. Please apply if appropriate. Patch is against
> current cvs.
Thanks for the report, but your patch didn't make it to the list.
That has happened to me when I've included the output
of e.g., git format-patch in the message. Its headers
confuse the old version of Mailman that this list is using.
If you think something like that happened here, please
send me a copy of your original message and I'll look into it.
Yes, I actually
used git. Here it is without the headers:
diff --git a/tests/statstest.c b/tests/statstest.c
index 4c19833..6213da8 100644
--- a/tests/statstest.c
+++ b/tests/statstest.c
@@ -12,7 +12,7 @@ static void testQuietError(void *userData ATTRIBUTE_UNUSED, virErrorPtr
error AT
/* nada */
}
-#ifdef __linux__
+#if __linux__ && WITH_XEN
static int testDevice(const char *path, int expect)
{
int actual = xenLinuxDomainDeviceID(NULL, 1, path);
@@ -31,7 +31,7 @@ int
main(void)
{
int ret = 0;
-#ifdef __linux__
+#if __linux__ && WITH_XEN
/* Some of our tests delibrately test failure cases, so
* register a handler to stop error messages cluttering
* up display