Re: [libvirt] [PATCH] sheepdog: allow snapshot
2015-11-30 13:45 GMT+03:00 Vasiliy Tolstov <v.tolstov(a)selfip.ru>:
In commit f7c1410b0ee5b878e81f2eddf86c609947a9b27c libvirt devs
disable creating snapshot with sheepdog storage and raw image format.
This patch allows creating snapshot (without --live flag for now)
Vasiliy Tolstov (1):
sheepdog: allow snapshot
src/qemu/qemu_driver.c | 6 ++++++
1 file changed, 6 insertions(+)
Next steps is to fix --live flag for snapshot, but i'm not understand message:
live snapshot creation is supported only with external checkpoints
i'm check the code
/* reject the VIR_DOMAIN_SNAPSHOT_CREATE_LIVE flag where not supported */
if (flags & VIR_DOMAIN_SNAPSHOT_CREATE_LIVE &&
(!virDomainObjIsActive(vm) ||
def->memory != VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL ||
redefine)) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("live snapshot creation is supported only "
"with external checkpoints"));
goto cleanup;
}
and have a question:
in case of sheepdog storage it allows to save memory (qemu have
ability to create full vm snapshot with memory), but if domain have
many disks (two sheepdog for example) how fix this code? And on which
disk libvirt save the vm state?
--
Vasiliy Tolstov,
e-mail: v.tolstov(a)selfip.ru