Re: [libvirt] [PATCH] Add success output to virsh attach/detach commands
On Fri, Aug 22, 2008 at 09:26:13AM +0100, Richard W.M. Jones wrote:
On Thu, Aug 21, 2008 at 11:19:29PM -0400, Cole Robinson wrote:
> The virsh attach-* and detach-* commands don't say
> anything if the operation succeeds, which doesn't
> seem very polite. The attached adds some simple
> feedback.
Hmmm ... The patch is fine, but I don't really like commands which
are verbose on anything other than errors.
Nor do I, but all our other commands print a confirmation message
too, so for sake of consistency I think Cole's patch is reasonable.
We do have a --quiet arg to make it STFU
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|