Re: [libvirt] [PATCH 3/3] Coverity: Resolve a RESOURCE_LEAK
On 03/25/2014 12:00 PM, John Ferlan wrote:
On error the lofd would have been leaked.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/lxc/lxc_controller.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
+
+ cleanup:
VIR_FREE(loname);
+ if (ret == -1)
I might have written 'if (ret < 0)' as that is slightly faster on many
machines, but what you have works.
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)