Re: [libvirt-ci PATCH v2] guests: add libvirt-php project packages
On Tue, May 05, 2020 at 03:05:42PM +0200, Andrea Bolognani wrote:
On Tue, 2020-05-05 at 12:48 +0100, Daniel P. Berrangé wrote:
> + php-imagick:
> + default: php-imagick
> + FreeBSD: php74-pecl-imagick
> + Fedora: php-pecl-imagick
> + CentOS: php-pecl-imagick
> + CentOS8:
This could be
php-imagick:
deb: php-imagick
rpm: php-pecl-imagick
pkg: php74-pecl-imagick
CentOS8:
Ok.
This patch is also missing the part where the libvirt-php project is
added to the 'projects' fact for all targets that actually support
building it, which would be all of them but CentOS 8 in this case I
guess?
We're also missing build steps for the project. I understand that,
as we move stuff off CentOS CI and into GitLab CI containers become
more important than VMs, but I think keeping 'lcitool build' working
is still important, if nothing else as a development tool. It
certainly makes my life easier as a reviewer... Not to mention it is
the only way we can currently validate FreeBSD changes.
There's a bunch of projects we don't have in Jenkins CI right now, and
I'm trying to get them all wired up into GitLab CI. I don't want to
invest any more time in VM build aspects right now, as I don't have
the time to spend testing & debugging that part too. So I'm only going
to do the minimal required to get container builds work, which is defining
the package lists used to feed the container build. The extra VM build
stuff can be done separately at a later date if we decide we need that
still for CI.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|