Re: [libvirt] [PATCH 1 of 5] Split out version script into multiple files
On Tue, Dec 23, 2008 at 06:31:14PM +0100, Jim Meyering wrote:
John Levon <john.levon(a)sun.com> wrote:
> On Tue, Dec 23, 2008 at 12:57:19PM +0100, Jim Meyering wrote:
>
>> This all looks fine, but I'd prefer to retain the WARNING in the generated
>> file, so that people are less likely to modify it directly. Along the
>
> Sure, your changes sound fine - are you going to commit your version?
I had trouble applying the first change set, both in configure.in
(rejected hunk) and with the renamed file. Plus I made some small
additional changes, so please check it carefully. The other 4 applied
cleanly. Also, look over the five log messages. Each of those will be
copied mechanically into the ChangeLog file.
Once you sign off, I'll commit these.
ACK to this.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|