On 03/28/2014 04:01 PM, Peter Krempa wrote:
https://bugzilla.redhat.com/show_bug.cgi?id=1072714
Use the "gluster" command line tool to retrieve information about remote
volumes on a gluster server to allow storage pool source lookup.
Unfortunately gluster doesn't provide a management library so that we
could use that directly, instead the RPC calls are hardcoded in the
command line tool.
---
configure.ac | 6 +++
src/storage/storage_backend.c | 86 ++++++++++++++++++++++++++++++++++++++++
src/storage/storage_backend.h | 4 ++
src/storage/storage_backend_fs.c | 5 +++
4 files changed, 101 insertions(+)
New feature rather than bug fix; please wait until after 1.2.3 to push.
+ cmd = virCommandNewArgList(GLUSTER_CLI,
+ "--xml",
At least it's machine-parseable, and not free-form regex prone to
mistakes on funky names :)
+ if (virCommandRun(cmd, &rc) < 0)
+ goto cleanup;
+
+ if (rc != 0) {
+ VIR_INFO("failed to query host '%s' for gluster volumes: %s",
+ host, outbuf);
Fair enough to suppress log messages on failure.
ACK
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org