Re: [libvirt] [REPOST 3/4] Revert "qemu: do not put a task into machine cgroup"
On Thu, Jan 14, 2016 at 11:10:36AM -0500, John Ferlan wrote:
On 01/14/2016 06:59 AM, Daniel P. Berrange wrote:
> On Wed, Jan 13, 2016 at 07:29:49AM -0500, John Ferlan wrote:
>> This reverts commit a41c00b472efaa192d2deae51ab732e65903238f.
>>
>> The patch was causing erroneous updates to the /proc/$pid/cgroup file.
>> This resulted in some unexpected behavoirs.
>>
>> Signed-off-by: John Ferlan <jferlan(a)redhat.com>
>
> ACK,
>
> Please also revert
>
> commit 71ce475967b3523882b0e1a0f649fdbea5abf9d5
> Author: Henning Schild <henning.schild(a)siemens.com>
> Date: Wed Dec 9 17:58:10 2015 +0100
>
> util: cgroups do not implicitly add task to new machine cgroup
>
> Regards,
> Daniel
>
So the order of revert is patch 2/3 (commit id 'a41c00b472'), patch 1/3
(commit id '71ce4759'), the lxc patch made as a result of patch 1/3
(commit id 'ae09988e').
Then also apply patch 1/4 of this series.
Yep
Learned quite a bit about cgroups...
I re-learned all the bits I had forgotten :-P
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|