Re: [libvirt] [PATCH] Fix import of private key with older gnutls
On Tue, Jul 26, 2011 at 06:14:27PM +0800, Daniel Veillard wrote:
On Mon, Jul 25, 2011 at 06:18:42PM +0100, Daniel P. Berrange wrote:
> With older GNUTLS the gnutls_x509_privkey_import function is
> unable to import our private key. Instead we must use the
> alternative gnutls_x509_privkey_import_pkcs8() (as certtool
> does).
>
> * virnettlscontexttest.c: Fix import of private key with
> older gnutls. Also add missing newlines to key
I just got in trouble with an older gnutls trying to build on
RHEL-5 too:
../src/.libs/libvirt-net-rpc.a(libvirt_net_rpc_la-virnettlscontext.o):
In function `virNetTLSContextCheckCertBasicConstraints':
/u/veillard/libvirt/src/rpc/virnettlscontext.c:149: undefined reference
to `gnutls_x509_crt_get_basic_constraints'
collect2: ld returned 1 exit status
Maybe we should check for that specific entry point in configure and
disable that part of the cert checking if not available,
I'm looking into that now. There may well be a different function I
can use to get the same data.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|