Re: [libvirt] [PATCH 02/10] Check and handle error for virAsprintf() calls. Ignore the return in parallelsMakePoolName() since subsequent check validates name was allocated.
On 01/03/2013 12:32 PM, Daniel P. Berrange wrote:
NB, you should restrict the first line of the commit message to
approx 70 characters. Then have a single blank line, followed
by the longer description. This ensures that you get sensible
subject lines :-)
Also, using the same subject line across multiple patches can cause
grief to backporting efforts. Inserting a prefix to say which portion
of code is touched helps to both remove the ambiguity and make it easier
to see at a glance why there are multiple patches. I've modified the
commit message to:
parallels: check and handle error for virAsprintf() calls
Ignore the return in parallelsMakePoolName() since subsequent check
validates name was allocated.
ACK
and I've now pushed 1 and 2, and will continue reading through the
series. Congratulations on your first libvirt patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)