Re: [libvirt] [PATCH] qemuDomainRemoveMemoryDevice: unlink() memory backing file
On 02/02/2018 11:01 AM, Jiri Denemark wrote:
On Thu, Jan 11, 2018 at 13:24:57 +0100, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1461214
>
> Since fec8f9c49af we try to use predictable file names for
> 'memory-backend-file' objects. But that made us provide full path
> to qemu when hot plugging the object while previously we provided
> merely a directory. But this makes qemu behave differently. If
> qemu sees a path terminated with a directory it calls mkstemp()
> and unlinks the file immediately. But if it sees full path it
> just calls open(path, O_CREAT ..); and never unlinks the file.
> Therefore it's up to libvirt to unlink the file and not leave it
> behind.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
>
> Zack, can you please check if this patch is suitable for your use cases?
>
> src/qemu/qemu_hotplug.c | 3 +++
> src/qemu/qemu_process.c | 26 ++++++++++++++++++++++++++
> src/qemu/qemu_process.h | 4 ++++
> 3 files changed, 33 insertions(+)
ACK
Jirka
Thanks, pushed.
Michal