Re: [libvirt] [PATCHv2 3/5] hyperv: Add OpenWSMAN based client for the Hyper-V WMI API
On 08/26/2011 06:10 AM, Matthias Bolte wrote:
> > I pointed out a couple of nits, but nothing jumped out at
me as a
> > showstopper. ACK, and I'm happy if you push without posting a v3.
Here's the interdiff I'm going to apply, before I push the whole series.
Looks good. ACK to the interdiff.
@@ -61,6 +63,8 @@ hyperyVerifyResponse(WsManClient *client, WsXmlDocH
response,
return -1;
}
+ /* Check the HTTP response code and report an error if it's not 200 (OK),
+ * 400 (Bad Request) or 500 (Internal Server Error) */
if (responseCode != 200&& responseCode != 400&& responseCode !=
500) {
I'm wondering if we might ever want to check for other codes, like 401,
but that doesn't hold up this patch as-is.
+#
+# Based on MSDN Hyper-V WMI Classes:
+#http://msdn.microsoft.com/en-us/library/cc136986%28v=vs.85%29.aspx
No idea if that URL will be stable (MSDN isn't known for its usable
URLs), but it's the best we can do.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org