Re: [libvirt PATCH 00/24] tests: use g_auto more (glib chronicles)
On 9/4/21 4:43 PM, Ján Tomko wrote:
Ján Tomko (24):
tests: virnetdaemontest: split variable declarations
conf: add cleanup func for virNetworkXMLOption
conf: add cleanup func for virMacMap
tests: use g_autoptr instead of virObjectUnref
tests: qemu: use g_autofree
tests: network: use g_autofree
tests: libxl: use g_autofree
tests: nwfilter: use g_autofree
tests: vmx: use g_autofree
tests: vir: use g_autofree
tests: use g_autofree
tests: use g_autoptr instead of virJSONValueFree
tests: use g_auto for virCPUDataFree
tests: use g_auto instead of VIR_FORCE_FCLOSE
tests: use VIR_AUTOCLOSE
tests: use g_auto instead of vshTableFree
tests: use g_auto instead of virDomainFree
tests: qemu: remove pointless labels
tests: vmx: remove pointless labels
tests: libxl: remove pointless labels
tests: nwfilter: remove pointless labels
tests: vshtabletest: remove pointless labels
tests: vir: remove pointless labels
You missed removal of one cleanup: label in 23/24 (I had assumed it
would give a compile warning in that case, but the CI pipeline passed
it, so...)
tests: remove pointless labels
71 files changed, 628 insertions(+), 1226 deletions(-)
Beer-worthy statistics!
I had a couple random comments beyond the one up above, but that's the
only one that needs any action. Once you've fixed that, series:
Reviewed-by: Laine Stump <laine(a)redhat.com>