Re: [libvirt] [PATCH] virsh: Use old API if remote libvirtd does not support new

On 09/13/2011 09:16 AM, Peter Krempa wrote: > Commit ffe28ab74b821c916ec4ba8efb5c992454e4bd24 introduced regression > while comunicating with older libvirtd command 'domblkstat' used the new > API and did not check for VIR_ERR_RPC error code signalling the remote > server does not support this API and did not fall back to older API. > Thereafter 'domblkstat' ended with "error: unknown procedure: 243". > --- Or, maybe this means that we have a bug in our RPC code - when the local side gets VIR_ERR_RPC from the remote side due to unknown rpc number, should the local side be translating that into VIR_ERR_NO_SUPPORT instead of passing it back to the user as VIR_ERR_RPC? But only for unknown rpc numbers; for other rpc errors, VIR_ERR_RPC still makes sense.