Re: [libvirt] [PATCH 3/3] qemu: simplify json parsing

On 06/20/2015 01:42 PM, Eric Blake wrote: > Rather than grabbing an arbitrary JSON value and then checking > if it has the right type, we might as well request the correct > type to begin with. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > src/qemu/qemu_monitor_json.c | 164 ++++++++++++++++--------------------------- > 1 file changed, 61 insertions(+), 103 deletions(-) > > @@ -271,7 +269,7 @@ qemuMonitorJSONCommandWithFd(qemuMonitorPtr mon, > > memset(&msg, 0, sizeof(msg)); > > - exe = virJSONValueObjectGet(cmd, "execute"); > + exe = virJSONValueObjectGetObject(cmd, "execute"); > if (exe) { > if (!(id = qemuMonitorNextCommandID(mon))) > goto cleanup; This hunk is spurious (the 'execute' member is a string, not an object); I've removed it locally from my tree.