Re: [libvirt] [PATCH] Add test for legacy <console ... tty=""> syntax
On Wed, Nov 25, 2009 at 11:27:48AM +0000, Matthew Booth wrote:
On 25/11/09 11:25, Daniel P. Berrange wrote:
>On Mon, Nov 23, 2009 at 01:48:30PM +0000, Matthew Booth wrote:
>>* tests/qemuxml2argvtest.c: Test legacy syntax for QEMU argument
>>generation
>>* tests/qemuxml2argvdata/qemuxml2argv-console-legacy.(xml|args): Add test
>>data
>
>This test doesn't seem to test anything we're not already testing ?
Where's it currently tested? I couldn't see it. I also ran a make check
with this test in place before and after the recent tty= fix. It failed
before and succeeded afterwards.
That said, I'm not entirely sure what the console-compat test is
testing. Is it possible that the test was supposed to be in there?
Since you have both <serial> and <console> elements there, <console>
is ignored. Essentially <console> is just a pointer to the first
serial port. <console> would only have been looked at if you hadn't
had the <serial> tag there, in which case it would have been copied
to the serial tag
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|