Re: [libvirt] [PATCH 6/6] build: detect/prohibit hardcoded XML indent in syntax-check
On 03/12/2014 10:04 PM, Laine Stump wrote:
This rule wouldn't be able to find any case of a hardcoded indent
that
was in the middle of a string, but then virBuffer doesn't add
indentation in the middle of a string either.
---
cfg.mk | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
ACK (but I'm biased, as I helped write it)
+sc_forbid_manual_xml_indent:
+ @prohibit='virBuffer.*" +<' \
+ halt='use virBufferAdjustIndent instead of spaces when indenting xml' \
Maybe line up the \ to a common column?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)