Re: [libvirt] [PATCH 3/4] lxc: validate container process during load config

On Thu, May 29, 2008 at 03:20:15PM -0700, Dave Leskovec wrote: > + if (ESRCH == errno) { > + rc = 0; > + DEBUG("pid %d no longer exists", def->id); > + goto done; > + } > + > + lxcError(NULL, NULL, VIR_ERR_INTERNAL_ERROR, > + _("error checking container process: %d %s"), > + def->id, strerror(errno)); > + goto done; > + } The problem though is that by doing just a passive test for the PID it feels like there is a possible race if the process counter rolled over and another process with the same PID got create in the meantime. i have the feeling that a test based on the state of the file descriptors used to communicate with the container would be more reliable. Basically if the container disapear, then the pipe should get in a half-closed state, detecting the change at that level sounds like it would be more reliable, don't you think so ?