Re: [libvirt] [PATCH 00/22] New CPU related APIs
Code-wise, these patches look good. I'd like to take the time next week
to hook up my comparison patches and test them out properly (unless Chris
gets to it first, then I'll just apply his patches and run some tests)
On 05/16/2018 04:39 AM, Jiri Denemark wrote:
The current virConnectCompareCPU and virConnectBaselineCPU APIs are
not
very useful because they ignore what a hypervisor can do on the current
host. This series adds two new APIs which are designed to work with
capabilities of a specific hypervisor to provide usable results.
The third CPU related API virConnectGetCPUModelNames is pretty useless
too, but no new API with similar functionality is needed because domain
capabilities XML already contains the relevant data.
--
Respectfully,
- Collin Walling