Re: [PATCH 6/7] vboxDomainScreenshot: Don't pass uninitialized 'screenData' to VIR_FREE

If one of the early checks to get screen resolution fails 'screenData' would be passed to VIR_FREE uninitialized. Unfortunately the compiler isn't able to detect this when VIR_FREE is implemented using g_clear_pointer. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; --- src/vbox/vbox_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index a834a971f0..85935ba731 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -7418,7 +7418,7 @@ vboxDomainScreenshot(virDomainPtr dom, if (display) { PRUint32 width, height, bitsPerPixel; PRUint32 screenDataSize; - PRUint8 *screenData; + PRUint8 *screenData = NULL; PRInt32 xOrigin, yOrigin; rc = gVBoxAPI.UIDisplay.GetScreenResolution(display, screen,