Re: [libvirt] [PATCH] Prevent crash from dlclose() of libvirt.so

On 09/01/2011 10:57 AM, Daniel P. Berrange wrote: > +++ b/src/Makefile.am > @@ -1228,7 +1228,7 @@ libvirt_qemu.def: $(srcdir)/libvirt_qemu.syms > libvirt_la_SOURCES = > libvirt_la_LDFLAGS = $(VERSION_SCRIPT_FLAGS)$(LIBVIRT_SYMBOL_FILE) \ > -version-info $(LIBVIRT_VERSION_INFO) \ > - $(AM_LDFLAGS) \ > + $(AM_LDFLAGS) $(LIBVIRT_NODELETE) \ I would have listed this before $(AM_LDFLAGS), closer to the $(LIBVIRT_VERSION_INFO) linker flags.

> + > + /* If we got to hear the thread succesfully exited without > + * causing a SEGV ! s/hear/here/; s/succesfully/successfully/ ACK with nits fixed.