Re: [Libvir] [QEMU 3/3] the qemu driver & daemon
On Mon, Aug 28, 2006 at 04:55:09AM -0400, Daniel Veillard wrote:
I scanned quickly the protocol part but I need to get my head around
it :-)
That's a lot of code ! One think I would like is to try to get all commenting
at the same level, i.e. having every function carrying a comment header,
That's something I will help with, maybe as a side effect of reviewing the
code. Tell me how we could do that ? Maybe I could start with the simplest
code from qemud.
I'm attaching an updated patch which has many many more comments in it, and
also has much better error reporting - nearly all errors are propagated
back to libvirt with formal codes & messages.
Other changes previously suggested (re-factoring shared code, etc) are yet
to be done.
Dan
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Attachments:
- libvirt-backend-qemu-2.patch (text/plain — 107.7 KB)