Re: [libvirt] [PATCH 2/5] qemuDomainCreateXML: Make domain definition transient

On 09/22/2015 09:28 AM, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=871452 > > So, you want to create a domain from XML. The domain already > exists in libvirt's database of domains. It's okay, because name > and UUID matches. However, on domain startup, internal > representation of the domain is overwritten with your XML even > though we claim that the XML you've provided is a transient one. > Le sigh. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > src/qemu/qemu_driver.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 30d2d98..2a4b026 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -1745,6 +1745,7 @@ static virDomainPtr > qemuDomainCreateXML(virConnectPtr conn, > if (!(vm = virDomainObjListAdd(driver->domains, def, > driver->xmlopt, > + VIR_DOMAIN_OBJ_LIST_ADD_LIVE | > VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE, > NULL))) > goto cleanup; It looks like the libxl driver should be fixed similarly, right?