Re: [libvirt] [PATCH] rpm-build: use pkg-config to detect wireshark presence
On Mon, Mar 16, 2015 at 01:41:15PM +0100, Pavel Hrdina wrote:
Wireshark supports pkg-config since 1.11.3. Right now we build
wireshark-dissectior tool as default trough rpm build only on
fedora >= 21 and there is newer wireshark that supports pkg-config.
If someone wants to build libvirt with wireshark-dissector against older
wireshark, they should specify the location by hand.
This patch is mainly to fix wrong dependency on wireshark binary as it
doesn't make sense to require that binary file to just get version info
of that package in makefile.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
Be nice to go one step further and switch over to using LIBVIRT_CHECK_PKG
and having the code in m4/virt-wireshark.m4. Just copy virt-fuse.m4 as a
equivalently simple module
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|