[PATCH] virshFindDisk: fix NULL-dereference of xmlCopyNode() result
by Anastasia Belova
xmlCopyNode() may return NULL. Add a check and log an error
in this case.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Fixes: 22766a1a53 ("virshFindDisk: Sanitize use of 'tmp' variable")
Signed-off-by: Anastasia Belova <abelova(a)astralinux.ru>
---
tools/virsh-domain.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 7253596f4a..8752294784 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -12875,6 +12875,10 @@ virshFindDisk(const char *doc,
STREQ_NULLABLE(sourceDir, path) ||
STREQ_NULLABLE(sourceName, path)) {
xmlNodePtr ret = xmlCopyNode(nodes[i], 1);
+ if (!ret) {
+ vshError(NULL, "%s", _("Failed to copy node"));
+ return NULL;
+ }
/* drop backing store since they are not needed here */
virshDiskDropBackingStore(ret);
return ret;
--
2.43.0
1 week, 1 day
[PATCH] network: fix memory leak in networkAddFirewallRules()
by Elizaveta Tereshkina
Add g_clear_pointer() to networkAddFirewallRules()
after using virSetError() to free errInitV4 and errInitV6
to avoid memory leaks.
Fixes: ef760a4133 (Revert "network: support setting firewalld zone for bridge device of open networks")
Signed-off-by: Elizaveta Tereshkina <etereshkina(a)astralinux.ru>
---
src/network/bridge_driver_linux.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c
index 86f6a5915f..93d4d2c8ee 100644
--- a/src/network/bridge_driver_linux.c
+++ b/src/network/bridge_driver_linux.c
@@ -413,6 +413,7 @@ networkAddFirewallRules(virNetworkDef *def,
(virNetworkDefGetIPByIndex(def, AF_INET, 0) ||
virNetworkDefGetRouteByIndex(def, AF_INET, 0))) {
virSetError(errInitV4);
+ g_clear_pointer(&errInitV4, virFreeError);
return -1;
}
@@ -421,6 +422,7 @@ networkAddFirewallRules(virNetworkDef *def,
virNetworkDefGetRouteByIndex(def, AF_INET6, 0) ||
def->ipv6nogw)) {
virSetError(errInitV6);
+ g_clear_pointer(&errInitV6, virFreeError);
return -1;
}
--
2.39.2
1 week, 1 day
[PATCH 0/2] Introduce hardware UUID (hwuuid) element
by Mark Cave-Ayland
Following on from the discussions at [1] and more recently [2], this series
introduces a new hardware UUID (hwuuid) element that allows an external
UUID to be provided to the guest, as opposed to the libvirt domain UUID.
The use case for this feature is to allow a domain to cloned and then
restarted without changing its guest-visible UUID e.g. via dmidecode.
Patch 1 introduces the new hardware UUID (hwuuid) element along with an
implementation for the QEMU driver, whilst patch 2 adds additional tests
to ensure the hwuuid functionality is working as expected.
Note that from reading the source it doesn't appear as if all virtualisation
platforms will support this feature: I've included the relevant changes for
the QEMU driver since that is what we use here at Nutanix.
Signed-off-by: Mark Cave-Ayland <mark.caveayland(a)nutanix.com>
[1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/YX...
[2] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HG...
Mark Cave-Ayland (2):
conf: introduce hardware UUID (hwuuid) element
qemuxmlconftest: add tests for new hardware UUID (hwuuid) element
docs/formatdomain.rst | 7 ++++
src/conf/domain_conf.c | 38 +++++++++++++++--
src/conf/domain_conf.h | 1 +
src/conf/schemas/domaincommon.rng | 5 +++
src/qemu/qemu_command.c | 6 ++-
...hwuuid-smbios-uuid-match.x86_64-latest.err | 1 +
.../hwuuid-smbios-uuid-match.xml | 36 ++++++++++++++++
.../qemuxmlconfdata/hwuuid.x86_64-latest.args | 35 ++++++++++++++++
.../qemuxmlconfdata/hwuuid.x86_64-latest.xml | 41 +++++++++++++++++++
tests/qemuxmlconfdata/hwuuid.xml | 30 ++++++++++++++
tests/qemuxmlconftest.c | 3 ++
11 files changed, 199 insertions(+), 4 deletions(-)
create mode 100644 tests/qemuxmlconfdata/hwuuid-smbios-uuid-match.x86_64-latest.err
create mode 100644 tests/qemuxmlconfdata/hwuuid-smbios-uuid-match.xml
create mode 100644 tests/qemuxmlconfdata/hwuuid.x86_64-latest.args
create mode 100644 tests/qemuxmlconfdata/hwuuid.x86_64-latest.xml
create mode 100644 tests/qemuxmlconfdata/hwuuid.xml
--
2.43.0
1 week, 1 day
[RFC PATCH 0/6] Fix building of sparc/sparc32plus test cases
by Alex Bennée
We didn't have any reliable way to build sparc test cases. I have
found someone who ships a compiler but the binaries still don't run
due to the need for CASA.
I'm posting mainly for those who actually care who might want to fix
up the remaining cases.
Alex.
Alex Bennée (6):
tests/tcg: special case sparc test cases
tests/tcg: special case sparc32plus test cases
configure: update sparc and sparc32plus target compiler detection
tests/docker: add sparc-leon-cross container image
configure: enable the container fallbacks for sparc/sparc32plus
docs/about: deprecate add sparc/sparc32plus-*-user
docs/about/deprecated.rst | 8 ++++
configure | 11 ++++-
.../dockerfiles/sparc-leon-cross.docker | 40 +++++++++++++++++
tests/tcg/Makefile.target | 9 ++--
tests/tcg/sparc/Makefile.target | 45 +++++++++++++++++++
tests/tcg/sparc32plus | 1 +
6 files changed, 108 insertions(+), 6 deletions(-)
create mode 100644 tests/docker/dockerfiles/sparc-leon-cross.docker
create mode 100644 tests/tcg/sparc/Makefile.target
create mode 120000 tests/tcg/sparc32plus
--
2.47.2
1 week, 1 day
[PATCH] Allow specifying zero discard granularity for block devices
by Martin Kletzander
From: Martin Kletzander <mkletzan(a)redhat.com>
That allows for disabling discard in a way that some guest
OSes (e.g. Windows) understand and do not try to trim the disk.
Resolves: https://issues.redhat.com/browse/RHEL-72006
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
Out of all the approaches for allowing previously default value 100% of them are
ugly. This one is maybe slightly more error-prone.
src/conf/domain_conf.c | 12 ++++++++----
src/conf/domain_conf.h | 1 +
src/conf/domain_validate.c | 2 +-
src/qemu/qemu_command.c | 7 ++++++-
tests/qemuxmlconftest.c | 1 +
5 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index bfc62b62705f..ba0d4a7b128c 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -8554,6 +8554,8 @@ virDomainDiskDefParseXML(virDomainXMLOption *xmlopt,
}
if ((blockioNode = virXPathNode("./blockio", ctxt))) {
+ int tmp = 0;
+
if (virXMLPropUInt(blockioNode, "logical_block_size", 10, VIR_XML_PROP_NONE,
&def->blockio.logical_block_size) < 0)
return NULL;
@@ -8562,9 +8564,11 @@ virDomainDiskDefParseXML(virDomainXMLOption *xmlopt,
&def->blockio.physical_block_size) < 0)
return NULL;
- if (virXMLPropUInt(blockioNode, "discard_granularity", 10, VIR_XML_PROP_NONE,
- &def->blockio.discard_granularity) < 0)
+ if ((tmp = virXMLPropUInt(blockioNode, "discard_granularity", 10, VIR_XML_PROP_NONE,
+ &def->blockio.discard_granularity)) < 0)
return NULL;
+ if (tmp > 0)
+ def->blockio.discard_granularity_specified = true;
}
if ((driverNode = virXPathNode("./driver", ctxt))) {
@@ -23102,7 +23106,7 @@ virDomainDiskBlockIoDefFormat(virBuffer *buf,
{
if (def->blockio.logical_block_size > 0 ||
def->blockio.physical_block_size > 0 ||
- def->blockio.discard_granularity > 0) {
+ def->blockio.discard_granularity_specified) {
virBufferAddLit(buf, "<blockio");
if (def->blockio.logical_block_size > 0) {
virBufferAsprintf(buf,
@@ -23114,7 +23118,7 @@ virDomainDiskBlockIoDefFormat(virBuffer *buf,
" physical_block_size='%u'",
def->blockio.physical_block_size);
}
- if (def->blockio.discard_granularity > 0) {
+ if (def->blockio.discard_granularity_specified) {
virBufferAsprintf(buf,
" discard_granularity='%u'",
def->blockio.discard_granularity);
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 6997cf7c09be..6008ec66d3fe 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -560,6 +560,7 @@ struct _virDomainDiskDef {
unsigned int logical_block_size;
unsigned int physical_block_size;
unsigned int discard_granularity;
+ bool discard_granularity_specified;
} blockio;
virDomainBlockIoTuneInfo blkdeviotune;
diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
index b28af7fa5618..8f7259a0e1ed 100644
--- a/src/conf/domain_validate.c
+++ b/src/conf/domain_validate.c
@@ -462,7 +462,7 @@ virDomainDiskVhostUserValidate(const virDomainDiskDef *disk)
if (disk->blockio.logical_block_size > 0 ||
disk->blockio.physical_block_size > 0 ||
- disk->blockio.discard_granularity > 0) {
+ disk->blockio.discard_granularity_specified) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("blockio is not supported with vhostuser disk"));
return -1;
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 7658cc4d395a..fc6ce4dd9143 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1899,7 +1899,6 @@ qemuBuildDiskDeviceProps(const virDomainDef *def,
"S:loadparm", bootLoadparm,
"p:logical_block_size", logical_block_size,
"p:physical_block_size", physical_block_size,
- "p:discard_granularity", discard_granularity,
"A:wwn", &wwn,
"p:rotation_rate", disk->rotation_rate,
"S:vendor", disk->vendor,
@@ -1917,6 +1916,12 @@ qemuBuildDiskDeviceProps(const virDomainDef *def,
NULL) < 0)
return NULL;
+ if (disk->blockio.discard_granularity_specified &&
+ virJSONValueObjectAdd(&props,
+ "u:discard_granularity", discard_granularity,
+ NULL) < 0)
+ return NULL;
+
return g_steal_pointer(&props);
}
diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c
index 9fba98429019..ae8efd58f8ac 100644
--- a/tests/qemuxmlconftest.c
+++ b/tests/qemuxmlconftest.c
@@ -1694,6 +1694,7 @@ mymain(void)
DO_TEST_CAPS_LATEST("disk-ide-wwn");
DO_TEST_CAPS_LATEST("disk-geometry");
DO_TEST_CAPS_LATEST("disk-blockio");
+ DO_TEST_CAPS_LATEST("disk-blockio-no-discard");
driver.config->storageUseNbdkit = 1;
DO_TEST_CAPS_LATEST_NBDKIT("disk-cdrom-network-nbdkit", QEMU_NBDKIT_CAPS_PLUGIN_CURL);
--
2.50.1
1 week, 1 day
[libvirt PATCH 0/2] tests: nssdata: add empty status file
by Ján Tomko
A blurb is a short promotional piece accompanying
a piece of creative work. It may be written
by the author or publisher or quote praise from others.
Blurbs were originally printed on the back or rear dust
jacket of a book. With the development of the mass-market
paperback, they were placed on both covers by most publishers.
Now they are also found on web portals and news websites.
A blurb may introduce a newspaper or a book.
-- https://en.wikipedia.org/wiki/Blurb
Ján Tomko (2):
DO NOT PUSH Revert "nss: Skip empty files and avoid use of
uninitialized value"
tests: nssdata: add empty status file
tests/nssdata/virbr2.status | 0
tools/nss/libvirt_nss_leases.c | 9 ++-------
tools/nss/libvirt_nss_macs.c | 9 ++-------
3 files changed, 4 insertions(+), 14 deletions(-)
create mode 100644 tests/nssdata/virbr2.status
--
2.50.1
1 week, 1 day
[PATCH 0/2] qemu: Random fixes
by Michal Privoznik
I've been migrating some machines recently and on dst didn't have VSOCK
enabled in the kernel which led to 1/2. Then I've also noticed weird
looking error messaged around TPM which led to 2/2.
Michal Prívozník (2):
qemu: Report system error on failed open()
qemu_tpm: Don't report uninitialized variable in error message
src/qemu/qemu_domain.c | 8 ++++----
src/qemu/qemu_process.c | 4 ++--
src/qemu/qemu_tpm.c | 6 +++---
3 files changed, 9 insertions(+), 9 deletions(-)
--
2.49.1
1 week, 1 day
[PATCH 0/1] qemu qapi: SIGSEGV small fix
by Nikolai Barybin
Hello everyone!
When implementing some custom qemu capability I cought this bug when
some string with '*' pattern is not contained in schema, and virQEMUQAPISchemaTraverseObject
passes NULL ptr to virJSONValueObjectHasKey.
Nikolai Barybin (1):
qemu: qapi: fix potential SIGSEGV in virQEMUQAPISchemaTraverseObject()
src/qemu/qemu_qapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.43.5
1 week, 2 days
[libvirt PATCH] conf: schemas: add sysinfocommon.rng into list of installed schemas
by Pavel Hrdina
From: Pavel Hrdina <phrdina(a)redhat.com>
Fixes: 918594b419ea3944220fcbab6cf4f1ce7d81e609
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/conf/schemas/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/schemas/meson.build b/src/conf/schemas/meson.build
index b293373085..7ec625b8db 100644
--- a/src/conf/schemas/meson.build
+++ b/src/conf/schemas/meson.build
@@ -25,6 +25,7 @@ schema_files = [
'storagepoolcaps.rng',
'storagepool.rng',
'storagevol.rng',
+ 'sysinfocommon.rng',
]
install_data(schema_files, install_dir: pkgdatadir / 'schemas')
--
2.50.1
1 week, 3 days
[PATCHv2] passt: Define backend hostname and fqdn
by Enrique Llorente
This commit introduces a feature enhancement for configuring hostnames in
virtual machines (VMs) using DHCP. It adds new options to the "passt" tool
to set the hostname and fully qualified domain name (FQDN) for VMs. These
map to DHCP option 12 for the hostname and options 81 (IPv4) and 39 (IPv6)
for the FQDN.
The update enables passt to dynamically assign hostnames to DHCP-aware
VMs. To achieve this, the commit adds two fields to the passt domain XML
backend. These fields allow passt to configure the hostname and FQDN for
the virtual machine, ensuring smooth integration with the DHCP protocol.
This improvement is particularly valuable in environments where VMs need
dynamic hostname configuration, enhancing flexibility and automation in
virtualized network setups.
libvirt: Integrate passt --hostname --fqdn options
Resolves: https://issues.redhat.com/browse/RHEL-79806
Signed-off-by: Enrique Llorente <ellorent(a)redhat.com>
---
Compared to v1 this fix the mapping between backend fqdn and hostname
docs/formatdomain.rst | 8 +++++---
src/conf/domain_conf.c | 10 +++++++++-
src/conf/domain_conf.h | 2 ++
src/conf/schemas/domaincommon.rng | 6 ++++++
src/qemu/qemu_passt.c | 6 ++++++
tests/qemuxmlconfdata/net-user-passt.x86_64-7.2.0.xml | 2 +-
tests/qemuxmlconfdata/net-user-passt.x86_64-latest.xml | 2 +-
tests/qemuxmlconfdata/net-user-passt.xml | 2 +-
.../net-vhostuser-passt.x86_64-latest.xml | 2 +-
tests/qemuxmlconfdata/net-vhostuser-passt.xml | 2 +-
10 files changed, 33 insertions(+), 9 deletions(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index 8753ee9c23..9c80aa9270 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -5372,10 +5372,12 @@ came from the host's IP.
There are a few other options that are configurable only for the passt
backend. For example, the ``<backend>`` attribute ``logFile`` can be
used to tell the passt process for this interface where to write its
-message log, and the ``<source>`` attribute ``dev`` can tell it a
+message log, the ``<source>`` attribute ``dev`` can tell it a
particular host interface to use when deriving the routes given to the
-guest for forwarding traffic upstream. Due to the design decisions of
-passt, when using SELinux on the host, it is recommended that the log
+guest for forwarding traffic upstream and the ``hostname`` and ``fqdn``
+will conigure the DHCP option 12 hostname and DHCP option 81 and DHCPv6
+option 39 fqdn attribute. Due to the design decisions of passt, when using
+SELinux on the host, it is recommended that the log
file reside in the runtime directory of the user under which the passt
process will run, most probably ``/run/user/$UID`` (where ``$UID`` is
the UID of that user), e.g. ``/run/user/1000``. Be aware that libvirt
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index b3b0bd7329..15143f8fa2 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -2909,6 +2909,8 @@ virDomainNetDefFree(virDomainNetDef *def)
g_free(def->backend.tap);
g_free(def->backend.vhost);
g_free(def->backend.logFile);
+ g_free(def->backend.hostname);
+ g_free(def->backend.fqdn);
virDomainNetTeamingInfoFree(def->teaming);
g_free(def->virtPortProfile);
g_free(def->script);
@@ -9757,6 +9759,8 @@ virDomainNetBackendParseXML(xmlNodePtr node,
}
def->backend.logFile = virXMLPropString(node, "logFile");
+ def->backend.hostname = virXMLPropString(node, "hostname");
+ def->backend.fqdn = virXMLPropString(node, "fqdn");
if (tap)
def->backend.tap = virFileSanitizePath(tap);
@@ -20757,7 +20761,9 @@ virDomainNetBackendIsEqual(virDomainNetBackend *src,
if (src->type != dst->type ||
STRNEQ_NULLABLE(src->tap, dst->tap) ||
STRNEQ_NULLABLE(src->vhost, dst->vhost) ||
- STRNEQ_NULLABLE(src->logFile, dst->logFile)) {
+ STRNEQ_NULLABLE(src->logFile, dst->logFile) ||
+ STRNEQ_NULLABLE(src->hostname, dst->hostname) ||
+ STRNEQ_NULLABLE(src->fqdn, dst->fqdn)) {
return false;
}
return true;
@@ -24838,6 +24844,8 @@ virDomainNetBackendFormat(virBuffer *buf,
virBufferEscapeString(&attrBuf, " tap='%s'", backend->tap);
virBufferEscapeString(&attrBuf, " vhost='%s'", backend->vhost);
virBufferEscapeString(&attrBuf, " logFile='%s'", backend->logFile);
+ virBufferEscapeString(&attrBuf, " hostname='%s'", backend->hostname);
+ virBufferEscapeString(&attrBuf, " fqdn='%s'", backend->fqdn);
virXMLFormatElement(buf, "backend", &attrBuf, NULL);
}
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 58b97a2b54..79fd2f1f63 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -1067,6 +1067,8 @@ struct _virDomainNetBackend {
char *vhost;
/* The following are currently only valid/used when backend type='passt' */
char *logFile; /* path to logfile used by passt process */
+ char *hostname; /* hostname of the passt process */
+ char *fqdn; /* fully qualified domain name of the passt process */
};
struct _virDomainNetPortForwardRange {
diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng
index 5597d5a66b..f64199ca18 100644
--- a/src/conf/schemas/domaincommon.rng
+++ b/src/conf/schemas/domaincommon.rng
@@ -3913,6 +3913,12 @@
<ref name="absFilePath"/>
</attribute>
</optional>
+ <optional>
+ <attribute name="hostname"/>
+ </optional>
+ <optional>
+ <attribute name="fqdn"/>
+ </optional>
</element>
</optional>
<optional>
diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c
index fcc34de384..81e5c51f6c 100644
--- a/src/qemu/qemu_passt.c
+++ b/src/qemu/qemu_passt.c
@@ -229,6 +229,12 @@ qemuPasstStart(virDomainObj *vm,
if (net->backend.logFile)
virCommandAddArgList(cmd, "--log-file", net->backend.logFile, NULL);
+ if (net->backend.hostname)
+ virCommandAddArgList(cmd, "--hostname", net->backend.hostname, NULL);
+
+ if (net->backend.fqdn)
+ virCommandAddArgList(cmd, "--fqdn", net->backend.fqdn, NULL);
+
/* Add IP address info */
for (i = 0; i < net->guestIP.nips; i++) {
const virNetDevIPAddr *ip = net->guestIP.ips[i];
diff --git a/tests/qemuxmlconfdata/net-user-passt.x86_64-7.2.0.xml b/tests/qemuxmlconfdata/net-user-passt.x86_64-7.2.0.xml
index cfe07cc627..77da297936 100644
--- a/tests/qemuxmlconfdata/net-user-passt.x86_64-7.2.0.xml
+++ b/tests/qemuxmlconfdata/net-user-passt.x86_64-7.2.0.xml
@@ -50,7 +50,7 @@
<range start='443' to='344'/>
</portForward>
<model type='rtl8139'/>
- <backend type='passt' logFile='/var/log/loglaw.blog'/>
+ <backend type='passt' logFile='/var/log/loglaw.blog' hostname='hostname1' fqdn='hostname1.test.local'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
</interface>
<input type='mouse' bus='ps2'/>
diff --git a/tests/qemuxmlconfdata/net-user-passt.x86_64-latest.xml b/tests/qemuxmlconfdata/net-user-passt.x86_64-latest.xml
index d7e0ef5f90..917a9edaa0 100644
--- a/tests/qemuxmlconfdata/net-user-passt.x86_64-latest.xml
+++ b/tests/qemuxmlconfdata/net-user-passt.x86_64-latest.xml
@@ -50,7 +50,7 @@
<range start='443' to='344'/>
</portForward>
<model type='rtl8139'/>
- <backend type='passt' logFile='/var/log/loglaw.blog'/>
+ <backend type='passt' logFile='/var/log/loglaw.blog' hostname='hostname1' fqdn='hostname1.test.local'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
</interface>
<input type='mouse' bus='ps2'/>
diff --git a/tests/qemuxmlconfdata/net-user-passt.xml b/tests/qemuxmlconfdata/net-user-passt.xml
index 20c9f50542..80d15de2ed 100644
--- a/tests/qemuxmlconfdata/net-user-passt.xml
+++ b/tests/qemuxmlconfdata/net-user-passt.xml
@@ -47,7 +47,7 @@
<range start='443' to='344'/>
</portForward>
<model type='rtl8139'/>
- <backend type='passt' logFile='/var/log/loglaw.blog'/>
+ <backend type='passt' logFile='/var/log/loglaw.blog' hostname='hostname1' fqdn='hostname1.test.local'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
</interface>
<input type='mouse' bus='ps2'/>
diff --git a/tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.xml b/tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.xml
index 529aff11f8..5802754c4b 100644
--- a/tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.xml
+++ b/tests/qemuxmlconfdata/net-vhostuser-passt.x86_64-latest.xml
@@ -53,7 +53,7 @@
<range start='443' to='344'/>
</portForward>
<model type='virtio'/>
- <backend type='passt' logFile='/var/log/loglaw.blog'/>
+ <backend type='passt' logFile='/var/log/loglaw.blog' hostname='hostname1' fqdn='hostname1.test.local'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
</interface>
<interface type='vhostuser'>
diff --git a/tests/qemuxmlconfdata/net-vhostuser-passt.xml b/tests/qemuxmlconfdata/net-vhostuser-passt.xml
index 71b845329b..0a37511a0f 100644
--- a/tests/qemuxmlconfdata/net-vhostuser-passt.xml
+++ b/tests/qemuxmlconfdata/net-vhostuser-passt.xml
@@ -50,7 +50,7 @@
<range start='443' to='344'/>
</portForward>
<model type='virtio'/>
- <backend type='passt' logFile='/var/log/loglaw.blog'/>
+ <backend type='passt' logFile='/var/log/loglaw.blog' hostname='hostname1' fqdn='hostname1.test.local'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
</interface>
<interface type='vhostuser'>
--
2.49.0
1 week, 4 days
