[PATCH 0/3] qemu: Replace usb-storage with usb-bot
by Akihiko Odaki
usb-storage is a compound device that automatically creates a USB mass
storage device and a SCSI device as its backend. Unfortunately it lacks
some configuration options that are usually present with a SCSI device,
and cannot represent CD-ROM in particular.
Replace usb-storage with usb-bot, which can be combined with a manually
created SCSI device. libvirt will configure the SCSI device in a way
identical with how QEMU does for usb-storage except that now it respects
a configuration option to represent CD-ROM.
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/368
Signed-off-by: Akihiko Odaki <akihiko.odaki(a)daynix.com>
---
Akihiko Odaki (3):
qemu_capabilities: Introduce QEMU_CAPS_DEVICE_USB_BOT
qemu: Replace usb-storage with usb-bot
qemu_capabilities: Retire QEMU_CAPS_DEVICE_USB_STORAGE
src/qemu/qemu_alias.c | 3 +-
src/qemu/qemu_capabilities.c | 19 +-
src/qemu/qemu_capabilities.h | 3 +-
src/qemu/qemu_command.c | 55 +++++-
src/qemu/qemu_command.h | 5 +
src/qemu/qemu_hotplug.c | 34 +++-
src/qemu/qemu_validate.c | 4 +-
.../qemucapabilitiesdata/caps_10.0.0_s390x.replies | 186 ++++---------------
tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml | 2 +-
.../caps_10.0.0_x86_64.replies | 206 +++++----------------
tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 2 +-
.../caps_5.2.0_aarch64.replies | 174 ++++-------------
tests/qemucapabilitiesdata/caps_5.2.0_aarch64.xml | 2 +-
.../qemucapabilitiesdata/caps_5.2.0_ppc64.replies | 178 +++++-------------
tests/qemucapabilitiesdata/caps_5.2.0_ppc64.xml | 2 +-
.../caps_5.2.0_riscv64.replies | 170 ++++-------------
tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml | 2 +-
.../qemucapabilitiesdata/caps_5.2.0_x86_64.replies | 190 +++++--------------
tests/qemucapabilitiesdata/caps_5.2.0_x86_64.xml | 2 +-
.../caps_6.0.0_aarch64.replies | 172 ++++-------------
tests/qemucapabilitiesdata/caps_6.0.0_aarch64.xml | 2 +-
.../qemucapabilitiesdata/caps_6.0.0_x86_64.replies | 188 +++++--------------
tests/qemucapabilitiesdata/caps_6.0.0_x86_64.xml | 2 +-
.../qemucapabilitiesdata/caps_6.1.0_x86_64.replies | 194 +++++--------------
tests/qemucapabilitiesdata/caps_6.1.0_x86_64.xml | 2 +-
.../caps_6.2.0_aarch64.replies | 178 ++++--------------
tests/qemucapabilitiesdata/caps_6.2.0_aarch64.xml | 2 +-
.../qemucapabilitiesdata/caps_6.2.0_ppc64.replies | 182 +++++-------------
tests/qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 2 +-
.../qemucapabilitiesdata/caps_6.2.0_x86_64.replies | 194 +++++--------------
tests/qemucapabilitiesdata/caps_6.2.0_x86_64.xml | 2 +-
.../caps_7.0.0_aarch64+hvf.replies | 182 +++++-------------
.../caps_7.0.0_aarch64+hvf.xml | 2 +-
.../caps_7.0.0_aarch64.replies | 182 +++++-------------
tests/qemucapabilitiesdata/caps_7.0.0_aarch64.xml | 2 +-
.../qemucapabilitiesdata/caps_7.0.0_ppc64.replies | 182 +++++-------------
tests/qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 2 +-
.../qemucapabilitiesdata/caps_7.0.0_x86_64.replies | 194 +++++--------------
tests/qemucapabilitiesdata/caps_7.0.0_x86_64.xml | 2 +-
.../qemucapabilitiesdata/caps_7.1.0_ppc64.replies | 182 +++++-------------
tests/qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 2 +-
.../qemucapabilitiesdata/caps_7.1.0_x86_64.replies | 194 +++++--------------
tests/qemucapabilitiesdata/caps_7.1.0_x86_64.xml | 2 +-
tests/qemucapabilitiesdata/caps_7.2.0_ppc.replies | 186 ++++---------------
tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 2 +-
.../caps_7.2.0_x86_64+hvf.replies | 206 +++++----------------
.../qemucapabilitiesdata/caps_7.2.0_x86_64+hvf.xml | 2 +-
.../qemucapabilitiesdata/caps_7.2.0_x86_64.replies | 206 +++++----------------
tests/qemucapabilitiesdata/caps_7.2.0_x86_64.xml | 2 +-
.../caps_8.0.0_riscv64.replies | 182 ++++--------------
tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml | 2 +-
.../qemucapabilitiesdata/caps_8.0.0_x86_64.replies | 206 +++++----------------
tests/qemucapabilitiesdata/caps_8.0.0_x86_64.xml | 2 +-
.../qemucapabilitiesdata/caps_8.1.0_s390x.replies | 182 ++++--------------
tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml | 2 +-
.../qemucapabilitiesdata/caps_8.1.0_x86_64.replies | 206 +++++----------------
tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml | 2 +-
.../caps_8.2.0_aarch64.replies | 190 ++++---------------
tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 2 +-
.../qemucapabilitiesdata/caps_8.2.0_armv7l.replies | 190 ++++---------------
tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml | 2 +-
.../caps_8.2.0_loongarch64.replies | 186 ++++---------------
.../caps_8.2.0_loongarch64.xml | 2 +-
.../qemucapabilitiesdata/caps_8.2.0_s390x.replies | 182 ++++--------------
tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml | 2 +-
.../qemucapabilitiesdata/caps_8.2.0_x86_64.replies | 206 +++++----------------
tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml | 2 +-
.../qemucapabilitiesdata/caps_9.0.0_x86_64.replies | 206 +++++----------------
tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml | 2 +-
.../caps_9.1.0_riscv64.replies | 182 ++++--------------
tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml | 2 +-
.../qemucapabilitiesdata/caps_9.1.0_s390x.replies | 182 ++++--------------
tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml | 2 +-
.../qemucapabilitiesdata/caps_9.1.0_x86_64.replies | 206 +++++----------------
tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml | 2 +-
.../qemucapabilitiesdata/caps_9.2.0_s390x.replies | 182 ++++--------------
tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml | 2 +-
.../qemucapabilitiesdata/caps_9.2.0_x86_64.replies | 206 +++++----------------
tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml | 2 +-
tests/qemuhotplugtest.c | 8 +-
.../qemuxmlconfdata/disk-cache.x86_64-latest.args | 3 +-
.../disk-cdrom-bus-other.x86_64-latest.args | 3 +-
.../disk-device-removable.x86_64-latest.args | 3 +-
.../disk-usb-device.x86_64-latest.args | 3 +-
84 files changed, 1689 insertions(+), 5346 deletions(-)
---
base-commit: e5299ddf86121d3c792ca271ffcb54900eb19dc3
change-id: 20250304-bot-5d84aa3a5cfe
Best regards,
--
Akihiko Odaki <akihiko.odaki(a)daynix.com>
1 week, 5 days
[PATCH 0/2] esx: Allow specifying different CA bundle for remote connections
by Martin Kletzander
**El Blurbo aquí**
Martin Kletzander (2):
esx: Allow specifying different CA bundle for remote connections
NEWS: Mention cainfo_path parameter in esx driver
NEWS.rst | 5 +++++
docs/drvesx.rst | 16 ++++++++++++++--
src/esx/esx_util.c | 4 ++++
src/esx/esx_util.h | 1 +
src/esx/esx_vi.c | 3 +++
5 files changed, 27 insertions(+), 2 deletions(-)
--
2.49.0
1 week, 5 days
[PATCH] storage: Implement a simple 'checkPool' method for 'rbd' type pools
by Krisstoffe
From: Krisstoffe <krisstoffe(a)free.fr>
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/448
Signed-off-by: Krisstoffe <krisstoffe(a)free.fr>
---
src/storage/storage_backend_rbd.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c
index 038a1a9e34..29d544d349 100644
--- a/src/storage/storage_backend_rbd.c
+++ b/src/storage/storage_backend_rbd.c
@@ -1442,9 +1442,21 @@ virStorageBackendRBDVolWipe(virStoragePoolObj *pool,
}
+static int
+virStorageBackendRBDCheckPool(virStoragePoolObj *pool,
+ bool *active)
+{
+ /* Return previous state remembered by the status XML. If the pool is not
+ * available we will fail to refresh it and end up in the same situation. */
+ *active = virStoragePoolObjIsActive(pool);
+ return 0;
+}
+
+
virStorageBackend virStorageBackendRBD = {
.type = VIR_STORAGE_POOL_RBD,
+ .checkPool = virStorageBackendRBDCheckPool,
.refreshPool = virStorageBackendRBDRefreshPool,
.createVol = virStorageBackendRBDCreateVol,
.buildVol = virStorageBackendRBDBuildVol,
--
2.47.1
1 week, 5 days
[RFC PATCH v4 0/4] RFC: Add Arm CCA support for getting capability information and running Realm VM
by Kazuhiro Abe
Hi, all.
This patch adds Arm CCA support to QEMU driver for aarch64 system.
CCA is an abbreviation for Arm Confidential Compute Architecture
feature, it enhances the virtualization capabilities of
the platform by separating the management of resources from access
to those resources.
We are not yet at the stage where we can merge this patch as host
Linux/QEMU support is not yet merged, but I would like to receive
reviews and comments on the overall direction.
Changes in v4:
- Changed the target QEMU binary (Linaro's CCA/v8 version with added
QMP functionality)
- Added the 'armrme' variant to tests/qemucapabilitiesdata/README.rst.
- Renamed data files to include '+armrme':
- tests/domaincapsdata/qemu_9.2.0-virt.aarch64+armrme.xml
- tests/domaincapsdata/qemu_9.2.0.aarch64+armrme.xml
- tests/qemucapabilitiesdata/caps_9.2.0_aarch64+armrme.replies
- tests/qemucapabilitiesdata/caps_9.2.0_aarch64+armrme.xml
- tests/qemuxmlconfdata/launch-security-cca.aarch64-latest+armrme.args
- tests/qemuxmlconfdata/launch-security-cca.aarch64-latest+armrme.xml
- Reorganized the commits to ensure the tests pass even with partial
application of the patch.
[summary]
At this stage, all you can do is getting the CCA capability with
the virsh domcapabilities command and start the CCA VM with
the virsh create command.
capability info uses QEMU QMP to query QEMU options. The option
that exists now is for selecting a hash algorithm.
QEMU QMP sections currently only contains a single member, but
is wrapped in sections for expansion.
[Capability example]
Execution results of 'virsh domcapability" on QEMU
<domaincapabilities>
...
<features>
...
</sgx>
<cca supported='yes'>
<enum name='measurement-algo'>
<value>sha256</value>
<value>sha512</value>
</enum>
</cca>
<hyperv supported='yes'>
...
</features>
</domaincapabilities>
[XML example]
<domain>
...
<launchsecurity type='cca'>
<measurement-algo>sha256</measurement-algo>
</launchsecurity>
...
</domain>
[limitations/tests]
To obtain capability info, it is necessary to support the QEMU QMP
command, which QEMU does not yet support. We added a QMP
command to retrieve CCA info for test (See "[software version]"
below). I need to check qemu_firmware.c to see if my CPU firmware
supports CCA. Since it's not implemented yet, I'll wait until a Linux
distributor provides me with a JSON file for CCA.
We have confirmed that the added tests (qemucapabilitiestest,
domaincapstest and qemuxmlconftest) and the CCA VM startup test
(starting the CCA VM from the virsh create command) passed.
The "personalization-value" and "measurement-log" parameters that
exist in the current Linaro QEMU cca/latest branch will not be
specified as CCA VM startup parameters with the virsh create
command.
[software version]
I followed the steps in Linaro's blog below.
https://linaro.atlassian.net/wiki/spaces/QEMU/pages/29051027459/Building+...
The QEMU used was enhanced with CCA QMP command and found at:
https://github.com/Kazuhiro-Abe-fj/linaro_qemu/tree/cca-latest-qmp
which is based on Linaro QEMU (cca/latest)
https://git.codelinaro.org/linaro/dcap/qemu/-/tree/cca/latest?ref_type=heads
RFC v1:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/V4...
RFC v2:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/5...
RFC v3:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/LL...
Signed-off-by: Kazuhiro Abe fj1078ii(a)aa.jp.fujitsu.com
Akio Kakuno (3):
src: Add ARM CCA support in qemu driver to launch VM
src: Add ARM CCA support in domain capabilities command
src: Add ARM CCA support in domain schema
Kazuhiro Abe (1):
tests: Adds Arm CCA support
docs/formatdomain.rst | 43 +
docs/formatdomaincaps.rst | 27 +-
src/conf/domain_capabilities.c | 48 +
src/conf/domain_capabilities.h | 12 +
src/conf/domain_conf.c | 25 +
src/conf/domain_conf.h | 9 +
src/conf/domain_validate.c | 1 +
src/conf/schemas/domaincaps.rng | 36 +
src/conf/schemas/domaincommon.rng | 26 +
src/conf/virconftypes.h | 2 +
src/libvirt_private.syms | 1 +
src/qemu/qemu_capabilities.c | 145 +
src/qemu/qemu_capabilities.h | 4 +
src/qemu/qemu_cgroup.c | 2 +
src/qemu/qemu_command.c | 29 +
src/qemu/qemu_driver.c | 2 +
src/qemu/qemu_firmware.c | 1 +
src/qemu/qemu_monitor.c | 10 +
src/qemu/qemu_monitor.h | 3 +
src/qemu/qemu_monitor_json.c | 98 +
src/qemu/qemu_monitor_json.h | 4 +
src/qemu/qemu_namespace.c | 2 +
src/qemu/qemu_process.c | 4 +
src/qemu/qemu_validate.c | 4 +
src/security/security_dac.c | 2 +
.../qemu_9.2.0-virt.aarch64+armrme.xml | 244 +
.../qemu_9.2.0.aarch64+armrme.xml | 244 +
tests/qemucapabilitiesdata/README.rst | 5 +
.../caps_9.2.0_aarch64+armrme.replies | 36754 ++++++++++++++++
.../caps_9.2.0_aarch64+armrme.xml | 540 +
...ch-security-cca.aarch64-latest+armrme.args | 30 +
...nch-security-cca.aarch64-latest+armrme.xml | 24 +
tests/qemuxmlconfdata/launch-security-cca.xml | 16 +
tests/qemuxmlconftest.c | 2 +
34 files changed, 38398 insertions(+), 1 deletion(-)
create mode 100644 tests/domaincapsdata/qemu_9.2.0-virt.aarch64+armrme.xml
create mode 100644 tests/domaincapsdata/qemu_9.2.0.aarch64+armrme.xml
create mode 100644 tests/qemucapabilitiesdata/caps_9.2.0_aarch64+armrme.replies
create mode 100644 tests/qemucapabilitiesdata/caps_9.2.0_aarch64+armrme.xml
create mode 100644 tests/qemuxmlconfdata/launch-security-cca.aarch64-latest+armrme.args
create mode 100644 tests/qemuxmlconfdata/launch-security-cca.aarch64-latest+armrme.xml
create mode 100644 tests/qemuxmlconfdata/launch-security-cca.xml
--
2.43.5
1 week, 5 days
Re: [RFC PATCH v3 4/6] qemucapabilitiestest: Adds Arm CCA support
by Peter Krempa
On Thu, May 29, 2025 at 05:10:48 +0000, Kazuhiro Abe (Fujitsu) wrote:
>
> On 5/20/25 17:54, Peter Krempa wrote:
> > On Tue, May 20, 2025 at 17:28:26 +0900, Kazuhiro Abe wrote:
> > > From: Akio Kakuno <fj3333bs(a)fujitsu.com>
> > >
> > > - This test was added to check qemu capabilities for Arm
> > > CCA support.
> >
> > IF
> >
> > > This test was created using the method described in the
> > > documentation.
> > >
> > > Signed-off-by: Kazuhiro Abe <fj1078ii(a)aa.jp.fujitsu.com>
> > > ---
> > > .../caps_9.1.0_aarch64.replies | 36222
> > ++++++++++++++++
> > > .../caps_9.1.0_aarch64.xml | 530 +
> > > 2 files changed, 36752 insertions(+)
> > > create mode 100644
> > > tests/qemucapabilitiesdata/caps_9.1.0_aarch64.replies
> > > create mode 100644 tests/qemucapabilitiesdata/caps_9.1.0_aarch64.xml
> >
> > Note that I'll be commenting only on the capability testing related matter, not the
> > rest of the series.
> >
> > > diff --git a/tests/qemucapabilitiesdata/caps_9.1.0_aarch64.replies
> > > b/tests/qemucapabilitiesdata/caps_9.1.0_aarch64.replies
> > > new file mode 100644
> > > index 0000000000..906a21f0c6
> > > --- /dev/null
> > > +++ b/tests/qemucapabilitiesdata/caps_9.1.0_aarch64.replies
> > > @@ -0,0 +1,36222 @@
> > > +{
> > > + "execute": "qmp_capabilities",
> > > + "id": "libvirt-1"
> > > +}
> > > +
> > > +{
> > > + "return": {},
> > > + "id": "libvirt-1"
> > > +}
> > > +
> > > +{
> > > + "execute": "query-version",
> > > + "id": "libvirt-2"
> > > +}
> > > +
> > > +{
> > > + "return": {
> > > + "qemu": {
> > > + "micro": 91,
> > > + "minor": 1,
> > > + "major": 9
> >
> > This is from 9.2.0-rc1. So firstly the file is named wrong, because it was supposed
> > to be 'caps_9.2.0_aarch64.replies' instead.
> >
> > Also except for the currently developed release we require that the .replies files
> > are generated from the final release versions and not the RCs or any other
> > non-final code.
> >
> > The libvirt tree already has qemu caps for 9.2.0 and 10.0.0 for aarch64.
> >
> > What makes these special?
> >
> > If there's a reason to have specific capabilities please add a 'variant'
> > per tests/qemucapabilitiesdata/README.rst
>
> Thanks for your comment.
>
> These were generated from a special QEMU version which support ARM CCA based on 9.2.
> So as a temporary measure, I will add a variant to the replies file,
> and the name will be caps_9.2.0_aarch64+armrme.replies.
I'd expect that now that qemu-10.0 is out you'd be targetting at least
qemu-10.1 [1] as ...
>
> Note that, once the patch about Arm CCA support is merged,
> we will change the replies file name.
... it's not yet merged as you are saying.
[1] We do allow capabilities captured from the currently in development
tree but:
- they must be based on a commit from official qemu git
- you will have to update them to the final version once qemu-N+1
releases.
But since it's not merged yet your patch will need to stay RFC. Please
make sure thoug to note it in the capabilities patch that it's not the
final version yet so that there's no confusion.
Your patch looked like it was something which already exists based on
the commit message and I didn't read the cover letter because I wasn't
too interested in the series itself, I'm just making sure that
capabilities dumps are handled properly so that I don't have to deal
with it later.
1 week, 5 days
[PATCH 0/1] [RFC] Live migration support for ch driver
by Stefan Kober
This change serves as a proof of concept that adds live migration support to
the Cloud Hypervisor driver. It is meant to show feasibility and to receive
early feedback.
I tested the live migration by invoking:
virsh -c ch:///session migrate --domain vmName --desturi ch+ssh://dstHost/session --live
Opens:
* What is required for a minimal viable live migration to be merged?
* Job state tracking? (virDomainObjBeginJob, ...)
* What should 'virsh domjobinfo' show?
* Testing?
* Anything else?
Stefan Kober (1):
Initial CH migrate API
src/ch/ch_conf.h | 4 +
src/ch/ch_domain.h | 2 +
src/ch/ch_driver.c | 362 +++++++++++++++++++++++++++++-
src/ch/ch_monitor.c | 156 +++++++++++++
src/ch/ch_monitor.h | 8 +
src/ch/ch_process.c | 136 ++++++++++-
src/ch/ch_process.h | 6 +
src/hypervisor/domain_interface.c | 1 +
src/libvirt-domain.c | 15 +-
9 files changed, 680 insertions(+), 10 deletions(-)
--
2.49.0
2 weeks
[PATCH] docs: fix list term highlighting in URI docs
by Daniel P. Berrangé
From: Daniel P. Berrangé <berrange(a)redhat.com>
Having a blank line between the term and its definition prevents the RST
to HTML convertor highlighting 'pkipath' correctly.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
docs/uri.rst | 1 -
1 file changed, 1 deletion(-)
diff --git a/docs/uri.rst b/docs/uri.rst
index 1d2c68f5b8..cc970001f4 100644
--- a/docs/uri.rst
+++ b/docs/uri.rst
@@ -296,7 +296,6 @@ Supported extra parameters:
**Example:** ``no_verify=1``
``pkipath``
-
Specifies x509 certificates path for the client. If any of the CA
certificate, client certificate, or client key is missing, the connection
will fail with a fatal error.
--
2.49.0
2 weeks
Question about managed/unmanaged persistent reservation disks
by Annie Li
Hello,
I've been looking at source code related to persistent reservation and
got confused a little bit about managed persistent reservation disks.
For disk configured with 'managed=yes' as the following,
<reservations managed='yes'>
<source type='unix'
path='/var/lib/libvirt/qemu/domain-7-brml10g19-iscsi-rese/pr-helper0.sock'
mode='client'/>
</reservations>
libvirt is responsible for starting a pr-helper program with a specific
associated socket file. The following source code shows that there is
only one pr-helper and socket file associated with the managed disks for
one VM.
const char *
qemuDomainGetManagedPRAlias(void)
{
return "pr-helper0";
}
char *
qemuDomainGetManagedPRSocketPath(qemuDomainObjPrivate *priv)
{
return g_strdup_printf("%s/%s.sock", priv->libDir,
qemuDomainGetManagedPRAlias());
}
So if the VM is booted with multiple disks configured with 'managed=yes'
for reservation, I suppose these multiple disks share the this managed
pr-helper and socket file. However, per the qemu document,
https://www.qemu.org/docs/master/interop/pr-helper.html
<https://www.qemu.org/docs/master/interop/pr-helper.html>
"It is invalid to send multiple commands concurrently on the same
socket. It is however possible to connect multiple sockets to the helper
and send multiple commands to the helper for one or more file descriptors."
Due to this limitation above, only one persistent reservation disk is
allowed as managed in theory. However, libvirt doesn't throw out any
error or warning when the VM is booted up with multiple managed
persistent reservation disks. I am wondering if I've missed something here?
For unmanaged persistent reservation disks, libvirt doesn't start the
pr-helper program for them. It is user's responsibility to start this
program with customized socket file per disk, but the complexity
increases with numbers of persistent reservation disks, especially in
the case of hotplug/hotunplog. Is there any plan to support multiple
managed persistent reservation disks with separate pr-helper/socket file?
Any suggestions/clarifications are greatly appreciated.
Thanks
Annie
2 weeks, 1 day
[PATCH] nvme: Fix more missing enum switches for VIR_DOMAIN_DISK_BUS_NVME
by Martin Kletzander
From: Martin Kletzander <mkletzan(a)redhat.com>
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
So it turned out there were more places, but some even in code that was
compiling on my machine and in the CI, but was not found. Not sure why, but I
went through all the places again from scratch, hopefully this time that's all.
Pushed.
src/bhyve/bhyve_domain.c | 1 +
src/qemu/qemu_validate.c | 1 +
src/vz/vz_sdk.c | 2 ++
src/vz/vz_utils.c | 1 +
4 files changed, 5 insertions(+)
diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c
index 3e18a462e460..c9bbf27d83ca 100644
--- a/src/bhyve/bhyve_domain.c
+++ b/src/bhyve/bhyve_domain.c
@@ -143,6 +143,7 @@ bhyveDomainDiskDefAssignAddress(struct _bhyveConn *driver,
case VIR_DOMAIN_DISK_BUS_USB:
case VIR_DOMAIN_DISK_BUS_UML:
case VIR_DOMAIN_DISK_BUS_SD:
+ case VIR_DOMAIN_DISK_BUS_NVME:
case VIR_DOMAIN_DISK_BUS_LAST:
default:
break;
diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
index 5eaaca87fed6..b2faf4300204 100644
--- a/src/qemu/qemu_validate.c
+++ b/src/qemu/qemu_validate.c
@@ -1556,6 +1556,7 @@ qemuValidateDomainDeviceDefAddressDrive(virDomainDeviceInfo *info,
case VIR_DOMAIN_DISK_BUS_SD:
case VIR_DOMAIN_DISK_BUS_NONE:
case VIR_DOMAIN_DISK_BUS_UML:
+ case VIR_DOMAIN_DISK_BUS_NVME:
case VIR_DOMAIN_DISK_BUS_LAST:
break;
}
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c
index 684b76ffa057..160778146dcd 100644
--- a/src/vz/vz_sdk.c
+++ b/src/vz/vz_sdk.c
@@ -3380,6 +3380,7 @@ static int prlsdkConfigureDisk(struct _vzDriver *driver,
case VIR_DOMAIN_DISK_BUS_USB:
case VIR_DOMAIN_DISK_BUS_UML:
case VIR_DOMAIN_DISK_BUS_SD:
+ case VIR_DOMAIN_DISK_BUS_NVME:
case VIR_DOMAIN_DISK_BUS_LAST:
default:
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
@@ -4339,6 +4340,7 @@ prlsdkGetBlockStats(PRL_HANDLE sdkstats,
case VIR_DOMAIN_DISK_BUS_USB:
case VIR_DOMAIN_DISK_BUS_UML:
case VIR_DOMAIN_DISK_BUS_SD:
+ case VIR_DOMAIN_DISK_BUS_NVME:
case VIR_DOMAIN_DISK_BUS_LAST:
default:
virReportError(VIR_ERR_INTERNAL_ERROR,
diff --git a/src/vz/vz_utils.c b/src/vz/vz_utils.c
index 7c08d0f88b58..976303479bb6 100644
--- a/src/vz/vz_utils.c
+++ b/src/vz/vz_utils.c
@@ -242,6 +242,7 @@ vzCheckDiskAddressDriveUnsupportedParams(virDomainDiskDef *disk)
case VIR_DOMAIN_DISK_BUS_USB:
case VIR_DOMAIN_DISK_BUS_UML:
case VIR_DOMAIN_DISK_BUS_SD:
+ case VIR_DOMAIN_DISK_BUS_NVME:
case VIR_DOMAIN_DISK_BUS_LAST:
default:
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
--
2.49.0
2 weeks, 1 day
[PATCH 0/3] Drop unnecessary build dependencies
by Andrea Bolognani
We've recently stopped checking for the presence of several
commands at build time. That means we don't need them in the
RPM or CI build environment either.
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1855622714
Andrea Bolognani (3):
rpm: Fix/clarify Requires
rpm: Drop unnecessary BuildRequires
ci: Drop unnecessary build dependencies
ci/buildenv/almalinux-9.sh | 9 ---------
ci/buildenv/alpine-321.sh | 6 ------
ci/buildenv/alpine-edge.sh | 6 ------
ci/buildenv/centos-stream-9.sh | 9 ---------
ci/buildenv/debian-12-cross-aarch64.sh | 8 --------
ci/buildenv/debian-12-cross-armv6l.sh | 8 --------
ci/buildenv/debian-12-cross-armv7l.sh | 8 --------
ci/buildenv/debian-12-cross-i686.sh | 8 --------
ci/buildenv/debian-12-cross-mips64el.sh | 8 --------
ci/buildenv/debian-12-cross-mipsel.sh | 8 --------
ci/buildenv/debian-12-cross-ppc64le.sh | 8 --------
ci/buildenv/debian-12-cross-s390x.sh | 8 --------
ci/buildenv/debian-12.sh | 8 --------
ci/buildenv/debian-sid-cross-aarch64.sh | 8 --------
ci/buildenv/debian-sid-cross-armv6l.sh | 8 --------
ci/buildenv/debian-sid-cross-armv7l.sh | 8 --------
ci/buildenv/debian-sid-cross-i686.sh | 8 --------
ci/buildenv/debian-sid-cross-mips64el.sh | 8 --------
ci/buildenv/debian-sid-cross-ppc64le.sh | 8 --------
ci/buildenv/debian-sid-cross-s390x.sh | 8 --------
ci/buildenv/debian-sid.sh | 8 --------
ci/buildenv/fedora-41.sh | 9 ---------
ci/buildenv/fedora-42-cross-mingw32.sh | 9 ---------
ci/buildenv/fedora-42-cross-mingw64.sh | 9 ---------
ci/buildenv/fedora-42.sh | 9 ---------
ci/buildenv/fedora-rawhide-cross-mingw32.sh | 9 ---------
ci/buildenv/fedora-rawhide-cross-mingw64.sh | 9 ---------
ci/buildenv/fedora-rawhide.sh | 9 ---------
ci/buildenv/opensuse-leap-15.sh | 8 --------
ci/buildenv/opensuse-tumbleweed.sh | 8 --------
ci/buildenv/ubuntu-2204.sh | 8 --------
ci/buildenv/ubuntu-2404.sh | 8 --------
ci/cirrus/freebsd-13.vars | 2 +-
ci/cirrus/freebsd-14.vars | 2 +-
ci/containers/almalinux-9.Dockerfile | 9 ---------
ci/containers/alpine-321.Dockerfile | 6 ------
ci/containers/alpine-edge.Dockerfile | 6 ------
ci/containers/centos-stream-9.Dockerfile | 9 ---------
.../debian-12-cross-aarch64.Dockerfile | 8 --------
.../debian-12-cross-armv6l.Dockerfile | 8 --------
.../debian-12-cross-armv7l.Dockerfile | 8 --------
ci/containers/debian-12-cross-i686.Dockerfile | 8 --------
.../debian-12-cross-mips64el.Dockerfile | 8 --------
.../debian-12-cross-mipsel.Dockerfile | 8 --------
.../debian-12-cross-ppc64le.Dockerfile | 8 --------
ci/containers/debian-12-cross-s390x.Dockerfile | 8 --------
ci/containers/debian-12.Dockerfile | 8 --------
.../debian-sid-cross-aarch64.Dockerfile | 8 --------
.../debian-sid-cross-armv6l.Dockerfile | 8 --------
.../debian-sid-cross-armv7l.Dockerfile | 8 --------
ci/containers/debian-sid-cross-i686.Dockerfile | 8 --------
.../debian-sid-cross-mips64el.Dockerfile | 8 --------
.../debian-sid-cross-ppc64le.Dockerfile | 8 --------
.../debian-sid-cross-s390x.Dockerfile | 8 --------
ci/containers/debian-sid.Dockerfile | 8 --------
ci/containers/fedora-41.Dockerfile | 9 ---------
.../fedora-42-cross-mingw32.Dockerfile | 9 ---------
.../fedora-42-cross-mingw64.Dockerfile | 9 ---------
ci/containers/fedora-42.Dockerfile | 9 ---------
.../fedora-rawhide-cross-mingw32.Dockerfile | 9 ---------
.../fedora-rawhide-cross-mingw64.Dockerfile | 9 ---------
ci/containers/fedora-rawhide.Dockerfile | 9 ---------
ci/containers/opensuse-leap-15.Dockerfile | 8 --------
ci/containers/opensuse-tumbleweed.Dockerfile | 8 --------
ci/containers/ubuntu-2204.Dockerfile | 8 --------
ci/containers/ubuntu-2404.Dockerfile | 8 --------
ci/lcitool/projects/libvirt.yml | 9 ---------
libvirt.spec.in | 18 +++---------------
68 files changed, 5 insertions(+), 548 deletions(-)
--
2.49.0
2 weeks, 1 day
