September 2024 - Devel - libvirt List Archives

[PATCH] qemu_driver: Fix indentation
by Martin Kletzander 03 Sep '24

03 Sep '24

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed under the 'trivial' rule. src/qemu/qemu_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3801ad623a40..609263d0263e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2094,8 +2094,8 @@ qemuDomainDestroyFlags(virDomainPtr dom, VIR_WARN("Failed to remove logs for VM '%s'", vm->def->name); event = virDomainEventLifecycleNewFromObj(vm, - VIR_DOMAIN_EVENT_STOPPED, - VIR_DOMAIN_EVENT_STOPPED_DESTROYED); + VIR_DOMAIN_EVENT_STOPPED, + VIR_DOMAIN_EVENT_STOPPED_DESTROYED); virDomainAuditStop(vm, "destroyed"); ret = 0; -- 2.46.0

1 0

[PATCH] qemuProcessSetupRawIO: Refactor return value and remove useless #ifdef
by Peter Krempa 03 Sep '24

03 Sep '24

The function can return directly rather than setting 'ret' as there's no cleanup. It also doesn't make sense to conditionally compile out the 'break' statement when checking whether a disk has rawio enabled if 'CAP_SYS_RAWIO' is _not_ defined as the function will still behave the same. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_process.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 242c93284e..2e4ee9e305 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -5183,7 +5183,6 @@ qemuProcessSetupRawIO(virDomainObj *vm, { bool rawio = false; size_t i; - int ret = -1; /* in case a certain disk is desirous of CAP_SYS_RAWIO, add this */ for (i = 0; i < vm->def->ndisks; i++) { @@ -5191,9 +5190,7 @@ qemuProcessSetupRawIO(virDomainObj *vm, if (disk->rawio == VIR_TRISTATE_BOOL_YES) { rawio = true; -#ifndef CAP_SYS_RAWIO break; -#endif } } @@ -5213,18 +5210,16 @@ qemuProcessSetupRawIO(virDomainObj *vm, } } - ret = 0; - if (rawio) { #ifdef CAP_SYS_RAWIO virCommandAllowCap(cmd, CAP_SYS_RAWIO); #else virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Raw I/O is not supported on this platform")); - ret = -1; + return -1; #endif } - return ret; + return 0; } -- 2.46.0

2 1

[libvirt][PATCH] qemu_nbdkit.c: use %llu to print time_t
by Qi.Chen＠windriver.com 03 Sep '24

03 Sep '24

From: Chen Qi <Qi.Chen(a)windriver.com> Use %lu to print time_t will give use the following error: error: format '%lu' expects argument of type 'long unsigned int', but argument 10 has type 'time_t' {aka 'long long int'} [-Werror=format=] So use %llu to print time_t. Signed-off-by: Chen Qi <Qi.Chen(a)windriver.com> --- src/qemu/qemu_nbdkit.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_nbdkit.c b/src/qemu/qemu_nbdkit.c index f099f35e1e..fe660c78e5 100644 --- a/src/qemu/qemu_nbdkit.c +++ b/src/qemu/qemu_nbdkit.c @@ -544,18 +544,18 @@ qemuNbdkitCapsFormatCache(qemuNbdkitCaps *nbdkitCaps) virBufferEscapeString(&buf, "<path>%s</path>\n", nbdkitCaps->path); - virBufferAsprintf(&buf, "<nbdkitctime>%lu</nbdkitctime>\n", - nbdkitCaps->ctime); + virBufferAsprintf(&buf, "<nbdkitctime>%llu</nbdkitctime>\n", + (long long)nbdkitCaps->ctime); virBufferEscapeString(&buf, "<plugindir>%s</plugindir>\n", nbdkitCaps->pluginDir); - virBufferAsprintf(&buf, "<plugindirmtime>%lu</plugindirmtime>\n", - nbdkitCaps->pluginDirMtime); + virBufferAsprintf(&buf, "<plugindirmtime>%llu</plugindirmtime>\n", + (long long)nbdkitCaps->pluginDirMtime); virBufferEscapeString(&buf, "<filterdir>%s</filterdir>\n", nbdkitCaps->filterDir); - virBufferAsprintf(&buf, "<filterdirmtime>%lu</filterdirmtime>\n", - nbdkitCaps->filterDirMtime); - virBufferAsprintf(&buf, "<selfctime>%lu</selfctime>\n", - nbdkitCaps->libvirtCtime); + virBufferAsprintf(&buf, "<filterdirmtime>%llu</filterdirmtime>\n", + (long long)nbdkitCaps->filterDirMtime); + virBufferAsprintf(&buf, "<selfctime>%llu</selfctime>\n", + (long long)nbdkitCaps->libvirtCtime); virBufferAsprintf(&buf, "<selfvers>%u</selfvers>\n", nbdkitCaps->libvirtVersion); @@ -593,10 +593,10 @@ virNbdkitCapsSaveFile(void *data, return -1; } - VIR_DEBUG("Saved caps '%s' for '%s' with (%lu, %lu)", + VIR_DEBUG("Saved caps '%s' for '%s' with (%llu, %llu)", filename, nbdkitCaps->path, - nbdkitCaps->ctime, - nbdkitCaps->libvirtCtime); + (long long)nbdkitCaps->ctime, + (long long)nbdkitCaps->libvirtCtime); return 0; } @@ -1054,7 +1054,7 @@ qemuNbdkitProcessBuildCommandCurl(qemuNbdkitProcess *proc, } if (proc->source->timeout > 0) { - g_autofree char *timeout = g_strdup_printf("%llu", proc->source->timeout); + g_autofree char *timeout = g_strdup_printf("%llu", (long long)proc->source->timeout); virCommandAddArgPair(cmd, "timeout", timeout); } -- 2.25.1

1 0

[PATCH 0/2] storage: Don't require 'showmount' at configure time and weaken dependency on RPM distros
by Peter Krempa 02 Sep '24

02 Sep '24

See individual patches. Peter Krempa (2): storage: fs: Remove build-time detection of 'showmount' program spec: Demote 'nfs-utils' as a weak dependency of 'daemon-driver-storage-core' libvirt.spec.in | 4 +--- meson.build | 7 ------- src/storage/storage_backend_fs.c | 2 +- 3 files changed, 2 insertions(+), 11 deletions(-) -- 2.46.0

2 3

Release of libvirt-10.7.0
by Jiri Denemark 02 Sep '24

02 Sep '24

The 10.7.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * Security * CVE-2024-8235: Crash of ``virtinterfaced`` via ``virConnectListInterfaces()`` A refactor of the code fetching the list of interfaces for multiple APIs introduced corner case on platforms where allocating 0 bytes of memory results in a NULL pointer. This corner case would lead to a NULL-pointer dereference and subsequent crash of ``virtinterfaced`` if ``virConnectListInterfaces()`` is called requesting 0 networks to be filled. The bug was introduced in libvirt-10.4.0 * New features * qemu: Introduce the ability to disable the built-in PS/2 controller It is now possible to control the state of the ``ps2`` feature in the domain XML for descendants of the generic PC machine type (``i440fx``, ``q35``, ``xenfv`` and ``isapc``). * Improvements * ch: support restore with network devices Cloud-Hypervisor starting from V40.0 supports restoring file descriptor backed network devices. So, create new net fds and pass them via SCM_RIGHTS to CH during restore operation. * ch: support basic networking modes Cloud-Hypervisor driver now supports Ethernet, Network (NAT) and Bridge networking modes. Enjoy. Jirka

1 0

Changing permissions for /var/lib/libvirt/images/
by Lee Garrett 02 Sep '24

02 Sep '24

Hi everyone, while using virt-v2v I've hit an issue [0], where essentially virt-v2v fails as non-root user, due to /var/lib/libvirt/images/ belonging to root:root. I proposed to change the ownership to root:libvirt, and permission bits to ug=rwx,o=x, as that would allow users of the libvirt group to use virt-v2v without running as root. My questions here are: Are there any downsides to this? AFAICS users of the libvirt group are allowed changed images via the libvirt API anyway, so from the security standpoint there should be no change. And if there are none, can we change the upstream default to those permissions? Thanks in advance, Lee P.S.: Keep me CCed, I'm off-list. [0] downstream Debian bug with more details: https://bugs.debian.org/1054230

2 1