[PATCH] Fix regression on default bus for keyboard/mouse from c4bc4d3b #577
by Jonathan Wright
Signed-off-by: Jonathan Wright <jonathan(a)almalinux.org>
---
src/conf/domain_postparse.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c
index e79913b73f..ee27023f3e 100644
--- a/src/conf/domain_postparse.c
+++ b/src/conf/domain_postparse.c
@@ -657,6 +657,7 @@ virDomainInputDefPostParse(virDomainInputDef *input,
if ((input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE ||
input->type == VIR_DOMAIN_INPUT_TYPE_KBD) &&
(ARCH_IS_X86(def->os.arch) || def->os.arch == VIR_ARCH_NONE)) {
+ input->bus = VIR_DOMAIN_INPUT_BUS_PS2;
} else if (ARCH_IS_S390(def->os.arch) ||
input->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) {
input->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO;
--
2.43.0
1 year, 3 months
[PATCH] conf: Restore setting default bus for input devices
by Michal Privoznik
Prior to v9.3.0-rc1~30 we used to set default bus for <input/>
devices, during XML parsing. In the commit this code was moved to
a post parse callback. But somehow the line that sets the bus in
one specific case disappeared. Bring it back.
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/577
Fixes: c4bc4d3b82fbe22e03c986ca896090f481df5c10
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/conf/domain_postparse.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c
index e79913b73f..ed9411f5e6 100644
--- a/src/conf/domain_postparse.c
+++ b/src/conf/domain_postparse.c
@@ -657,6 +657,7 @@ virDomainInputDefPostParse(virDomainInputDef *input,
if ((input->type == VIR_DOMAIN_INPUT_TYPE_MOUSE ||
input->type == VIR_DOMAIN_INPUT_TYPE_KBD) &&
(ARCH_IS_X86(def->os.arch) || def->os.arch == VIR_ARCH_NONE)) {
+ input->bus = VIR_DOMAIN_INPUT_BUS_PS2;
} else if (ARCH_IS_S390(def->os.arch) ||
input->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) {
input->bus = VIR_DOMAIN_INPUT_BUS_VIRTIO;
--
2.41.0
1 year, 3 months
[PATCH] qemucapabilitiesdata: Final update of 'caps_8.2.0_x86_64'
by Peter Krempa
QEMU 8.2 was released, update the x86_64 data for a final time.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
.../qemucapabilitiesdata/caps_8.2.0_x86_64.replies | 13 +++++++------
tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml | 4 ++--
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies
index b9d26f633c..56011f8317 100644
--- a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies
+++ b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.replies
@@ -17,11 +17,11 @@
{
"return": {
"qemu": {
- "micro": 50,
- "minor": 1,
+ "micro": 0,
+ "minor": 2,
"major": 8
},
- "package": "v8.1.0-3111-gad6ef0a42e"
+ "package": "v8.2.0"
},
"id": "libvirt-2"
}
@@ -30705,9 +30705,10 @@
"type": "bool"
},
{
- "default-value": 0,
- "name": "len-reserved-regions",
- "type": "uint32"
+ "default-value": [
+ ],
+ "name": "reserved-regions",
+ "type": "list"
},
{
"default-value": 0,
diff --git a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml
index ef3bd14597..ee52952702 100644
--- a/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml
@@ -199,9 +199,9 @@
<flag name='qcow2-discard-no-unref'/>
<flag name='run-with.async-teardown'/>
<flag name='virtio-blk-vhost-vdpa'/>
- <version>8001050</version>
+ <version>8002000</version>
<microcodeVersion>43100246</microcodeVersion>
- <package>v8.1.0-3111-gad6ef0a42e</package>
+ <package>v8.2.0</package>
<arch>x86_64</arch>
<hostCPU type='kvm' model='base' migratability='yes'>
<property name='avx-ne-convert' type='boolean' value='false'/>
--
2.43.0
1 year, 3 months
[PATCH] ci: Switch from FreeBSD 12.0 to FreeBSD 14.0
by Michal Privoznik
FreeBSD 12.0 is no longer supported since 14.0 is out. Change the
CI manifest and refresh the rest.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
.../{freebsd-12.vars => freebsd-14.vars} | 0
ci/gitlab/builds.yml | 28 +++++++++----------
ci/manifest.yml | 4 +--
3 files changed, 16 insertions(+), 16 deletions(-)
rename ci/cirrus/{freebsd-12.vars => freebsd-14.vars} (100%)
diff --git a/ci/cirrus/freebsd-12.vars b/ci/cirrus/freebsd-14.vars
similarity index 100%
rename from ci/cirrus/freebsd-12.vars
rename to ci/cirrus/freebsd-14.vars
diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml
index 5cc904ffb7..434e272e5a 100644
--- a/ci/gitlab/builds.yml
+++ b/ci/gitlab/builds.yml
@@ -1028,20 +1028,6 @@ mingw64-fedora-rawhide-local-env:
# Native cirrus build jobs
-x86_64-freebsd-12:
- extends: .cirrus_build_job
- needs: []
- allow_failure: false
- variables:
- CIRRUS_VM_IMAGE_NAME: freebsd-12-4
- CIRRUS_VM_IMAGE_SELECTOR: image_family
- CIRRUS_VM_INSTANCE_TYPE: freebsd_instance
- INSTALL_COMMAND: pkg install -y
- NAME: freebsd-12
- UPDATE_COMMAND: pkg update
- UPGRADE_COMMAND: pkg upgrade -y
-
-
x86_64-freebsd-13:
extends: .cirrus_build_job
needs: []
@@ -1056,6 +1042,20 @@ x86_64-freebsd-13:
UPGRADE_COMMAND: pkg upgrade -y
+x86_64-freebsd-14:
+ extends: .cirrus_build_job
+ needs: []
+ allow_failure: false
+ variables:
+ CIRRUS_VM_IMAGE_NAME: freebsd-14-0
+ CIRRUS_VM_IMAGE_SELECTOR: image_family
+ CIRRUS_VM_INSTANCE_TYPE: freebsd_instance
+ INSTALL_COMMAND: pkg install -y
+ NAME: freebsd-14
+ UPDATE_COMMAND: pkg update
+ UPGRADE_COMMAND: pkg upgrade -y
+
+
aarch64-macos-13:
extends: .cirrus_build_job
needs: []
diff --git a/ci/manifest.yml b/ci/manifest.yml
index 85f6b9d878..44353dd05b 100644
--- a/ci/manifest.yml
+++ b/ci/manifest.yml
@@ -192,10 +192,10 @@ targets:
allow-failure: true
builds: false
- freebsd-12: x86_64
-
freebsd-13: x86_64
+ freebsd-14: x86_64
+
opensuse-leap-15:
jobs:
- arch: x86_64
--
2.41.0
1 year, 3 months
Plans for 10.0.0 release (freeze on Tuesday 09 Jan)
by Jiri Denemark
We are getting close to 10.0.0 release of libvirt. To aim for the
release on Monday 15 Jan I suggest entering the freeze on Tuesday 09
Jan and tagging RC2 on Friday 12 Jan.
I hope this works for everyone.
Jirka
1 year, 3 months
[PATCH] storage_util: Fix the false condition in virStorageBackendDeviceIsEmpty
by Han Han
In virStorageBackendDeviceIsEmpty, the return value for
virStorageBackendPARTEDValidLabel is -1 or 0. That makes the later
condition 'ret == -2' make always false. Remove the always false
condition.
Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
Fixes: https://gitlab.com/libvirt/libvirt/-/issues/576
Signed-off-by: Han Han <hhan(a)redhat.com>
---
src/storage/storage_util.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index 7bf815d978..82bcfa5838 100644
--- a/src/storage/storage_util.c
+++ b/src/storage/storage_util.c
@@ -3352,15 +3352,9 @@ virStorageBackendDeviceIsEmpty(const char *devpath,
writelabel)) == -2)
ret = virStorageBackendPARTEDValidLabel(devpath, format, writelabel);
- if (ret == -2 && !writelabel)
+ if (!writelabel)
ret = 0;
- if (ret == -2) {
- virReportError(VIR_ERR_OPERATION_INVALID,
- _("Unable to probe '%1$s' for existing data, forced overwrite is necessary"),
- devpath);
- }
-
return ret == 0;
}
--
2.43.0
1 year, 3 months
[PATCH v2] Improve error message in remoteGetUNIXSocket
by Martin Kletzander
By adding a link to an explanation in the kbase.
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
v2:
- Do not print first socket path
- Add a kbase article explaining the details and solutions
- Add a link to said article
v1:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WG...
.../kbase/failed_connection_after_install.rst | 58 +++++++++++++++++++
docs/kbase/index.rst | 3 +
docs/kbase/meson.build | 1 +
src/remote/remote_sockets.c | 2 +-
4 files changed, 63 insertions(+), 1 deletion(-)
create mode 100644 docs/kbase/failed_connection_after_install.rst
diff --git a/docs/kbase/failed_connection_after_install.rst b/docs/kbase/failed_connection_after_install.rst
new file mode 100644
index 000000000000..cea57c460e10
--- /dev/null
+++ b/docs/kbase/failed_connection_after_install.rst
@@ -0,0 +1,58 @@
+========================================
+Libvirt does not work after installation
+========================================
+
+.. contents::
+
+TL;DR
+=====
+
+Most probably you want to start a virtqemud socket:
+
+::
+
+ # systemctl start virtqemud.socket
+
+If you are unsure whether to do this, please read the rest of this document.
+
+Symptom
+=======
+
+After installing libvirt or a virt tool that uses libvirt, commands do
+not work when run as root:
+
+::
+
+ # virsh list
+ error: failed to connect to the hypervisor
+ error: Operation not supported: Cannot use direct socket mode if no URI is set.
+ For more information see https://libvirt.org/kbase/failed_connection_after_install.html
+
+Root cause
+==========
+
+Distribution guidelines and/or configurations may discourage or prohibit
+starting services as part of a package installation. And because libvirt cannot
+know where you might want to connect it cannot start it on its own.
+
+Solution
+========
+
+After installing libvirt you may need to start a particular libvirt daemon on
+the local machine, set a (default) URI to connect to or, alternatively,
+rebooting the machine might work.
+
+If you are trying to connect to a remote libvirt daemon you need to specify a `connection URI <../uri.html>`__.
+
+If you are trying to control a local hypervisor, then the solution depends on various factors. You should know:
+
+- what hypervisor driver you want to connect to, whether it is ``virtqemud`` for QEMU, ``virtchd`` for Cloud Hypervisor, etc. and
+- how to start a service or socket (in case of systemd) on you system.
+
+Example of the most common solution, trying to use QEMU/KVM on Linux with systemd as an init system, is:
+
+::
+
+ # systemctl start virtqemud.socket
+
+also provided on the top of the page.
diff --git a/docs/kbase/index.rst b/docs/kbase/index.rst
index 896ececdf258..e51b35cbfce5 100644
--- a/docs/kbase/index.rst
+++ b/docs/kbase/index.rst
@@ -64,6 +64,9 @@ Usage
`Secure Boot <secureboot.html>`__
Enable and disable the Secure Boot feature
+`Connection fail after installation <failed_connection_after_install.html>`__
+ Explanation of a common issue users stumble upon after installation
+
Debugging
---------
diff --git a/docs/kbase/meson.build b/docs/kbase/meson.build
index 5b608293e27c..6d4ca90215a5 100644
--- a/docs/kbase/meson.build
+++ b/docs/kbase/meson.build
@@ -2,6 +2,7 @@ docs_kbase_files = [
'backing_chains',
'debuglogs',
'domainstatecapture',
+ 'failed_connection_after_install',
'index',
'kvm-realtime',
'launch_security_sev',
diff --git a/src/remote/remote_sockets.c b/src/remote/remote_sockets.c
index 4ab3d72933e2..8d403b6f014a 100644
--- a/src/remote/remote_sockets.c
+++ b/src/remote/remote_sockets.c
@@ -398,7 +398,7 @@ remoteGetUNIXSocket(remoteDriverTransport transport,
if (!direct_sock_name) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
- _("Cannot use direct socket mode if no URI is set"));
+ _("Cannot use direct socket mode if no URI is set. For more information see https://libvirt.org/kbase/failed_connection_after_install.html"));
return NULL;
}
--
2.43.0
1 year, 3 months
