June 2023 - Devel - libvirt List Archives

[PATCH 0/2] virstring: Fix string parsing. Again.
by Michal Privoznik 20 Jun '23

20 Jun '23

*** BLURB HERE *** Michal Prívozník (2): virstring: Move locale wrappers at the beginning virstring: Prefer strtoll_l() and strtoull_l() whenever possible meson.build | 1 + src/util/virstring.c | 239 ++++++++++++++++++++++++++++--------------- 2 files changed, 158 insertions(+), 82 deletions(-) -- 2.39.3

3 7

[libvirt PATCH 0/3] qemu: Include maximum physical address size in baseline CPU
by Jiri Denemark 16 Jun '23

16 Jun '23

Jiri Denemark (3): qemu: Report physical address size in domain capabilities qemu: Include maximum physical address size in baseline CPU NEWS: Mentioned an improvement for virConnectBaselineHypervisorCPU NEWS.rst | 7 ++++ docs/formatdomaincaps.rst | 6 +++- src/conf/schemas/domaincaps.rng | 3 ++ src/qemu/qemu_capabilities.c | 33 ++++++++++++++++++- src/qemu/qemu_driver.c | 17 ++++++++++ .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 1 + tests/domaincapsmock.c | 7 ++++ 39 files changed, 104 insertions(+), 2 deletions(-) -- 2.41.0

2 4

Plans for the next release
by Jiri Denemark 16 Jun '23

16 Jun '23

We are getting close to the next release of libvirt. To aim for the release on Jul 03 I suggest entering the freeze on Tuesday Jun 27 and tagging RC2 on Friday Jun 30. I hope this works for everyone. Jirka

1 0

[PATCH] conf/nwfilter: Initialize size_t attr to zero
by Martin Kletzander 14 Jun '23

14 Jun '23

Newer GCC (13.1.1 in my case) wrongly reports "maybe uninitialized" warning for this variable inside the next condition. Even though this accusation is wrong (the condition is guarded by the same condition as the for cycle initializing it), initialize it during the declaration so compilation errors don't stop others and maybe also future proof the code for changes. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed as a trivial kind-of build-break fix. src/conf/nwfilter_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index b79fd2561e7e..35f6efbbe267 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -2393,7 +2393,7 @@ virNWFilterRuleParse(xmlNodePtr node) if (nattrNodes > 0) { size_t i; - size_t attr; + size_t attr = 0; /* First we look up the type of the first valid element. The rest of * the parsing then only considers elements with same name. */ -- 2.41.0

1 0

[PATCH 0/4] Miscellaneous fixes, somehow Windows related
by Martin Kletzander 14 Jun '23

14 Jun '23

blurb is here, blurb is there, blurby blurby everywhere Martin Kletzander (4): util: Parse RSS into ullp util: Remove virStrToLong_l util: Use g_ascii_strtoll meson-dist: Use shutil.copy for copying a file scripts/meson-dist.py | 7 ++-- src/libvirt_private.syms | 1 - src/qemu/qemu_driver.c | 2 +- src/util/virprocess.c | 17 ++++++---- src/util/virprocess.h | 2 +- src/util/virstring.c | 73 +++++++++++++++++++--------------------- src/util/virstring.h | 5 --- tests/virstringtest.c | 4 --- 8 files changed, 49 insertions(+), 62 deletions(-) -- 2.41.0

2 7

Missing https://download.libvirt.org/maven2/net/juniper
by Nux 13 Jun '23

13 Jun '23

Hi, Anyone knows what happened to https://download.libvirt.org/maven2/net/juniper ? It has gone missing. Thanks

2 2

[BUG] Concurent call to virDomainDetachDevice issue
by Pierre-Emmanuel Jacquier 12 Jun '23

12 Jun '23

Hello, I experienced an issue with the virDomainDetachDevice call from the C lib or Virsh CLI. When I execute two concurrent call in parallel with virDomainDetachDevice, nothing happens the device is not detached, no log error in Journald or /var/log/libvirt/qemu/domain-name.log. If I execute the two call synchronously or only one call, the device is always detached with no issue. It seems there is a bug here, a concurrency issue/race condition...etc? Nothing in the doc mention such a behaviour: https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDevice Environment: virsh --version: 8.0.0 Libvirt version: libvirtd (libvirt) 8.0.0 Linux hostname 5.15.0-69-generic #76-Ubuntu SMP Fri Mar 17 17:19:29 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux Step to reproduce the issue: With a running domain (22.04.2 LTS) I'm attaching this device via NBD protocol with the following XML definition vdb.xml: <disk device='disk' type='network'> <driver name='qemu' type='raw' cache='none' /> <source protocol='nbd' name='66f85e15-4ea4-428e-a63e-001f41094d7d' reconnectDelay='10'> <host transport='unix' socket='/var/run/qemu/nbdserver.sock'/> </source> <target dev='vdb' bus='virtio'/> </disk> bash $ virsh attach-device <domain> vdb.xml the device is successfully attached. bash $ virsh detach-device <domain> vdb.xml & virsh detach-device <domain>vdb.xml & [7] 1780612 [8] 1780613 [7]+ Stopped virsh detach-device domain vdb.xml [8]- Stopped virsh detach-device domain vdb.xml vdb device is not detached, nothing happen, nor error log...etc. Thank you for this great project, Best regards, Pierre-Emmanuel. PS: Your website TLS certificate expires yesterday: Sunday, 11 June 2023 at 19:35:27

1 0

[PATCH 0/4] meson: Prepare for newer meson
by Michal Privoznik 12 Jun '23

12 Jun '23

When we switch to meson-0.57.0 or newer (which we can't do currently because of Debian 11 and Ubuntu 20.04), we can start using: libs_summary = { 'acl': acl_dep, ... } which not only reports 'YES'/'NO', but also library version: acl : YES 2.3.1 But in order to do that, we have switch away from conf.has() to XXX_dep(). Michal Prívozník (4): meson: acl_dep switch to dependency() meson: attr_dep switch to dependency() meson: numactl_dep switch to dependency() meson: Use dependency().found() instead of conf.has() meson.build | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) -- 2.39.3

2 5

[PATCH 0/2] qemu: Caps update for 'vdpa-block' and corner case hardening
by Peter Krempa 12 Jun '23

12 Jun '23

Peter Krempa (2): tests: qemucapabilitiesdata: Update data for qemu-8.1 dev cycle Explicitly reject unsupported storage types for legacy config generators src/libxl/xen_xl.c | 4 +- src/qemu/qemu_command.c | 5 +- .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 5 +- .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 1 - tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 5 +- .../caps_8.1.0_x86_64.replies | 82 +++++++++++-------- .../caps_8.1.0_x86_64.xml | 43 ++++++++-- .../cpu-host-model.x86_64-latest.args | 2 +- 8 files changed, 95 insertions(+), 52 deletions(-) -- 2.40.1

2 3

[libvirt] [PATCH 0/4] Introduce Notification VM exit feature (kvm x86 only)
by Lin Ma 11 Jun '23

11 Jun '23

From: Lin Ma <lma(a)suse.de> Kernel supports Notification VM exit feature since v6.0 under commit 2f4073e0. QEMU supports it as well since v7.2 under commit e2e69f6b. Lin Ma (4): conf: Introduce notify VM exit feature qemu: Validate notify VM exit feature is available only on x86 qemu: Generate command line for notify VM exit feature NEWS: Document notify VM exit feature NEWS.rst | 8 ++++++ docs/formatdomain.rst | 4 +++ src/conf/domain_conf.c | 32 +++++++++++++++++++++ src/conf/domain_conf.h | 7 +++++ src/conf/schemas/domaincommon.rng | 17 +++++++++++ src/qemu/qemu_command.c | 23 +++++++++++++-- src/qemu/qemu_validate.c | 12 +++++++- tests/qemuxml2argvdata/kvm-features-off.xml | 1 + tests/qemuxml2argvdata/kvm-features.args | 2 +- tests/qemuxml2argvdata/kvm-features.xml | 1 + 10 files changed, 102 insertions(+), 5 deletions(-) -- 2.40.1

1 4