[PATCH 0/5] qemu: Fix chardev hotplug and deny <console/> live detach
by Michal Privoznik
While trying to make live detach of <console/> work, I've accumulated
couple of patches. The most reasonable ones made it into this patch set
as paches 1-4. And after nearly losing my sanity, I've decided it's not
worth supporting live detach of <console/> since <serial/> works just
fine. And that's what patch 5 does. If somebody thinks it's too harsh,
I'm more than happy to review their patches that fix the problem.
What problem? Well, for starters:
https://bugzilla.redhat.com/show_bug.cgi?id=2156300#c4
https://bugzilla.redhat.com/show_bug.cgi?id=2156300#c8
Michal Prívozník (5):
qemuDomainChrInsertPreAlloced: Fix adding implicit console
qemuDomainChrRemove: Don't leak vmdef->consoles[0]
qemuAssignDeviceChrAlias: Fix a crasher during <console/> hotplug
qemuDomainRemoveChrDevice: Deal with qemuDomainChrRemove() failure
qemu_hotplug: Deny live detach of <console/>
src/qemu/qemu_alias.c | 1 +
src/qemu/qemu_hotplug.c | 43 +++++++++++++++++++++++++++++------------
2 files changed, 32 insertions(+), 12 deletions(-)
--
2.39.2
1 year, 6 months
[PATCH] tests: viracpitest only works on little endian
by Boris Fiuczynski
Commit fc216db4fb789cbd309 introduced a mocked test with binary test data
which fails on big endian machines.
Therefore build the viracpitest test only on little endian machines.
Fixes: fc216db4fb789cbd30917be036d0b94d965bdf7f
Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com>
---
tests/meson.build | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/meson.build b/tests/meson.build
index 35adbc2d56..0082446029 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -269,7 +269,6 @@ tests += [
{ 'name': 'storagevolxml2xmltest' },
{ 'name': 'sysinfotest' },
{ 'name': 'utiltest' },
- { 'name': 'viracpitest' },
{ 'name': 'viralloctest' },
{ 'name': 'virauthconfigtest' },
{ 'name': 'virbitmaptest' },
@@ -308,6 +307,12 @@ tests += [
{ 'name': 'virmigtest' },
]
+if host_machine.endian() == 'little'
+ tests += [
+ { 'name': 'viracpitest' },
+ ]
+endif
+
if host_machine.system() == 'linux'
tests += [
{ 'name': 'fchosttest' },
--
2.39.0
1 year, 6 months
[PATCH V2 0/3] Change default machine type for ARM and RISC-V
by Jim Fehlig
It is difficult, if not impossible, to create usable ARM and RISC-V VMs
using the current default machine types of 'integratorcp' and 'spike_v1.10'.
Change the default to the more suitable 'virt' type. See the following
thread for more details
https://listman.redhat.com/archives/libvir-list/2023-March/238746.html
V1:
https://listman.redhat.com/archives/libvir-list/2023-April/239392.html
Changes in V2:
Change the default for more ARM and RISC-V architectures
Reword NEWS entry
Jim Fehlig (3):
qemu: Change default machine type for ARM
qemu: Change default machine type for RISC-V
NEWS: Mention change of default machine type for ARM and RISC-V
NEWS.rst | 6 ++++++
src/qemu/qemu_capabilities.c | 10 +++++-----
tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 14 ++++++++++----
tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 14 ++++++++++----
tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 14 ++++++++++----
tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 14 ++++++++++----
tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 14 ++++++++++----
.../domaincapsdata/qemu_7.0.0-hvf.aarch64+hvf.xml | 6 ++++--
tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 14 ++++++++++----
tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 4 ++--
tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_5.0.0_riscv64.xml | 2 +-
tests/qemucapabilitiesdata/caps_5.2.0_aarch64.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml | 2 +-
tests/qemucapabilitiesdata/caps_6.0.0_aarch64.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_6.2.0_aarch64.xml | 8 ++++----
.../caps_7.0.0_aarch64+hvf.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_7.0.0_aarch64.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml | 4 ++--
19 files changed, 105 insertions(+), 61 deletions(-)
--
2.40.0
1 year, 6 months
[PATCH 0/3] Change default machine type for aarch64 and riscv64
by Jim Fehlig
This series is a first attempt at changing the default machine type for
aarch64 and riscv64. It is difficult, if not impossible, to create a
working VM with the current defaults of 'integratorcp' and 'spike_v1.10',
so let's change the default to type 'virt'. See the following thread for
more details
https://listman.redhat.com/archives/libvir-list/2023-March/238746.html
On aarch64, the default CPU for machine type 'virt' is 'cortex-a15',
which works fine for <domain type='qemu'>, but fails for type='kvm'
2023-04-14T21:03:03.392256Z qemu-system-aarch64: KVM is not supported for this guest CPU type
Do we need to go a step further and define a default CPU (presumably
host-passthrough) for machine type 'virt' for kvm domains on aarch64?
TIA for comments and suggestions!
Regards,
Jim
Jim Fehlig (3):
qemu: Change default machine type for aarch64
qemu: Change default machine type for riscv64
NEWS: Mention change of default machine type for aarch64 and riscv64
NEWS.rst | 6 ++++++
src/qemu/qemu_capabilities.c | 4 ++--
tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 14 ++++++++++----
tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 14 ++++++++++----
tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 14 ++++++++++----
tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 14 ++++++++++----
tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 14 ++++++++++----
.../domaincapsdata/qemu_7.0.0-hvf.aarch64+hvf.xml | 6 ++++--
tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 14 ++++++++++----
tests/qemucapabilitiesdata/caps_4.2.0_aarch64.xml | 4 ++--
tests/qemucapabilitiesdata/caps_5.0.0_aarch64.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_5.0.0_riscv64.xml | 2 +-
tests/qemucapabilitiesdata/caps_5.2.0_aarch64.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_5.2.0_riscv64.xml | 2 +-
tests/qemucapabilitiesdata/caps_6.0.0_aarch64.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_6.2.0_aarch64.xml | 8 ++++----
.../caps_7.0.0_aarch64+hvf.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_7.0.0_aarch64.xml | 8 ++++----
tests/qemucapabilitiesdata/caps_8.0.0_riscv64.xml | 4 ++--
19 files changed, 102 insertions(+), 58 deletions(-)
--
2.40.0
1 year, 6 months
[PATCH] kbase: debuglogs: Add a 'TL; DR' section for enabling logging in most common case
by Peter Krempa
The document grew a bit too much explaining all the mistakes we've seen
the users do when configuring logging. Add a section distilling the
configuration of the most basic scenario which we can refer to when
upstream issues are reported. The scenario is for a runtime setting of
logging into a file applied to the 'virtqemud' daemon.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
docs/kbase/debuglogs.rst | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/docs/kbase/debuglogs.rst b/docs/kbase/debuglogs.rst
index 53d70ee748..811ccf0102 100644
--- a/docs/kbase/debuglogs.rst
+++ b/docs/kbase/debuglogs.rst
@@ -16,6 +16,22 @@ server side that matters as nearly all interesting work takes place there.
Moreover, libvirt catches stderr of all running domains. These can be useful as
well.
+TL;DR - Enable debug logs for most common scenario
+===================================================
+
+This applies to the most common scenario of ``system`` instance of
+``virtqemud``. Log setting is not persisted, so a restart of ``virtqemud`` or
+the system clears this setting::
+
+ # virt-admin -c virtqemud:///system daemon-log-outputs "3:journald 1:file:/var/log/libvirt/libvirtd.log"
+ # virt-admin -c virtqemud:///system daemon-log-filters "3:remote 4:event 3:util.json 3:util.object 3:util.dbus 3:util.netlink 3:node_device 3:rpc 3:access 1:*"
+
+ # # optionally disable timeout of the daemon
+ # virt-admin -c virtqemud:///system daemon-timeout 0
+
+For any other configuration please read the rest of the document. If you want
+to persist the log level and log outputs settings edit
+``/etc/libvirt/virtqemud.conf`` and look for ``log-filters`` and ``log-outputs``
Logging settings in libvirt
===========================
--
2.39.2
1 year, 6 months
[PATCH 0/2] virsh: Introduce --xpath and --wrap to (dom)capabilities
by Michal Privoznik
*** BLURB HERE ***
Michal Prívozník (2):
virsh: Introduce --xpath and --wrap to capabilities
virsh: Introduce --xpath and --wrap to domcapabilities
docs/manpages/virsh.rst | 17 ++++++++++++++-
tools/virsh-host.c | 46 ++++++++++++++++++++++++++++++++++-------
2 files changed, 54 insertions(+), 9 deletions(-)
--
2.39.2
1 year, 6 months
[PATCH 0/3] Setup iothread polling attributes in the XML
by Peter Krempa
Peter Krempa (3):
conf: Store the iothread 'poll' settings in the XML
qemu: Use configured iothread poll parameters on startup
docs: formatdomain: Properly indent example XML for setting
'metadata_cache'
docs/formatdomain.rst | 53 +++++++++++--------
src/conf/domain_conf.c | 41 +++++++++++++-
src/conf/domain_conf.h | 7 +++
src/conf/schemas/domaincommon.rng | 19 +++++++
src/qemu/qemu_command.c | 18 +++++++
src/qemu/qemu_driver.c | 30 ++++++-----
...othreads-ids-pool-sizes.x86_64-latest.args | 6 +--
.../iothreads-ids-pool-sizes.xml | 12 +++--
8 files changed, 142 insertions(+), 44 deletions(-)
--
2.39.2
1 year, 6 months
Plans for the next release
by Jiri Denemark
We are getting close to the next release of libvirt. To aim for the
release on May 02 I suggest entering the freeze on Tuesday Apr 25 and
tagging RC2 on Thursday Apr 27.
I hope this works for everyone.
Jirka
1 year, 6 months
[libvirt PATCH] network: do not assume dnsmasq in networkUpdateState
by Ján Tomko
If we don't have dnsmasq, it's pointless to try to find
its pidfile.
Also, dnsmasqCapsGetBinaryPath would access a NULL pointer.
Fixes: 4b68c982e283471575bacbf87302495864da46fe
Foxes: https://gitlab.com/libvirt/libvirt/-/issues/456
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/network/bridge_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index 3fa56bfc09..ee4bbd4a93 100644
--- a/src/network/bridge_driver.c
+++ b/src/network/bridge_driver.c
@@ -492,7 +492,7 @@ networkUpdateState(virNetworkObj *obj,
virNetworkObjPortForEach(obj, networkUpdatePort, obj);
/* Try and read dnsmasq pids of active networks */
- if (virNetworkObjIsActive(obj) && def->ips && (def->nips > 0)) {
+ if (dnsmasq_caps && virNetworkObjIsActive(obj) && def->ips && (def->nips > 0)) {
pid_t dnsmasqPid;
if (networkSetMacMap(cfg, obj) < 0)
--
2.39.2
1 year, 6 months
[libvirt] [RFC] support vhost-user-scsi configuration
by wangjian (AN)
Hi Guys,
Currently qemu and spdk already support vhost-user-scsi, but there is no vhost-user-scsi configuration in libvirt.
We hope that libvirt supports the following configurations to facilitate docking with qemu.
<controller type='scsi' index='0' model='vhost-user-scsi'>
<driver queues='4'/>
<source type='unix' path='/var/tmp/scsi'>
<reconnect enabled='yes' timeout='3'/>
</source>
<address type='pci' domain='0x0000' bus='0x02' slot='0x02' function='0x0'/>
</controller>
The usage in qemu like this:
-chardev socket,id=chr-vu-virtio-disk10,path=/var/tmp/scsi,reconnect=3
-device vhost-user-blk-pci,num-queues=4,bus=pci.2,addr=0x0,chardev=chr-vu-virtio-disk10,id=scsi0
Could anyone give some suggestions?
1 year, 6 months
