[PATCH 0/3] conf: Separate domain post parse code into domain_postparse.c
by Michal Privoznik
*** BLURB HERE ***
Michal Prívozník (3):
domain_conf: Unexport virDomainDefPostParseDeviceIteratorData
conf: Separate domain post parse code into domain_postparse.c
domain_postparse: Move error messages onto single line
po/POTFILES | 1 +
src/conf/domain_conf.c | 1446 +---------------------------------
src/conf/domain_conf.h | 10 -
src/conf/domain_postparse.c | 1466 +++++++++++++++++++++++++++++++++++
src/conf/domain_postparse.h | 37 +
src/conf/domain_validate.c | 11 +-
src/conf/meson.build | 1 +
src/libvirt_private.syms | 5 +-
src/libxl/xen_xl.c | 1 +
src/libxl/xen_xm.c | 1 +
src/lxc/lxc_native.c | 1 +
src/qemu/qemu_driver.c | 1 +
src/qemu/qemu_process.c | 1 +
src/vmx/vmx.c | 1 +
14 files changed, 1525 insertions(+), 1458 deletions(-)
create mode 100644 src/conf/domain_postparse.c
create mode 100644 src/conf/domain_postparse.h
--
2.35.1
2 years, 4 months
[PATCH] docs: Fix syntax error for defaultiothread
by Han Han
Signed-off-by: Han Han <hhan(a)redhat.com>
---
docs/formatdomain.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index a4e3c39928..89b627f4bd 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -715,7 +715,7 @@ host/guest with many LUNs. :since:`Since 1.2.8 (QEMU only)`
<iothread id="6"/>
<iothread id="8" thread_pool_min="2" thread_pool_max="32"/>
</iothreadids>
- <defaultiothread thread_pool_min="8" thread_pool_max="16">
+ <defaultiothread thread_pool_min="8" thread_pool_max="16"/>
...
</domain>
--
2.36.1
2 years, 4 months
[PATCH] schemas: rng: Make secret optional in storage vol
by Han Han
For a qcow2 storage volume with luks encryption created by qemu-img, its
dumped storage vol XML has no secret element in encryption:
<volume type='file'>
...
<encryption format='luks'>
</encryption>
...
</volume>
That will cause a failure in rng validation. Fix that validation failure.
Signed-off-by: Han Han <hhan(a)redhat.com>
---
src/conf/schemas/storagecommon.rng | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/src/conf/schemas/storagecommon.rng b/src/conf/schemas/storagecommon.rng
index 10f1bc6a15..76714c9aad 100644
--- a/src/conf/schemas/storagecommon.rng
+++ b/src/conf/schemas/storagecommon.rng
@@ -24,17 +24,19 @@
</choice>
</attribute>
</optional>
- <interleave>
- <ref name="secret"/>
- <optional>
- <element name="cipher">
- <ref name="keycipher"/>
- </element>
- <element name="ivgen">
- <ref name="keyivgen"/>
- </element>
- </optional>
- </interleave>
+ <optional>
+ <interleave>
+ <ref name="secret"/>
+ <optional>
+ <element name="cipher">
+ <ref name="keycipher"/>
+ </element>
+ <element name="ivgen">
+ <ref name="keyivgen"/>
+ </element>
+ </optional>
+ </interleave>
+ </optional>
</element>
</define>
--
2.36.1
2 years, 4 months
[PATCH] virt-xml-validate: Fix incorrect wildcards for XML roots
by Han Han
To match the XML roots domainCapabilities and storagepoolCapabilities,
the wildcards should be *domainCap* and *storagepoolCap*.
Fixes: 7b0e2e4a55
Signed-off-by: Han Han <hhan(a)redhat.com>
---
tools/virt-xml-validate.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in
index e444ef2fbc..2d5ba510ab 100644
--- a/tools/virt-xml-validate.in
+++ b/tools/virt-xml-validate.in
@@ -86,7 +86,7 @@ if [ -z "$TYPE" ]; then
*domainbackup*)
TYPE="domainbackup"
;;
- *domaincaps*)
+ *domainCap*)
TYPE="domaincaps"
;;
*domain*)
@@ -98,7 +98,7 @@ if [ -z "$TYPE" ]; then
*network*)
TYPE="network"
;;
- *storagepoolcaps*)
+ *storagepoolCap*)
TYPE="storagepoolcaps"
;;
*pool*)
--
2.36.1
2 years, 4 months
[PATCH] domain_validate: Properly terminate switch() in virDomainIOMMUDefValidate()
by Michal Privoznik
In my previous commit I've introduced virDomainIOMMUDefValidate()
function with a switch() statement. However, two cases in it,
though empty, were not terminated with a break statement which
made compiler complain.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
Merged under trivial rule.
src/conf/domain_validate.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
index d35451c26a..57d4e63a26 100644
--- a/src/conf/domain_validate.c
+++ b/src/conf/domain_validate.c
@@ -2598,6 +2598,7 @@ virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu)
case VIR_DOMAIN_IOMMU_MODEL_VIRTIO:
case VIR_DOMAIN_IOMMU_MODEL_LAST:
+ break;
}
return 0;
--
2.35.1
2 years, 4 months
Re: Incomplete information in the website Wiki for libvirt.org
by Martin Kletzander
On Fri, Jul 01, 2022 at 04:37:55AM -0500, Uriel Emmanuel Pelaez Hernández wrote:
>Dear Web Marster from wiki.libvirt.org,
>
>I tried to look for the libvirtd, the demon that is suppose to run under
>Linux/Unix environment,
>but your site didn't show any information. Only a statement appeared:
>"Create the page libvirtd "
>
Hi, we are slowly migrating the wiki pages to knowledge base articles
due to various issues with the wiki.
>Please, update your site or suggest any other weblink with the information.
>
Have a look at our docs page: https://libvirt.org/docs.html where you
might find what you are looking for. There is a particular page about
daemons here: https://libvirt.org/daemons.html
>In theory CygWin use your package, but the information is incomplete too,
>about this issue.
>
>I send this mail to these both Email address by the information displayed
>in your wiki, about the contact address to solve this kind of problems.
>
Unfortunately I am not sure what are you trying to solve, so I don't
know what clearer pointers to give you.
>By now, Google Service in my region is deprecated, so the information that
>the WebBrowser display is not the best.
>
>I send this request from my Email of Graduated Student form the University
>domain.
>
>Best Regards,
>Mr. Peláez Uriel.
>Mexico City
Have a nice day,
Martin
2 years, 4 months
[PATCH 0/3] IOMMU improvements
by Michal Privoznik
These are inspired by:
https://bugzilla.redhat.com/show_bug.cgi?id=2101633
While there are some missing info to fix the actual but, I've noticed
couple of areas for improvement while investigating the bug.
Michal Prívozník (3):
qemu_domain_address: Drop needless virDomainIOMMUModel typecast
docs: Document <address/> for IOMMU device
domain_validate: Disallow non-virtio IOMMU with an <address/>
docs/formatdomain.rst | 3 +++
src/conf/domain_validate.c | 25 ++++++++++++++++++++++++-
src/qemu/qemu_domain_address.c | 4 ++--
3 files changed, 29 insertions(+), 3 deletions(-)
--
2.35.1
2 years, 4 months
[libvirt PATCH] [pushed] Fix spelling
by Tim Wiederhake
Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
---
docs/kbase/secureboot.rst | 2 +-
src/qemu/qemu_migration.c | 2 +-
src/rpc/virnetmessage.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/kbase/secureboot.rst b/docs/kbase/secureboot.rst
index ebd9d56da8..8f151c1f2a 100644
--- a/docs/kbase/secureboot.rst
+++ b/docs/kbase/secureboot.rst
@@ -49,7 +49,7 @@ snippet:
</os>
Versions older than 7.2.0 require manually providing all information
-about the firmware and are not covered here. Plese refer to `the
+about the firmware and are not covered here. Please refer to `the
relevant documentation
<../formatdomain.html#operating-system-booting>`__ for details.
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 368995085f..9c3fd41761 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -2726,7 +2726,7 @@ qemuMigrationAnyCanResume(virDomainObj *vm,
/* This should never happen since POSTCOPY_RESUME is newer than
* CHANGE_PROTECTION, but let's check it anyway in case we're talking to
- * a weired client.
+ * a weird client.
*/
if (job == VIR_ASYNC_JOB_MIGRATION_OUT &&
expectedPhase < QEMU_MIGRATION_PHASE_PERFORM_RESUME &&
diff --git a/src/rpc/virnetmessage.c b/src/rpc/virnetmessage.c
index d298d30d57..ceba1a5a8e 100644
--- a/src/rpc/virnetmessage.c
+++ b/src/rpc/virnetmessage.c
@@ -437,7 +437,7 @@ int virNetMessageDecodePayload(virNetMessage *msg,
* virNetMessageEncodePayloadRaw:
* @msg: message to encode payload into
* @data: data to encode into @msg
- * @len: lenght of @data
+ * @len: length of @data
*
* Encodes message payload. If @data is NULL or @len is 0 an empty message is
* encoded.
--
2.36.1
2 years, 4 months
[libvirt PATCH] conf: fix error message for wrong thread_pool_size
by Ján Tomko
Fix the copy-and-paste error by referring to the correct variable.
Fixes: 0df2e7df80452f81edbfeb0ee355235b533346a9
https://bugzilla.redhat.com/show_bug.cgi?id=2103132
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
Pushed as trivial.
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index fb8bf4cfec..2c2f23242e 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -9949,7 +9949,7 @@ virDomainFSDefParseXML(virDomainXMLOption *xmlopt,
virStrToLong_i(thread_pool_size, NULL, 10, &def->thread_pool_size) < 0) {
virReportError(VIR_ERR_XML_ERROR,
_("cannot parse thread pool size '%s' for virtiofs"),
- queue_size);
+ thread_pool_size);
goto error;
}
--
2.35.3
2 years, 4 months
[PATCH] storagepoolxml2argvtest: Fix output data for 'pool-netfs-protocol-ver'
by Peter Krempa
The storage pool tests have host-specific versions which I neglected to
update in commit c44930d932203b4a58dccbbeaa814fff6cea8216 thus breaking
the test-suite on non-linux OSes.
Fixes: c44930d932203b4a58dccbbeaa814fff6cea8216
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
Pushed as a build-fix.
.../pool-netfs-protocol-ver-freebsd.argv | 2 +-
tests/storagepoolxml2argvdata/pool-netfs-protocol-ver.argv | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/storagepoolxml2argvdata/pool-netfs-protocol-ver-freebsd.argv b/tests/storagepoolxml2argvdata/pool-netfs-protocol-ver-freebsd.argv
index 32cdaebcff..20954ef50c 100644
--- a/tests/storagepoolxml2argvdata/pool-netfs-protocol-ver-freebsd.argv
+++ b/tests/storagepoolxml2argvdata/pool-netfs-protocol-ver-freebsd.argv
@@ -1,5 +1,5 @@
mount \
--o nosuid,noexec,nfsvers=3 \
+-o nosuid,noexec,nfsvers=4.1 \
-t nfs \
localhost:/var/lib/libvirt/images \
/mnt
diff --git a/tests/storagepoolxml2argvdata/pool-netfs-protocol-ver.argv b/tests/storagepoolxml2argvdata/pool-netfs-protocol-ver.argv
index ed157883c0..9afc6090b8 100644
--- a/tests/storagepoolxml2argvdata/pool-netfs-protocol-ver.argv
+++ b/tests/storagepoolxml2argvdata/pool-netfs-protocol-ver.argv
@@ -1,5 +1,5 @@
mount \
--o nfsvers=3 \
+-o nfsvers=4.1 \
-t nfs \
localhost:/var/lib/libvirt/images \
/mnt
--
2.36.1
2 years, 4 months
