July 2022 - Devel - libvirt List Archives

[PATCH 00/11] Test case cleanups
by Peter Krempa 07 Jul '22

07 Jul '22

These patches originate from my upcoming series bumping minimum qemu version to 4.2 and are valid even without the qemu version bump. Peter Krempa (11): test: domaincaps: Remove old test data qemuxml2(argv|xml)test: Drop qemu-3.1 version of 'cpu-Icelake-Server-pconfig' qemuxml2argvtest: Drop 'qemu-4.1' versions of hyperv tests qemuxml2argvtest: Convert 'cpu-eoi-(disabled|enabled)' cases to VIR_TEST_CAPS_LATEST qemuxml2argvtest: Remove qemu-4.0 versions of cpu feature test cases qemuxml2argvtest: Convert 'net-user' case to _LATEST qemuxml2argvtest: Make 'qemu-ns' test case more stable qemuxml2argvtest: Move real-caps versions of cpu-host tests out of the block setting fake host cpu qemu: Remove qemu-4.0 version of 'cpu-translation' test case qemucapabilitiestest: Fake proper version for 'caps_4.2.0.ppc64' case qemucapabilitiestest: Fake proper version for 'caps_4.2.0.aarch64' case .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 191 --------------- .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 204 ---------------- tests/domaincapsdata/qemu_2.11.0.s390x.xml | 219 ----------------- tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 191 --------------- .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 212 ---------------- .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 222 ----------------- .../qemu_2.12.0-virt.aarch64.xml | 172 ------------- tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 166 ------------- tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 136 ----------- tests/domaincapsdata/qemu_2.12.0.s390x.xml | 219 ----------------- tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 212 ---------------- .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 208 ---------------- .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 220 ----------------- tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 138 ----------- tests/domaincapsdata/qemu_3.0.0.s390x.xml | 226 ------------------ tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 208 ---------------- .../caps_4.2.0.aarch64.replies | 4 +- .../caps_4.2.0.aarch64.xml | 2 +- .../caps_4.2.0.ppc64.replies | 4 +- .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 2 +- ...u-Icelake-Server-pconfig.x86_64-3.1.0.args | 33 --- tests/qemuxml2argvdata/cpu-eoi-disabled.args | 31 --- ...gs => cpu-eoi-disabled.x86_64-latest.args} | 12 +- tests/qemuxml2argvdata/cpu-eoi-disabled.xml | 2 +- tests/qemuxml2argvdata/cpu-eoi-enabled.args | 31 --- ...rgs => cpu-eoi-enabled.x86_64-latest.args} | 13 +- tests/qemuxml2argvdata/cpu-eoi-enabled.xml | 2 +- .../cpu-translation.x86_64-4.0.0.args | 33 --- .../eoi-enabled.x86_64-4.0.0.args | 32 --- .../hyperv-panic.x86_64-4.0.0.args | 31 --- .../qemuxml2argvdata/hyperv.x86_64-4.0.0.args | 31 --- .../kvmclock+eoi-disabled.x86_64-4.0.0.args | 32 --- .../net-user.x86_64-4.0.0.args | 35 --- ...4.0.0.args => net-user.x86_64-latest.args} | 18 +- .../pv-spinlock-disabled.x86_64-4.0.0.args | 32 --- .../pv-spinlock-enabled.x86_64-4.0.0.args | 32 --- tests/qemuxml2argvdata/qemu-ns.xml | 1 - tests/qemuxml2argvtest.c | 24 +- ...pu-Icelake-Server-pconfig.x86_64-3.1.0.xml | 32 --- tests/qemuxml2xmloutdata/cpu-eoi-disabled.xml | 2 +- tests/qemuxml2xmloutdata/cpu-eoi-enabled.xml | 2 +- .../qemu-ns.x86_64-latest.xml | 1 - tests/qemuxml2xmltest.c | 1 - 43 files changed, 41 insertions(+), 3578 deletions(-) delete mode 100644 tests/domaincapsdata/qemu_2.11.0-q35.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_2.11.0-tcg.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_2.11.0.s390x.xml delete mode 100644 tests/domaincapsdata/qemu_2.11.0.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_2.12.0-q35.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_2.12.0-tcg.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_2.12.0-virt.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_2.12.0.aarch64.xml delete mode 100644 tests/domaincapsdata/qemu_2.12.0.ppc64.xml delete mode 100644 tests/domaincapsdata/qemu_2.12.0.s390x.xml delete mode 100644 tests/domaincapsdata/qemu_2.12.0.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_3.0.0-q35.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_3.0.0-tcg.x86_64.xml delete mode 100644 tests/domaincapsdata/qemu_3.0.0.ppc64.xml delete mode 100644 tests/domaincapsdata/qemu_3.0.0.s390x.xml delete mode 100644 tests/domaincapsdata/qemu_3.0.0.x86_64.xml delete mode 100644 tests/qemuxml2argvdata/cpu-Icelake-Server-pconfig.x86_64-3.1.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-eoi-disabled.args rename tests/qemuxml2argvdata/{hyperv-off.x86_64-4.0.0.args => cpu-eoi-disabled.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-eoi-enabled.args rename tests/qemuxml2argvdata/{eoi-disabled.x86_64-4.0.0.args => cpu-eoi-enabled.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-translation.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/eoi-enabled.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/hyperv-panic.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/hyperv.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/kvmclock+eoi-disabled.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/net-user.x86_64-4.0.0.args rename tests/qemuxml2argvdata/{qemu-ns.x86_64-4.0.0.args => net-user.x86_64-latest.args} (61%) delete mode 100644 tests/qemuxml2argvdata/pv-spinlock-disabled.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2argvdata/pv-spinlock-enabled.x86_64-4.0.0.args delete mode 100644 tests/qemuxml2xmloutdata/cpu-Icelake-Server-pconfig.x86_64-3.1.0.xml -- 2.36.1

2 13

[PATCH 0/3] conf: Separate domain post parse code into domain_postparse.c
by Michal Privoznik 07 Jul '22

07 Jul '22

*** BLURB HERE *** Michal Prívozník (3): domain_conf: Unexport virDomainDefPostParseDeviceIteratorData conf: Separate domain post parse code into domain_postparse.c domain_postparse: Move error messages onto single line po/POTFILES | 1 + src/conf/domain_conf.c | 1446 +--------------------------------- src/conf/domain_conf.h | 10 - src/conf/domain_postparse.c | 1466 +++++++++++++++++++++++++++++++++++ src/conf/domain_postparse.h | 37 + src/conf/domain_validate.c | 11 +- src/conf/meson.build | 1 + src/libvirt_private.syms | 5 +- src/libxl/xen_xl.c | 1 + src/libxl/xen_xm.c | 1 + src/lxc/lxc_native.c | 1 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_process.c | 1 + src/vmx/vmx.c | 1 + 14 files changed, 1525 insertions(+), 1458 deletions(-) create mode 100644 src/conf/domain_postparse.c create mode 100644 src/conf/domain_postparse.h -- 2.35.1

2 4

[PATCH] docs: Fix syntax error for defaultiothread
by Han Han 07 Jul '22

07 Jul '22

Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index a4e3c39928..89b627f4bd 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -715,7 +715,7 @@ host/guest with many LUNs. :since:`Since 1.2.8 (QEMU only)` <iothread id="6"/> <iothread id="8" thread_pool_min="2" thread_pool_max="32"/> </iothreadids> - <defaultiothread thread_pool_min="8" thread_pool_max="16"> + <defaultiothread thread_pool_min="8" thread_pool_max="16"/> ... </domain> -- 2.36.1

2 1

[PATCH] schemas: rng: Make secret optional in storage vol
by Han Han 07 Jul '22

07 Jul '22

For a qcow2 storage volume with luks encryption created by qemu-img, its dumped storage vol XML has no secret element in encryption: <volume type='file'> ... <encryption format='luks'> </encryption> ... </volume> That will cause a failure in rng validation. Fix that validation failure. Signed-off-by: Han Han <hhan(a)redhat.com> --- src/conf/schemas/storagecommon.rng | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/conf/schemas/storagecommon.rng b/src/conf/schemas/storagecommon.rng index 10f1bc6a15..76714c9aad 100644 --- a/src/conf/schemas/storagecommon.rng +++ b/src/conf/schemas/storagecommon.rng @@ -24,17 +24,19 @@ </choice> </attribute> </optional> - <interleave> - <ref name="secret"/> - <optional> - <element name="cipher"> - <ref name="keycipher"/> - </element> - <element name="ivgen"> - <ref name="keyivgen"/> - </element> - </optional> - </interleave> + <optional> + <interleave> + <ref name="secret"/> + <optional> + <element name="cipher"> + <ref name="keycipher"/> + </element> + <element name="ivgen"> + <ref name="keyivgen"/> + </element> + </optional> + </interleave> + </optional> </element> </define> -- 2.36.1

2 1

[PATCH] virt-xml-validate: Fix incorrect wildcards for XML roots
by Han Han 07 Jul '22

07 Jul '22

To match the XML roots domainCapabilities and storagepoolCapabilities, the wildcards should be *domainCap* and *storagepoolCap*. Fixes: 7b0e2e4a55 Signed-off-by: Han Han <hhan(a)redhat.com> --- tools/virt-xml-validate.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in index e444ef2fbc..2d5ba510ab 100644 --- a/tools/virt-xml-validate.in +++ b/tools/virt-xml-validate.in @@ -86,7 +86,7 @@ if [ -z "$TYPE" ]; then *domainbackup*) TYPE="domainbackup" ;; - *domaincaps*) + *domainCap*) TYPE="domaincaps" ;; *domain*) @@ -98,7 +98,7 @@ if [ -z "$TYPE" ]; then *network*) TYPE="network" ;; - *storagepoolcaps*) + *storagepoolCap*) TYPE="storagepoolcaps" ;; *pool*) -- 2.36.1

2 1

[PATCH] domain_validate: Properly terminate switch() in virDomainIOMMUDefValidate()
by Michal Privoznik 04 Jul '22

04 Jul '22

In my previous commit I've introduced virDomainIOMMUDefValidate() function with a switch() statement. However, two cases in it, though empty, were not terminated with a break statement which made compiler complain. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Merged under trivial rule. src/conf/domain_validate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index d35451c26a..57d4e63a26 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2598,6 +2598,7 @@ virDomainIOMMUDefValidate(const virDomainIOMMUDef *iommu) case VIR_DOMAIN_IOMMU_MODEL_VIRTIO: case VIR_DOMAIN_IOMMU_MODEL_LAST: + break; } return 0; -- 2.35.1

1 0

Re: Incomplete information in the website Wiki for libvirt.org
by Martin Kletzander 04 Jul '22

04 Jul '22

On Fri, Jul 01, 2022 at 04:37:55AM -0500, Uriel Emmanuel Pelaez Hernández wrote: >Dear Web Marster from wiki.libvirt.org, > >I tried to look for the libvirtd, the demon that is suppose to run under >Linux/Unix environment, >but your site didn't show any information. Only a statement appeared: >"Create the page libvirtd " > Hi, we are slowly migrating the wiki pages to knowledge base articles due to various issues with the wiki. >Please, update your site or suggest any other weblink with the information. > Have a look at our docs page: https://libvirt.org/docs.html where you might find what you are looking for. There is a particular page about daemons here: https://libvirt.org/daemons.html >In theory CygWin use your package, but the information is incomplete too, >about this issue. > >I send this mail to these both Email address by the information displayed >in your wiki, about the contact address to solve this kind of problems. > Unfortunately I am not sure what are you trying to solve, so I don't know what clearer pointers to give you. >By now, Google Service in my region is deprecated, so the information that >the WebBrowser display is not the best. > >I send this request from my Email of Graduated Student form the University >domain. > >Best Regards, >Mr. Peláez Uriel. >Mexico City Have a nice day, Martin

1 0

[PATCH 0/3] IOMMU improvements
by Michal Privoznik 04 Jul '22

04 Jul '22

These are inspired by: https://bugzilla.redhat.com/show_bug.cgi?id=2101633 While there are some missing info to fix the actual but, I've noticed couple of areas for improvement while investigating the bug. Michal Prívozník (3): qemu_domain_address: Drop needless virDomainIOMMUModel typecast docs: Document <address/> for IOMMU device domain_validate: Disallow non-virtio IOMMU with an <address/> docs/formatdomain.rst | 3 +++ src/conf/domain_validate.c | 25 ++++++++++++++++++++++++- src/qemu/qemu_domain_address.c | 4 ++-- 3 files changed, 29 insertions(+), 3 deletions(-) -- 2.35.1

2 4

[libvirt PATCH] [pushed] Fix spelling
by Tim Wiederhake 04 Jul '22

04 Jul '22

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- docs/kbase/secureboot.rst | 2 +- src/qemu/qemu_migration.c | 2 +- src/rpc/virnetmessage.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/kbase/secureboot.rst b/docs/kbase/secureboot.rst index ebd9d56da8..8f151c1f2a 100644 --- a/docs/kbase/secureboot.rst +++ b/docs/kbase/secureboot.rst @@ -49,7 +49,7 @@ snippet: </os> Versions older than 7.2.0 require manually providing all information -about the firmware and are not covered here. Plese refer to `the +about the firmware and are not covered here. Please refer to `the relevant documentation <../formatdomain.html#operating-system-booting>`__ for details. diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 368995085f..9c3fd41761 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2726,7 +2726,7 @@ qemuMigrationAnyCanResume(virDomainObj *vm, /* This should never happen since POSTCOPY_RESUME is newer than * CHANGE_PROTECTION, but let's check it anyway in case we're talking to - * a weired client. + * a weird client. */ if (job == VIR_ASYNC_JOB_MIGRATION_OUT && expectedPhase < QEMU_MIGRATION_PHASE_PERFORM_RESUME && diff --git a/src/rpc/virnetmessage.c b/src/rpc/virnetmessage.c index d298d30d57..ceba1a5a8e 100644 --- a/src/rpc/virnetmessage.c +++ b/src/rpc/virnetmessage.c @@ -437,7 +437,7 @@ int virNetMessageDecodePayload(virNetMessage *msg, * virNetMessageEncodePayloadRaw: * @msg: message to encode payload into * @data: data to encode into @msg - * @len: lenght of @data + * @len: length of @data * * Encodes message payload. If @data is NULL or @len is 0 an empty message is * encoded. -- 2.36.1

1 0

[libvirt PATCH] conf: fix error message for wrong thread_pool_size
by Ján Tomko 01 Jul '22

01 Jul '22

Fix the copy-and-paste error by referring to the correct variable. Fixes: 0df2e7df80452f81edbfeb0ee355235b533346a9 https://bugzilla.redhat.com/show_bug.cgi?id=2103132 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index fb8bf4cfec..2c2f23242e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9949,7 +9949,7 @@ virDomainFSDefParseXML(virDomainXMLOption *xmlopt, virStrToLong_i(thread_pool_size, NULL, 10, &def->thread_pool_size) < 0) { virReportError(VIR_ERR_XML_ERROR, _("cannot parse thread pool size '%s' for virtiofs"), - queue_size); + thread_pool_size); goto error; } -- 2.35.3

1 0