[PATCH v2 0/3] ui: Remove deprecated sdl parameters and switch to QAPI parser
by Thomas Huth
The "-display sdl" option still uses a hand-crafted parser for its
parameters since some of them used underscores which is forbidden
in QAPI. Now that they've been deprecated and the deprecation period
is over, we can remove the problematic parameters and switch to use
the QAPI parser instead.
While we're at it, also remove the deprecated "-sdl" and "-curses" options.
v2:
- Rebase to current master branch to resolve conflicts in docs/about/*.rst
- Use an enum for the grab-mod parameter instead of a unconstrained string
Thomas Huth (3):
ui: Remove deprecated parameters of the "-display sdl" option
ui: Switch "-display sdl" to use the QAPI parser
ui: Remove deprecated options "-sdl" and "-curses"
docs/about/deprecated.rst | 26 -------
docs/about/removed-features.rst | 27 +++++++
qapi/ui.json | 27 ++++++-
include/sysemu/sysemu.h | 2 -
softmmu/globals.c | 2 -
softmmu/vl.c | 128 +-------------------------------
ui/sdl2.c | 10 +++
qemu-options.hx | 56 +-------------
8 files changed, 68 insertions(+), 210 deletions(-)
--
2.27.0
2 years, 6 months
[libvirt PATCH v4 00/11] Add QEMU "-display dbus" support
by marcandre.lureau＠redhat.com
From: Marc-André Lureau <marcandre.lureau(a)redhat.com>
Hi,
This series implements supports for the QEMU "-display dbus" support, available
since 7.0.
By default, libvirt will start a private VM bus (sharing and reusing the
existing "vmstate" VM bus & code).
The feature set should cover the needs to replace Spice as local client of choice,
including 3daccel/dmabuf, audio, clipboard sharing, usb redirection, and arbitrary
chardev/channels (for serial etc).
The test Gtk4 client is also in progress, currently in development at
https://gitlab.com/marcandre.lureau/qemu-display/. virt-viewer & boxes will need
a port to Gtk4 to make use of the shared widget.
thanks
v4:
- rebased, dropped some patches, updated versions in docs, code adjustments etc
- dropped clipboard option, as standalone qemu-vdagent support landed
v3: after QEMU 7.0 dev cycle opening and merge
- rebased
- add 7.0 x86-64 capabilities (instead of tweaking 6.2)
- fix version annotations
Marc-André Lureau (11):
qemu: add -display dbus capability check
conf: add <graphics type='dbus'>
qemu: start the D-Bus daemon for the display
qemu: add -display dbus support
virsh: report the D-Bus bus URI for domdisplay
conf: add <audio type='dbus'> support
qemu: add audio type 'dbus'
conf: add <serial type='dbus'>
qemu: add -chardev dbus support
qemu: add usbredir type 'dbus'
docs: document <graphics> type dbus
NEWS.rst | 5 +
docs/formatdomain.rst | 43 +++++-
src/bhyve/bhyve_command.c | 1 +
src/conf/domain_conf.c | 129 +++++++++++++++++-
src/conf/domain_conf.h | 14 ++
src/conf/domain_validate.c | 41 ++++--
src/conf/schemas/basictypes.rng | 7 +
src/conf/schemas/domaincommon.rng | 63 +++++++++
src/libxl/libxl_conf.c | 1 +
src/libxl/libxl_domain.c | 1 +
src/libxl/libxl_driver.c | 1 +
src/qemu/qemu_capabilities.c | 4 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_command.c | 65 ++++++++-
src/qemu/qemu_domain.c | 1 +
src/qemu/qemu_driver.c | 10 +-
src/qemu/qemu_extdevice.c | 13 ++
src/qemu/qemu_hotplug.c | 1 +
src/qemu/qemu_monitor_json.c | 10 ++
src/qemu/qemu_process.c | 41 +++++-
src/qemu/qemu_validate.c | 33 +++++
src/security/security_dac.c | 2 +
src/vmx/vmx.c | 1 +
.../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 1 +
.../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 +
.../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 +
tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 +
.../caps_7.0.0.x86_64.xml | 1 +
.../caps_7.1.0.x86_64.xml | 1 +
.../graphics-dbus-address.args | 30 ++++
.../graphics-dbus-address.xml | 35 +++++
.../qemuxml2argvdata/graphics-dbus-audio.args | 33 +++++
.../qemuxml2argvdata/graphics-dbus-audio.xml | 45 ++++++
.../graphics-dbus-chardev.args | 32 +++++
.../graphics-dbus-chardev.xml | 43 ++++++
tests/qemuxml2argvdata/graphics-dbus-p2p.args | 30 ++++
tests/qemuxml2argvdata/graphics-dbus-p2p.xml | 33 +++++
.../graphics-dbus-usbredir.args | 34 +++++
.../graphics-dbus-usbredir.xml | 30 ++++
tests/qemuxml2argvdata/graphics-dbus.args | 30 ++++
tests/qemuxml2argvdata/graphics-dbus.xml | 33 +++++
tests/qemuxml2argvtest.c | 17 +++
.../graphics-dbus-address.xml | 1 +
.../graphics-dbus-audio.xml | 1 +
.../graphics-dbus-chardev.xml | 1 +
.../qemuxml2xmloutdata/graphics-dbus-p2p.xml | 1 +
tests/qemuxml2xmloutdata/graphics-dbus.xml | 1 +
tests/qemuxml2xmltest.c | 17 +++
tests/testutilsqemu.c | 1 +
tools/virsh-domain.c | 24 +++-
52 files changed, 948 insertions(+), 20 deletions(-)
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-address.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-audio.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-chardev.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-p2p.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus-usbredir.xml
create mode 100644 tests/qemuxml2argvdata/graphics-dbus.args
create mode 100644 tests/qemuxml2argvdata/graphics-dbus.xml
create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-address.xml
create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-audio.xml
create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-chardev.xml
create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus-p2p.xml
create mode 120000 tests/qemuxml2xmloutdata/graphics-dbus.xml
--
2.36.1
2 years, 6 months
Plans for the next release
by Jiri Denemark
We are getting close to the next release of libvirt. To aim for the
release on June 01 I suggest entering the freeze on Wednesday May 25 in
the evening and tagging RC2 on Monday May 30.
I hope this works for everyone.
Jirka
2 years, 6 months
[PATCH 0/5] Some docs updates
by Han Han
Han Han (5):
docs: apps: Add desktop app gnome-boxes
docs: formatdomain: Add the introduced versions of net rss attrs
news: Add news for rss and rss_hash_report attributes
docs: drivers: Mention KVM/HVF in the link of qemu driver
docs: drvqemu: Fix the syntax typo of Hypervisor.framework link
NEWS.rst | 5 +++++
docs/apps.rst | 3 +++
docs/drivers.rst | 2 +-
docs/drvqemu.rst | 2 +-
docs/formatdomain.rst | 3 ++-
5 files changed, 12 insertions(+), 3 deletions(-)
--
2.35.1
2 years, 6 months
[PATCH] remoteOpenConn: Pass correct variable to virConnectSetIdentity()
by Michal Privoznik
The remoteOpenConn() function was refactored recently. As a part
of that new variable @newconn was introduced which holds
virConnect object as it's being gradually constructed throughout
the function. At the very end, when everything succeeded the
variable is stolen into passed @conn. However, there was one
line missed in the refactor which still access the @conn instead
of @newconn leading to a NULL dereference.
Fixes: f7c422993e4c7ca3e58b1d0d69f4772851af399f
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/remote/remote_daemon_dispatch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c
index c1f85925a3..0fde4233a5 100644
--- a/src/remote/remote_daemon_dispatch.c
+++ b/src/remote/remote_daemon_dispatch.c
@@ -1829,7 +1829,7 @@ remoteOpenConn(const char *uri,
VIR_DEBUG("Opened driver %p", newconn);
if (preserveIdentity) {
- if (virConnectSetIdentity(*conn, identparams->par, identparams->npar, 0) < 0)
+ if (virConnectSetIdentity(newconn, identparams->par, identparams->npar, 0) < 0)
return -1;
VIR_DEBUG("Forwarded current identity to secondary driver");
--
2.35.1
2 years, 6 months
[PATCH 00/16] New update from 6.9 to 7.8
by Han Han
Han Han (16):
news: make SEV attrs 'cbitpos' & 'reducedPhysBits' optional
news: support device stats collection for SR-IOV VF hostdev
news: cpu_map: Add EPYC-Rome cpu model
news: cpu: Support for XML validation in cpu comparison
news: logging: allow max_len=0 to disable log rollover
news: qemu: Set noqueue qdisc for TAP devices
news: qemu: Introduce virtio free page reporting feature
news: qemu: virtiofs can be used without NUMA nodes
news: qemu: Add 'fmode' and 'dmode' options for 9pfs
news: Introduce "migrate_tls_force" to qemu.conf
news: qemu: support kvm-poll-control performance hint
news: cpu_map: Add Snowridge cpu model
news: qemu: Add support for NFS disk protocol
news: Support vhostuser in virsh attach-interface since v7.7.0
news: Add queue_size option to virtio disk
news: Validation flags for creating net, nwfilter-binding, net port
NEWS.rst | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 89 insertions(+)
--
2.36.0
2 years, 6 months
[libvirt PATCH v3 0/6] Add support for 'blob' to virtio video device
by Jonathon Jongsma
Add support to libvirt for the 'blob' option for virtio video devices in qemu.
Also do a little preparatory refactoring of the video device xml parsing code.
I sent this series out a couple months ago but didn't get any review. Sending
out again after rebasing to current master branch.
changes in v3:
- rebased to latest master
Changes in v2:
- Added some basic documentation
- add a qemu capability
- Make sure that the /dev/udmabuf device is accessible to qemu (cgroups, etc)
Jonathon Jongsma (6):
conf: Refactor video model parsing
conf: switch to virXMLProp* functions
conf: use enum variable for video type
conf: add support for 'blob' in virtio video device
qemu: Add capability for virtio-gpu.blob
qemu: Implement 'blob' support for virtio gpu
docs/formatdomain.rst | 6 +
src/conf/domain_conf.c | 133 +++++++++---------
src/conf/domain_conf.h | 3 +-
src/conf/domain_validate.c | 13 +-
src/conf/schemas/domaincommon.rng | 5 +
src/libxl/libxl_conf.c | 10 ++
src/libxl/libxl_domain.c | 11 ++
src/qemu/qemu_capabilities.c | 2 +
src/qemu/qemu_capabilities.h | 1 +
src/qemu/qemu_cgroup.c | 22 ++-
src/qemu/qemu_command.c | 3 +
src/qemu/qemu_domain.h | 1 +
src/qemu/qemu_monitor_json.c | 16 ++-
src/qemu/qemu_namespace.c | 22 +++
src/qemu/qemu_process.c | 7 +
src/qemu/qemu_validate.c | 9 ++
.../caps_6.1.0.x86_64.xml | 1 +
.../caps_6.2.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_6.2.0.ppc64.xml | 1 +
.../caps_6.2.0.x86_64.xml | 1 +
.../caps_7.0.0.aarch64.xml | 1 +
.../qemucapabilitiesdata/caps_7.0.0.ppc64.xml | 1 +
.../caps_7.0.0.x86_64.xml | 1 +
.../caps_7.1.0.x86_64.xml | 1 +
.../video-virtio-blob-absent.args | 34 +++++
.../video-virtio-blob-absent.xml | 33 +++++
.../video-virtio-blob-off.args | 34 +++++
.../video-virtio-blob-off.xml | 33 +++++
.../video-virtio-blob-on.args | 34 +++++
.../qemuxml2argvdata/video-virtio-blob-on.xml | 33 +++++
.../video-virtio-vga-blob-on.args | 34 +++++
.../video-virtio-vga-blob-on.xml | 33 +++++
tests/qemuxml2argvtest.c | 12 ++
.../video-virtio-blob-absent.xml | 41 ++++++
.../video-virtio-blob-off.xml | 41 ++++++
.../video-virtio-blob-on.xml | 41 ++++++
.../video-virtio-vga-blob-on.xml | 41 ++++++
tests/qemuxml2xmltest.c | 12 ++
38 files changed, 647 insertions(+), 81 deletions(-)
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-absent.xml
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-off.xml
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-blob-on.xml
create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-blob-on.args
create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-blob-on.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-absent.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-off.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-blob-on.xml
create mode 100644 tests/qemuxml2xmloutdata/video-virtio-vga-blob-on.xml
--
2.35.1
2 years, 6 months
CFP Reminder: KVM Forum 2022
by Peter Maydell
================================================================
KVM Forum 2022
September 12-14, 2022
Dublin, Ireland & Virtual
All submissions must be received before
*** Friday June 3rd, 2022 at 23:59 PDT ***
================================================================
KVM Forum is an annual event that presents a rare opportunity for
developers and users to discuss the state of Linux virtualization
technology and plan for the challenges ahead. This highly technical
conference unites the developers who drive KVM development and the
users who depend on KVM as part of their offerings, or to power
their data centers and clouds. Sessions include updates on the state
of the KVM virtualization stack, planning for the future, and many
opportunities for attendees to collaborate. Over the years since
its inclusion in the mainline kernel, KVM has become a critical part
of the FOSS cloud infrastructure. Come join us in continuing to
improve the KVM ecosystem.
This year's event is in Dublin, Ireland, but it is a combined
physical+virtual conference: both speaking and attending can be
virtual if you prefer. For more details, registration, travel
and health and safety information, visit:
https://events.linuxfoundation.org/kvm-forum/
For more information, some suggested topics, and to submit
proposals, please see:
https://events.linuxfoundation.org/kvm-forum/program/cfp/
We encourage you to submit and reach out to us should you have any
questions. The program committee may be contacted as a group via
email: kvm-forum-2022-pc(a)redhat.com.
Apologies from the Program Committee for not posting an
announcement of the CFP to these lists sooner.
2 years, 6 months
[PATCH 0/4] virIdentity: Don't leak params in virGetConnectGeneric and refactor
by Peter Krempa
Fix a memleak and make the code a bit neater.
Peter Krempa (4):
util: typedparam: Introduce virTypedParamListFromParams
virGetConnectGeneric: Fix memleak of 'identparams' when connecting
between split daemons
virIdentityGetParameters: Return 'virTypedParamList'
doRemoteOpen: Refactor control flow
src/driver.c | 8 +++----
src/libvirt_private.syms | 1 +
src/remote/remote_daemon_dispatch.c | 36 ++++++++++++-----------------
src/util/viridentity.c | 15 ++++--------
src/util/viridentity.h | 5 ++--
src/util/virtypedparam.c | 13 +++++++++++
src/util/virtypedparam.h | 4 ++++
7 files changed, 44 insertions(+), 38 deletions(-)
--
2.35.3
2 years, 6 months
[libvirt PATCH] util: Do not report useless error in virPortAllocatorRelease
by Jiri Denemark
If the port allocator bitmap does not have enough bits to keep the state
of the port we're going to release, the port is not reserved and thus is
trivially released without doing anything. No need to report an error in
such case.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
src/util/virportallocator.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c
index 44edd8f99a..97ab362749 100644
--- a/src/util/virportallocator.c
+++ b/src/util/virportallocator.c
@@ -254,12 +254,7 @@ virPortAllocatorRelease(unsigned short port)
return 0;
VIR_WITH_OBJECT_LOCK_GUARD(pa) {
- if (virBitmapClearBit(pa->bitmap, port) < 0) {
- virReportError(VIR_ERR_INTERNAL_ERROR,
- _("Failed to release port %d"),
- port);
- return -1;
- }
+ ignore_value(virBitmapClearBit(pa->bitmap, port));
}
return 0;
--
2.35.1
2 years, 6 months
