March 2021 - Devel - libvirt List Archives

[PATCH v2] target/mips: Deprecate Trap-and-Emul KVM support
by Jiaxun Yang 22 Mar '21

22 Mar '21

Upstream kernel had removed both host[1] and guest[2] support. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=4… [2]: https://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git/commit/?id=a… Signed-off-by: Jiaxun Yang <jiaxun.yang(a)flygoat.com> Signed-off-by: Jiaxun Yang <jiaxun.yang(a)flygoat.com> --- v2: Fix up tittle and sphinx format (f4bug) Lost in the sea of emails :-) --- docs/system/deprecated.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 5e3a31c123..9286cdd475 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -292,6 +292,15 @@ The ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, and ``acl_remove`` commands are deprecated with no replacement. Authorization for VNC should be performed using the pluggable QAuthZ objects. +System accelerators +------------------- + +MIPS ``Trap-and-Emul`` KVM support (since 6.0) +'''''''''''''''''''''''''''''''''''''''''''''' + +The MIPS ``Trap-and-Emul`` KVM host and guest support has been removed +from upstream kernel, declare it deprecated. + System emulator CPUS -------------------- -- 2.30.2

2 2

[libvirt PATCH 0/7] Change reallocation APIs to return void
by Jiri Denemark 22 Mar '21

22 Mar '21

2 8

[libvirt PATCH 0/2] qemu: Use g_auto* in a few more places
by Jiri Denemark 22 Mar '21

22 Mar '21

I'll be touching these functions soon, let's modernize them first. Jiri Denemark (2): qemu: Use g_autofree in qemuMigrationJobCheckStatus qemu: Use g_autoptr in qemuMonitorJSONSetCapabilities src/qemu/qemu_migration.c | 15 +++++---------- src/qemu/qemu_monitor_json.c | 19 ++++++++----------- 2 files changed, 13 insertions(+), 21 deletions(-) -- 2.31.0

2 3

[libvirt PATCH] qemu: Drop redundant checks for qemuCaps before virQEMUCapsGet
by Jiri Denemark 22 Mar '21

22 Mar '21

virQEMUCapsGet checks for qemuCaps itself, no need to do it explicitly. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_domain.c | 5 +---- src/qemu/qemu_process.c | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 5c98f8ff1a..fff67481a7 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5289,7 +5289,6 @@ qemuDomainDeviceDiskDefPostParseRestoreSecAlias(virDomainDiskDefPtr disk, g_autofree char *encalias = NULL; if (!(parseFlags & VIR_DOMAIN_DEF_PARSE_STATUS) || - !qemuCaps || virStorageSourceIsEmpty(disk->src) || !virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_SECRET)) return 0; @@ -5475,7 +5474,6 @@ qemuDomainDeviceHostdevDefPostParseRestoreSecAlias(virDomainHostdevDefPtr hostde g_autofree char *authalias = NULL; if (!(parseFlags & VIR_DOMAIN_DEF_PARSE_STATUS) || - !qemuCaps || !virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_SECRET)) return 0; @@ -5520,8 +5518,7 @@ qemuDomainDeviceHostdevDefPostParseRestoreBackendAlias(virDomainHostdevDefPtr ho if (!(parseFlags & VIR_DOMAIN_DEF_PARSE_STATUS)) return 0; - if (!qemuCaps || - hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS || + if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS || hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI || !virQEMUCapsGet(qemuCaps, QEMU_CAPS_BLOCKDEV_HOSTDEV_SCSI)) return 0; diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 0b79dde2c3..b86afe4daa 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8349,8 +8349,7 @@ qemuProcessReconnect(void *opaque) if (qemuHostdevUpdateActiveDomainDevices(driver, obj->def) < 0) goto error; - if (priv->qemuCaps && - virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_CHARDEV_FD_PASS)) + if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_CHARDEV_FD_PASS)) retry = false; if (qemuDomainObjStartWorker(obj) < 0) -- 2.31.0

2 1

[libvirt PATCH] ci: Drop prefix from Dockerfiles
by Andrea Bolognani 22 Mar '21

22 Mar '21

Since the string "ci" is already contained in the path, it seems unnecessary to include it into the filename too: in fact, we only do that for Dockerfiles and not for files in ci/cirrus, even though those are generated the very same way. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitlab-ci.yml | 2 +- ci/containers/{ci-centos-7.Dockerfile => centos-7.Dockerfile} | 0 ci/containers/{ci-centos-8.Dockerfile => centos-8.Dockerfile} | 0 .../{ci-centos-stream.Dockerfile => centos-stream.Dockerfile} | 0 ...-aarch64.Dockerfile => debian-10-cross-aarch64.Dockerfile} | 0 ...ss-armv6l.Dockerfile => debian-10-cross-armv6l.Dockerfile} | 0 ...ss-armv7l.Dockerfile => debian-10-cross-armv7l.Dockerfile} | 0 ...-cross-i686.Dockerfile => debian-10-cross-i686.Dockerfile} | 0 ...-cross-mips.Dockerfile => debian-10-cross-mips.Dockerfile} | 0 ...ips64el.Dockerfile => debian-10-cross-mips64el.Dockerfile} | 0 ...ss-mipsel.Dockerfile => debian-10-cross-mipsel.Dockerfile} | 0 ...-ppc64le.Dockerfile => debian-10-cross-ppc64le.Dockerfile} | 0 ...ross-s390x.Dockerfile => debian-10-cross-s390x.Dockerfile} | 0 .../{ci-debian-10.Dockerfile => debian-10.Dockerfile} | 0 ...aarch64.Dockerfile => debian-sid-cross-aarch64.Dockerfile} | 0 ...s-armv6l.Dockerfile => debian-sid-cross-armv6l.Dockerfile} | 0 ...s-armv7l.Dockerfile => debian-sid-cross-armv7l.Dockerfile} | 0 ...cross-i686.Dockerfile => debian-sid-cross-i686.Dockerfile} | 0 ...ps64el.Dockerfile => debian-sid-cross-mips64el.Dockerfile} | 0 ...s-mipsel.Dockerfile => debian-sid-cross-mipsel.Dockerfile} | 0 ...ppc64le.Dockerfile => debian-sid-cross-ppc64le.Dockerfile} | 0 ...oss-s390x.Dockerfile => debian-sid-cross-s390x.Dockerfile} | 0 .../{ci-debian-sid.Dockerfile => debian-sid.Dockerfile} | 0 .../{ci-fedora-32.Dockerfile => fedora-32.Dockerfile} | 0 .../{ci-fedora-33.Dockerfile => fedora-33.Dockerfile} | 0 ...w32.Dockerfile => fedora-rawhide-cross-mingw32.Dockerfile} | 0 ...w64.Dockerfile => fedora-rawhide-cross-mingw64.Dockerfile} | 0 ...ci-fedora-rawhide.Dockerfile => fedora-rawhide.Dockerfile} | 0 .../{ci-opensuse-152.Dockerfile => opensuse-152.Dockerfile} | 0 .../{ci-ubuntu-1804.Dockerfile => ubuntu-1804.Dockerfile} | 0 .../{ci-ubuntu-2004.Dockerfile => ubuntu-2004.Dockerfile} | 0 ci/helper | 4 ++-- 32 files changed, 3 insertions(+), 3 deletions(-) rename ci/containers/{ci-centos-7.Dockerfile => centos-7.Dockerfile} (100%) rename ci/containers/{ci-centos-8.Dockerfile => centos-8.Dockerfile} (100%) rename ci/containers/{ci-centos-stream.Dockerfile => centos-stream.Dockerfile} (100%) rename ci/containers/{ci-debian-10-cross-aarch64.Dockerfile => debian-10-cross-aarch64.Dockerfile} (100%) rename ci/containers/{ci-debian-10-cross-armv6l.Dockerfile => debian-10-cross-armv6l.Dockerfile} (100%) rename ci/containers/{ci-debian-10-cross-armv7l.Dockerfile => debian-10-cross-armv7l.Dockerfile} (100%) rename ci/containers/{ci-debian-10-cross-i686.Dockerfile => debian-10-cross-i686.Dockerfile} (100%) rename ci/containers/{ci-debian-10-cross-mips.Dockerfile => debian-10-cross-mips.Dockerfile} (100%) rename ci/containers/{ci-debian-10-cross-mips64el.Dockerfile => debian-10-cross-mips64el.Dockerfile} (100%) rename ci/containers/{ci-debian-10-cross-mipsel.Dockerfile => debian-10-cross-mipsel.Dockerfile} (100%) rename ci/containers/{ci-debian-10-cross-ppc64le.Dockerfile => debian-10-cross-ppc64le.Dockerfile} (100%) rename ci/containers/{ci-debian-10-cross-s390x.Dockerfile => debian-10-cross-s390x.Dockerfile} (100%) rename ci/containers/{ci-debian-10.Dockerfile => debian-10.Dockerfile} (100%) rename ci/containers/{ci-debian-sid-cross-aarch64.Dockerfile => debian-sid-cross-aarch64.Dockerfile} (100%) rename ci/containers/{ci-debian-sid-cross-armv6l.Dockerfile => debian-sid-cross-armv6l.Dockerfile} (100%) rename ci/containers/{ci-debian-sid-cross-armv7l.Dockerfile => debian-sid-cross-armv7l.Dockerfile} (100%) rename ci/containers/{ci-debian-sid-cross-i686.Dockerfile => debian-sid-cross-i686.Dockerfile} (100%) rename ci/containers/{ci-debian-sid-cross-mips64el.Dockerfile => debian-sid-cross-mips64el.Dockerfile} (100%) rename ci/containers/{ci-debian-sid-cross-mipsel.Dockerfile => debian-sid-cross-mipsel.Dockerfile} (100%) rename ci/containers/{ci-debian-sid-cross-ppc64le.Dockerfile => debian-sid-cross-ppc64le.Dockerfile} (100%) rename ci/containers/{ci-debian-sid-cross-s390x.Dockerfile => debian-sid-cross-s390x.Dockerfile} (100%) rename ci/containers/{ci-debian-sid.Dockerfile => debian-sid.Dockerfile} (100%) rename ci/containers/{ci-fedora-32.Dockerfile => fedora-32.Dockerfile} (100%) rename ci/containers/{ci-fedora-33.Dockerfile => fedora-33.Dockerfile} (100%) rename ci/containers/{ci-fedora-rawhide-cross-mingw32.Dockerfile => fedora-rawhide-cross-mingw32.Dockerfile} (100%) rename ci/containers/{ci-fedora-rawhide-cross-mingw64.Dockerfile => fedora-rawhide-cross-mingw64.Dockerfile} (100%) rename ci/containers/{ci-fedora-rawhide.Dockerfile => fedora-rawhide.Dockerfile} (100%) rename ci/containers/{ci-opensuse-152.Dockerfile => opensuse-152.Dockerfile} (100%) rename ci/containers/{ci-ubuntu-1804.Dockerfile => ubuntu-1804.Dockerfile} (100%) rename ci/containers/{ci-ubuntu-2004.Dockerfile => ubuntu-2004.Dockerfile} (100%) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 81a4e80fd8..a059ad229c 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -31,7 +31,7 @@ stages: - docker login registry.gitlab.com -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD" script: - docker pull "$TAG" || docker pull "$COMMON_TAG" || true - - docker build --cache-from "$TAG" --cache-from "$COMMON_TAG" --tag "$TAG" -f "ci/containers/ci-$NAME.Dockerfile" ci/containers + - docker build --cache-from "$TAG" --cache-from "$COMMON_TAG" --tag "$TAG" -f "ci/containers/$NAME.Dockerfile" ci/containers - docker push "$TAG" after_script: - docker logout diff --git a/ci/containers/ci-centos-7.Dockerfile b/ci/containers/centos-7.Dockerfile similarity index 100% rename from ci/containers/ci-centos-7.Dockerfile rename to ci/containers/centos-7.Dockerfile diff --git a/ci/containers/ci-centos-8.Dockerfile b/ci/containers/centos-8.Dockerfile similarity index 100% rename from ci/containers/ci-centos-8.Dockerfile rename to ci/containers/centos-8.Dockerfile diff --git a/ci/containers/ci-centos-stream.Dockerfile b/ci/containers/centos-stream.Dockerfile similarity index 100% rename from ci/containers/ci-centos-stream.Dockerfile rename to ci/containers/centos-stream.Dockerfile diff --git a/ci/containers/ci-debian-10-cross-aarch64.Dockerfile b/ci/containers/debian-10-cross-aarch64.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10-cross-aarch64.Dockerfile rename to ci/containers/debian-10-cross-aarch64.Dockerfile diff --git a/ci/containers/ci-debian-10-cross-armv6l.Dockerfile b/ci/containers/debian-10-cross-armv6l.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10-cross-armv6l.Dockerfile rename to ci/containers/debian-10-cross-armv6l.Dockerfile diff --git a/ci/containers/ci-debian-10-cross-armv7l.Dockerfile b/ci/containers/debian-10-cross-armv7l.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10-cross-armv7l.Dockerfile rename to ci/containers/debian-10-cross-armv7l.Dockerfile diff --git a/ci/containers/ci-debian-10-cross-i686.Dockerfile b/ci/containers/debian-10-cross-i686.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10-cross-i686.Dockerfile rename to ci/containers/debian-10-cross-i686.Dockerfile diff --git a/ci/containers/ci-debian-10-cross-mips.Dockerfile b/ci/containers/debian-10-cross-mips.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10-cross-mips.Dockerfile rename to ci/containers/debian-10-cross-mips.Dockerfile diff --git a/ci/containers/ci-debian-10-cross-mips64el.Dockerfile b/ci/containers/debian-10-cross-mips64el.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10-cross-mips64el.Dockerfile rename to ci/containers/debian-10-cross-mips64el.Dockerfile diff --git a/ci/containers/ci-debian-10-cross-mipsel.Dockerfile b/ci/containers/debian-10-cross-mipsel.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10-cross-mipsel.Dockerfile rename to ci/containers/debian-10-cross-mipsel.Dockerfile diff --git a/ci/containers/ci-debian-10-cross-ppc64le.Dockerfile b/ci/containers/debian-10-cross-ppc64le.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10-cross-ppc64le.Dockerfile rename to ci/containers/debian-10-cross-ppc64le.Dockerfile diff --git a/ci/containers/ci-debian-10-cross-s390x.Dockerfile b/ci/containers/debian-10-cross-s390x.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10-cross-s390x.Dockerfile rename to ci/containers/debian-10-cross-s390x.Dockerfile diff --git a/ci/containers/ci-debian-10.Dockerfile b/ci/containers/debian-10.Dockerfile similarity index 100% rename from ci/containers/ci-debian-10.Dockerfile rename to ci/containers/debian-10.Dockerfile diff --git a/ci/containers/ci-debian-sid-cross-aarch64.Dockerfile b/ci/containers/debian-sid-cross-aarch64.Dockerfile similarity index 100% rename from ci/containers/ci-debian-sid-cross-aarch64.Dockerfile rename to ci/containers/debian-sid-cross-aarch64.Dockerfile diff --git a/ci/containers/ci-debian-sid-cross-armv6l.Dockerfile b/ci/containers/debian-sid-cross-armv6l.Dockerfile similarity index 100% rename from ci/containers/ci-debian-sid-cross-armv6l.Dockerfile rename to ci/containers/debian-sid-cross-armv6l.Dockerfile diff --git a/ci/containers/ci-debian-sid-cross-armv7l.Dockerfile b/ci/containers/debian-sid-cross-armv7l.Dockerfile similarity index 100% rename from ci/containers/ci-debian-sid-cross-armv7l.Dockerfile rename to ci/containers/debian-sid-cross-armv7l.Dockerfile diff --git a/ci/containers/ci-debian-sid-cross-i686.Dockerfile b/ci/containers/debian-sid-cross-i686.Dockerfile similarity index 100% rename from ci/containers/ci-debian-sid-cross-i686.Dockerfile rename to ci/containers/debian-sid-cross-i686.Dockerfile diff --git a/ci/containers/ci-debian-sid-cross-mips64el.Dockerfile b/ci/containers/debian-sid-cross-mips64el.Dockerfile similarity index 100% rename from ci/containers/ci-debian-sid-cross-mips64el.Dockerfile rename to ci/containers/debian-sid-cross-mips64el.Dockerfile diff --git a/ci/containers/ci-debian-sid-cross-mipsel.Dockerfile b/ci/containers/debian-sid-cross-mipsel.Dockerfile similarity index 100% rename from ci/containers/ci-debian-sid-cross-mipsel.Dockerfile rename to ci/containers/debian-sid-cross-mipsel.Dockerfile diff --git a/ci/containers/ci-debian-sid-cross-ppc64le.Dockerfile b/ci/containers/debian-sid-cross-ppc64le.Dockerfile similarity index 100% rename from ci/containers/ci-debian-sid-cross-ppc64le.Dockerfile rename to ci/containers/debian-sid-cross-ppc64le.Dockerfile diff --git a/ci/containers/ci-debian-sid-cross-s390x.Dockerfile b/ci/containers/debian-sid-cross-s390x.Dockerfile similarity index 100% rename from ci/containers/ci-debian-sid-cross-s390x.Dockerfile rename to ci/containers/debian-sid-cross-s390x.Dockerfile diff --git a/ci/containers/ci-debian-sid.Dockerfile b/ci/containers/debian-sid.Dockerfile similarity index 100% rename from ci/containers/ci-debian-sid.Dockerfile rename to ci/containers/debian-sid.Dockerfile diff --git a/ci/containers/ci-fedora-32.Dockerfile b/ci/containers/fedora-32.Dockerfile similarity index 100% rename from ci/containers/ci-fedora-32.Dockerfile rename to ci/containers/fedora-32.Dockerfile diff --git a/ci/containers/ci-fedora-33.Dockerfile b/ci/containers/fedora-33.Dockerfile similarity index 100% rename from ci/containers/ci-fedora-33.Dockerfile rename to ci/containers/fedora-33.Dockerfile diff --git a/ci/containers/ci-fedora-rawhide-cross-mingw32.Dockerfile b/ci/containers/fedora-rawhide-cross-mingw32.Dockerfile similarity index 100% rename from ci/containers/ci-fedora-rawhide-cross-mingw32.Dockerfile rename to ci/containers/fedora-rawhide-cross-mingw32.Dockerfile diff --git a/ci/containers/ci-fedora-rawhide-cross-mingw64.Dockerfile b/ci/containers/fedora-rawhide-cross-mingw64.Dockerfile similarity index 100% rename from ci/containers/ci-fedora-rawhide-cross-mingw64.Dockerfile rename to ci/containers/fedora-rawhide-cross-mingw64.Dockerfile diff --git a/ci/containers/ci-fedora-rawhide.Dockerfile b/ci/containers/fedora-rawhide.Dockerfile similarity index 100% rename from ci/containers/ci-fedora-rawhide.Dockerfile rename to ci/containers/fedora-rawhide.Dockerfile diff --git a/ci/containers/ci-opensuse-152.Dockerfile b/ci/containers/opensuse-152.Dockerfile similarity index 100% rename from ci/containers/ci-opensuse-152.Dockerfile rename to ci/containers/opensuse-152.Dockerfile diff --git a/ci/containers/ci-ubuntu-1804.Dockerfile b/ci/containers/ubuntu-1804.Dockerfile similarity index 100% rename from ci/containers/ci-ubuntu-1804.Dockerfile rename to ci/containers/ubuntu-1804.Dockerfile diff --git a/ci/containers/ci-ubuntu-2004.Dockerfile b/ci/containers/ubuntu-2004.Dockerfile similarity index 100% rename from ci/containers/ci-ubuntu-2004.Dockerfile rename to ci/containers/ubuntu-2004.Dockerfile diff --git a/ci/helper b/ci/helper index 7032c816d5..2c3a9f8db4 100755 --- a/ci/helper +++ b/ci/helper @@ -197,11 +197,11 @@ class Application: def _generate_dockerfile(self, host, cross=None): args = ["dockerfile", host, "libvirt"] outdir = self._basedir.joinpath("containers") - outfile = f"ci-{host}.Dockerfile" + outfile = f"{host}.Dockerfile" if cross: args.extend(["--cross", cross]) - outfile = f"ci-{host}-cross-{cross}.Dockerfile" + outfile = f"{host}-cross-{cross}.Dockerfile" outpath = outdir.joinpath(outfile) if not self._args.quiet: -- 2.26.3

2 1

[PATCH 0/3] qemu: Enable virDomainBackupBegin for full backups
by Peter Krempa 19 Mar '21

19 Mar '21

Peter Krempa (3): qemu: capabilities: Introduce QEMU_CAPS_BLOCKDEV_BACKUP qemu: backup: Enable full backup support NEWS: Mention support for full backups via virDomainBackupBegin NEWS.rst | 9 ++++++ src/qemu/qemu_backup.c | 28 +++++++++++++++---- src/qemu/qemu_capabilities.c | 7 ++++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_domain.c | 3 -- .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../caps_5.2.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + 20 files changed, 54 insertions(+), 9 deletions(-) -- 2.29.2

3 5

[libvirt PATCH v2 00/51] Refactor XML parsing boilerplate code
by Tim Wiederhake 19 Mar '21

19 Mar '21

This series replaces some recurring boilerplate code in src/conf/ regarding the extraction of a virTristate(Switch|Bool) XML attribute. The boilerplate code looks roughly like this, g_autofree char *str = NULL; if (str = virXMLPropString(node, ...)) { int val; if ((val = virTristateBoolTypeFromString(str)) <= 0) { virReportError(...) return -1; } def->... = val; } with some variations regarding how `str` is free'd in case of later re-use, the exact error message for invalid values, whether or not `VIR_TRISTATE_(SWITCH|BOOL)_ABSENT` is explicitly checked for (`val < 0` vs. `val <= 0`), whether an intermediate variable is used or the value is assigned directly, and in some cases the conditions in the two if-blocks are merged. As a side effect, this makes the error messages for invalid values in these attributes much more consistent and catches some instances where e.g. `<foo bar="default"/>` would incorrectly be accepted. V1: https://listman.redhat.com/archives/libvir-list/2021-March/msg00853.html Changes since V1: * Rebased (resolved conflict) * Added functions to libvirt_private.syms * Patch "virStorageAdapterFCHost: Fix comment" became obsolete * Changed some member variable types to virTristate(Bool|Switch), that cleaned up the actual conversions significantly * Applied the feedback regarding the new functions in virxml Tim Wiederhake (51): conf: Use virTristateXXX in virStorageSource conf: Use virTristateXXX in virStorageSourceNVMeDef conf: Use virTristateXXX in virDomainDeviceInfo conf: Use virTristateXXX in virDomainDiskDef conf: Use virTristateXXX in virDomainActualNetDef conf: Use virTristateXXX in virDomainNetDef conf: Use virTristateXXX in virDomainChrSourceDef conf: Use virTristateXXX in virDomainGraphicsDef conf: Use virTristateXXX in virDomainMemballoonDef conf: Use virTristateXXX in virDomainLoaderDef conf: Use virTristateXXX in virDomainDef conf: Use virTristateXXX in virStorageAdapterFCHost conf: Use virTristateXXX in virStoragePoolSourceDevice conf: Use virTristateXXX in virPCIDeviceAddress virxml: Add virXMLPropTristateBool virxml: Add virXMLPropTristateSwitch domain_conf: Use virXMLPropTristateXXX in virDomainKeyWrapCipherDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainVirtioOptionsParseXML domain_conf: Use virXMLPropTristateXXX in virDomainDeviceInfoParseXML domain_conf: Use virXMLPropTristateXXX in virDomainDiskSourceNetworkParse domain_conf: Use virXMLPropTristateXXX in virDomainDiskSourceNVMeParse domain_conf: Use virXMLPropTristateXXX in virDomainDiskDefDriverParseXML domain_conf: Use virXMLPropTristateXXX in virDomainActualNetDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceReconnectDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainNetDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseTCP domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseFile domain_conf: Use virXMLPropTristateXXX in virDomainChrSourceDefParseLog domain_conf: Use virXMLPropTristateXXX in virDomainGraphicsDefParseXMLVNC domain_conf: Use virXMLPropTristateXXX in virDomainGraphicsDefParseXMLSDL domain_conf: Use virXMLPropTristateXXX in virDomainGraphicsDefParseXMLSpice domain_conf: Use virXMLPropTristateXXX in virDomainAudioCommonParse domain_conf: Use virXMLPropTristateXXX in virDomainAudioJackParse domain_conf: Use virXMLPropTristateXXX in virDomainAudioOSSParse domain_conf: Use virXMLPropTristateXXX in virDomainAudioDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainMemballoonDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainShmemDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainPerfEventDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainMemoryDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainIOMMUDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainVsockDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainFeaturesDefParse domain_conf: Use virXMLPropTristateXXX in virDomainLoaderDefParseXML domain_conf: Use virXMLPropTristateXXX in virDomainVcpuParse backup_conf: Use virXMLPropTristateXXX in virDomainBackupDiskDefParseXML backup_conf: Use virXMLPropTristateXXX in virDomainBackupDefParse device_conf: Use virXMLPropTristateXXX in virPCIDeviceAddressParseXML network_conf: Use virXMLPropTristateXXX in virNetworkForwardNatDefParseXML numa_conf: Use virXMLPropTristateXXX in virDomainNumaDefParseXML storage_adapter_conf: Use virXMLPropTristateXXX in virStorageAdapterParseXMLFCHost storage_conf: Use virXMLPropTristateXXX in virStoragePoolDefParseSource src/conf/backup_conf.c | 32 +- src/conf/device_conf.c | 8 +- src/conf/device_conf.h | 4 +- src/conf/domain_conf.c | 795 +++++++------------------------- src/conf/domain_conf.h | 28 +- src/conf/network_conf.c | 15 +- src/conf/numa_conf.c | 14 +- src/conf/storage_adapter_conf.c | 14 +- src/conf/storage_adapter_conf.h | 2 +- src/conf/storage_conf.c | 17 +- src/conf/storage_conf.h | 2 +- src/conf/storage_source_conf.h | 4 +- src/libvirt_private.syms | 2 + src/qemu/qemu_command.c | 3 +- src/qemu/qemu_hotplug.c | 2 +- src/util/virpci.h | 2 +- src/util/virxml.c | 82 ++++ src/util/virxml.h | 9 + 18 files changed, 302 insertions(+), 733 deletions(-) -- 2.26.2

2 54

[PATCH 0/3] Add event for hypervisor faults and implement it for qemu
by Peter Krempa 19 Mar '21

19 Mar '21

Peter Krempa (3): qemuMonitorJSONGetStatus: Refactor cleanup API: Add VIR_DOMAIN_PAUSED_HYPERVISOR_FAULT enum value qemu: Update paused reason on unexpected 'STOP' event examples/c/misc/event-test.c | 3 +++ include/libvirt/libvirt-domain.h | 2 ++ src/conf/domain_conf.c | 1 + src/qemu/qemu_domain.c | 4 ++++ src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 37 ++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 4 +++- src/qemu/qemu_monitor_json.c | 18 ++++++---------- src/qemu/qemu_process.c | 22 ++++++++++++++++--- tools/virsh-domain-monitor.c | 1 + tools/virsh-domain.c | 3 ++- 11 files changed, 79 insertions(+), 17 deletions(-) -- 2.29.2

2 6

[libvirt PATCH v4 0/6] ci: helper: Rewrite image listing in Python and add stale Docker image checker
by Erik Skultety 19 Mar '21

19 Mar '21

since v3: - more formatting changes as requested per review comments - get_registry_stale_images was simplified according to the comments - class attributes were also converted to private in [6/6] v1: https://listman.redhat.com/archives/libvir-list/2021-February/msg00641.ht= ml v2: https://listman.redhat.com/archives/libvir-list/2021-March/msg00789.html v3: https://listman.redhat.com/archives/libvir-list/2021-March/msg00892.html Erik Skultety (6): ci: helper: Use the ArgumentDefaultsHelpFormatter help formatter ci: helper: Introduce --quiet ci: Introduce a util module ci: helper: Rewrite image listing to Python ci: util: Add a registry checker for stale images ci: helper: Apply Python naming practice to private methods/attributes ci/Makefile | 12 --- ci/helper | 203 +++++++++++++++++++++++++++++++++------------- ci/list-images.sh | 14 ---- ci/util.py | 81 ++++++++++++++++++ 4 files changed, 229 insertions(+), 81 deletions(-) delete mode 100644 ci/list-images.sh create mode 100644 ci/util.py --=20 2.30.2

2 9

[PATCH] qemu: backup: Restore security label on backup disk store image on VM termination
by Peter Krempa 19 Mar '21

19 Mar '21

When the backup job is terminated normally the security label is restored by the blockjob finishing handler. If the VM dies or is destroyed that wouldn't happen as the blockjob handler wouldn't be called. Restore the security label on disk store where we remember that the job was running at the point when 'qemuBackupJobTerminate' was called. Not resetting the security label means that we also leak the xattr attributes remembering the label which prevents any further use of the file, which is a problem for block devices. This also requires that the call to 'qemuBackupJobTerminate' from 'qemuProcessStop' happens only after 'vm->pid' was reset as otherwise the security subdrivers attempt to enter the process namespace which fails if the process isn't running any more. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1939082 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_backup.c | 36 ++++++++++++++++++++++++++---------- src/qemu/qemu_process.c | 8 ++++---- 2 files changed, 30 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c index f91d632715..430c11762c 100644 --- a/src/qemu/qemu_backup.c +++ b/src/qemu/qemu_backup.c @@ -28,6 +28,7 @@ #include "qemu_monitor_json.h" #include "qemu_checkpoint.h" #include "qemu_command.h" +#include "qemu_security.h" #include "storage_source.h" #include "storage_source_conf.h" @@ -558,25 +559,40 @@ qemuBackupJobTerminate(virDomainObjPtr vm, { qemuDomainObjPrivatePtr priv = vm->privateData; + g_autoptr(virQEMUDriverConfig) cfg = NULL; size_t i; - if (!(priv->backup->apiFlags & VIR_DOMAIN_BACKUP_BEGIN_REUSE_EXTERNAL) && - (priv->backup->type == VIR_DOMAIN_BACKUP_TYPE_PULL || - (priv->backup->type == VIR_DOMAIN_BACKUP_TYPE_PUSH && - jobstatus != QEMU_DOMAIN_JOB_STATUS_COMPLETED))) { + for (i = 0; i < priv->backup->ndisks; i++) { + virDomainBackupDiskDefPtr backupdisk = priv->backup->disks + i; - g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(priv->driver); + if (!backupdisk->store) + continue; + + /* restore security label on the images in case the blockjob finishing + * handler didn't do so, such as when the VM was destroyed */ + if (backupdisk->state == VIR_DOMAIN_BACKUP_DISK_STATE_RUNNING || + backupdisk->state == VIR_DOMAIN_BACKUP_DISK_STATE_NONE) { + if (qemuSecurityRestoreImageLabel(priv->driver, vm, backupdisk->store, + false) < 0) + VIR_WARN("Unable to restore security label on %s", + NULLSTR(backupdisk->store->path)); + } + + /* delete unneeded images created by libvirt */ + if (backupdisk->store->type == VIR_STORAGE_TYPE_FILE && + !(priv->backup->apiFlags & VIR_DOMAIN_BACKUP_BEGIN_REUSE_EXTERNAL) && + (priv->backup->type == VIR_DOMAIN_BACKUP_TYPE_PULL || + (priv->backup->type == VIR_DOMAIN_BACKUP_TYPE_PUSH && + jobstatus != QEMU_DOMAIN_JOB_STATUS_COMPLETED))) { - for (i = 0; i < priv->backup->ndisks; i++) { - virDomainBackupDiskDefPtr backupdisk = priv->backup->disks + i; uid_t uid; gid_t gid; - if (!backupdisk->store || - backupdisk->store->type != VIR_STORAGE_TYPE_FILE) - continue; + if (!cfg) + cfg = virQEMUDriverGetConfig(priv->driver); qemuDomainGetImageIds(cfg, vm, backupdisk->store, NULL, &uid, &gid); + if (virFileRemove(backupdisk->store->path, uid, gid) < 0) VIR_WARN("failed to remove scratch file '%s'", backupdisk->store->path); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 5f31260221..0b79dde2c3 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7822,10 +7822,6 @@ void qemuProcessStop(virQEMUDriverPtr driver, virResctrlAllocRemove(vm->def->resctrls[i]->alloc); } - /* clean up a possible backup job */ - if (priv->backup) - qemuBackupJobTerminate(vm, QEMU_DOMAIN_JOB_STATUS_CANCELED); - qemuProcessRemoveDomainStatus(driver, vm); /* Remove VNC and Spice ports from port reservation bitmap, but only if @@ -7877,6 +7873,10 @@ void qemuProcessStop(virQEMUDriverPtr driver, for (i = 0; i < vm->def->niothreadids; i++) vm->def->iothreadids[i]->thread_id = 0; + /* clean up a possible backup job */ + if (priv->backup) + qemuBackupJobTerminate(vm, QEMU_DOMAIN_JOB_STATUS_CANCELED); + /* Do this explicitly after vm->pid is reset so that security drivers don't * try to enter the domain's namespace which is non-existent by now as qemu * is no longer running. */ -- 2.29.2

2 1